[PAY NOW][$250] Scan - Can submit and approve a zero PDF receipt in Workspace

[nlemma]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.2.79-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-2403/folder/13176933/41237704/1080012348
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Windows 10/Chrome
App Component: Chat Report View

Action Performed:

Preconditions: User is an admin Workspace with set up delay submission: Manual and Approval enabled
Steps:

1. Open the NewDot app
2. Navigate to the Workspace chat, select Create expense -> Scan Receipt
3. Upload the receipt pdf with an amount is 0.00
4. Wait until the receipts have been scanned finish
5. Click Submit the new report with 0.00 amount
6. Click Approve the report

Expected Result:

The new report should display the View button when the amount is 0.00

Actual Result:

The user can submit and approve the 0.00 report

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Bug7031799_1765984335076.0.mp4

Bug7031799_1765951386457!PDF_receipt.pdf

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022001447603957315824
• Upwork Job ID: 2001447603957315824
• Last Price Increase: 2026-01-31

Issue Owner

Current Issue Owner: @jasperhuangg

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The user can submit and approve the 0.00 report

What is the root cause of that problem?

We have the logic check here

App/src/libs/ReportPrimaryActionUtils.ts

Lines 80 to 88 in f302e6f

	function isSubmitAction(
	report: Report,
	reportTransactions: Transaction[],
	policy?: Policy,
	reportNameValuePairs?: ReportNameValuePairs,
	violations?: OnyxCollection<TransactionViolation[]>,
	currentUserEmail?: string,
	currentUserAccountID?: number,
	) {

but in this case we have modifiedAmount as ""

=> transactionAreComplete is true

App/src/libs/ReportPrimaryActionUtils.ts

Line 96 in f302e6f

const transactionAreComplete = reportTransactions.every((transaction) => transaction.amount !== 0 || transaction.modifiedAmount !== 0);

What changes do you think we should make in order to solve the problem?

We should update this logic to

    const transactionAreComplete = reportTransactions.every((transaction) => transaction.amount !== 0 || Number(transaction.modifiedAmount) !== 0);

Then add the logic to check amount and modifiedAmount here

    if(!!transactions && transactions?.length > 0 && transactions.some((transaction) => (transaction.amount ?? 0) === 0 && (Number(transaction.modifiedAmount) ?? 0) === 0)) {
        return false;
    }

App/src/libs/ReportPreviewActionUtils.ts

Lines 25 to 33 in f302e6f

	function canSubmit(
	report: Report,
	isReportArchived: boolean,
	currentUserAccountID: number,
	currentUserEmail: string,
	violations?: OnyxCollection<TransactionViolation[]>,
	policy?: Policy,
	transactions?: Transaction[],
	) {

Note: we can do the same with other places that we show the submit and approve button

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The user can submit and approve the 0.00 report

What is the root cause of that problem?

modifiedAmount is returned as an empty string, so this check is passed for the submit action.

App/src/libs/ReportPrimaryActionUtils.ts

Line 96 in f302e6f

const transactionAreComplete = reportTransactions.every((transaction) => transaction.amount !== 0 || transaction.modifiedAmount !== 0);

What changes do you think we should make in order to solve the problem?

1. The backend shouldn't return modifiedAmount as empty string.

2. I checked the OldDot behavior, we still can submit/approve the expense with zero amount. So after the backend is fixed the submit button doesn't show for this expense so we should remove transactionAreComplete check. We already have the hasSmartScanFailedViolation to cover the scan failed

App/src/libs/ReportPrimaryActionUtils.ts

Line 96 in f302e6f

const transactionAreComplete = reportTransactions.every((transaction) => transaction.amount !== 0 || transaction.modifiedAmount !== 0);

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[annaweber830]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The new report should display the View button when the amount is 0.00

What is the root cause of that problem?

Validation functions don't check for zero total before allowing submit/approve actions. The existing check only covered the no-transactions case, not transactions that sum to $0.00.

What changes do you think we should make in order to solve the problem?

So we add logic for checking to ReportPreviewActionUtils.ts, ReportPrimaryActionUtils.ts, IOU.ts
The other files (ReportPreviewActionUtils, canSubmitReport, canApproveIOU) are additional entry points,

App/src/libs/ReportPreviewActionUtils.ts

Lines 25 to 33 in 0bc7edc

	function canSubmit(
	report: Report,
	isReportArchived: boolean,
	currentUserAccountID: number,
	currentUserEmail: string,
	violations?: OnyxCollection<TransactionViolation[]>,
	policy?: Policy,
	transactions?: Transaction[],
	) {

if (report?.total === 0) {
        return false;
    }

    return isExpense && (isSubmitter || isManager || isAdmin) && isOpen && !isAnyReceiptBeingScanned && !!transactions && transactions.length > 0;

App/src/libs/ReportPrimaryActionUtils.ts

Lines 80 to 88 in 0bc7edc

	function isSubmitAction(
	report: Report,
	reportTransactions: Transaction[],
	policy?: Policy,
	reportNameValuePairs?: ReportNameValuePairs,
	violations?: OnyxCollection<TransactionViolation[]>,
	currentUserEmail?: string,
	currentUserAccountID?: number,
	) {

if (report?.total === 0) {
        return false;
    }

    return isExpenseReport && isReportSubmitter && isOpenReport && reportTransactions.length !== 0 && transactionAreComplete;

App/src/libs/actions/IOU.ts

Line 10588 in 0bc7edc

function canApproveIOU(iouReport: OnyxTypes.OnyxInputOrEntry<OnyxTypes.Report>, policy: OnyxTypes.OnyxInputOrEntry<OnyxTypes.Policy>, iouTransactions?: OnyxTypes.Transaction[]) {

if (iouReport?.total === 0) {
        return false;
    }
    return (
        reportTransactions.length > 0 && isCurrentUserManager && !isOpenExpenseReport && !isApproved && !iouSettled && !isArchivedExpenseReport && !isPayAtEndExpenseReport && !isClosedReport
    );

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~022001447603957315824

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[parasharrajat]

If we can submit such reports in old dot. Then it makes sense to allow a new dot.

Thus, @nkdengineer's proposal makes more sense to me. We should fix the backend so that it returns correct values and then we can remove the extra check.

🎀 👀 🎀 C+ reviewed