[Due for payment 2026-01-21] Get rid of system message that triggers when an expense is moved from a personal space

[jamesdeanexpensify]

Background

Coming from this convo, we'd like to completely remove the system message that triggers when an expense is moved from a personal space.

Details

This is the system message we'd like to get rid of completely:

Issue Owner

Current Issue Owner: @lakchote

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[daledah]

🚨 Edited by proposal-police: This proposal was edited at 2025-12-18 19:27:03 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

We create the optimistic data for the system message here

App/src/libs/ReportUtils.ts

Lines 7543 to 7545 in 9410d79

	const [actionText, messageHtml] = isFromPersonalSpace
	? ['moved this expense from your personal space', `moved this expense from <a href='${url}' target='_blank' rel='noreferrer noopener'>your personal space</a>`]
	: [`moved this expense from ${reportName}`, `moved this expense from <a href='${url}' target='_blank' rel='noreferrer noopener'>${reportName}</a>`];

App/src/libs/ReportUtils.ts

Lines 7557 to 7558 in 9410d79

	html: messageHtml,
	text: actionText,

and Back End return the system message with action name MOVEDTRANSACTION with the fromReportID = "0"

What changes do you think we should make in order to solve the problem?

We should update the line to make sure that this system message is not visible

        const fromReport = fromReportID === CONST.REPORT.UNREPORTED_REPORT_ID ? false : !!allReports?.[`${ONYXKEYS.COLLECTION.REPORT}${fromReportID}`];
        return fromReport || !!toReport;

App/src/libs/ReportActionsUtils.ts

Line 900 in 1825540

const fromReport = fromReportID === CONST.REPORT.UNREPORTED_REPORT_ID ? true : !!allReports?.[`${ONYXKEYS.COLLECTION.REPORT}${fromReportID}`];

Then we should update the Back End to not return the system message with action name MOVEDTRANSACTION with the fromReportID = '"0"

Then we should remove translations and the logic related like here

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[github-actions]

⚠️ @daledah Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).

[samranahm]

🚨 Edited by proposal-police: This proposal was edited at 2025-12-18 19:26:29 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

Remove movedUnreportedTransaction system message

What changes do you think we should make in order to solve the problem?

App/src/languages/en.ts

Line 1172 in 14818a7

movedUnreportedTransaction: ({reportUrl}: MovedTransactionParams) => `moved this expense from your <a href="${reportUrl}">personal space</a>`,

We should remove movedUnreportedTransaction system message from all locals and from getMovedTransactionMessage

App/src/libs/ReportUtils.ts

Lines 7082 to 7088 in 14818a7

	if (fromReportID === CONST.REPORT.UNREPORTED_REPORT_ID) {
	reportUrl = `${environmentURL}/r/${findSelfDMReportID()}`;
	// eslint-disable-next-line @typescript-eslint/no-deprecated
	return translateLocal('iou.movedUnreportedTransaction', {
	reportUrl,
	});
	}

We also need to remove the move unreported expense optimistic action

What alternative solutions did you explore? (Optional)

We can also update BE to not return MOVEDTRANSACTION for unreported transection
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[github-actions]

⚠️ @samranahm Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).

[ShridharGoel]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When a user moves an expense out of a personal space, the app posts a system message (“moved this expense from your personal space”) into the transaction thread. We want this system message to stop appearing.

What is the root cause of that problem?

The optimistic MOVED_TRANSACTION report action builds and shows a message for moves from the personal space, and the visibility logic renders it:

App/src/libs/ReportUtils.ts

Lines 7535 to 7545 in 9410d79

	function buildOptimisticTransactionAction(
	type: typeof CONST.REPORT.ACTIONS.TYPE.MOVED_TRANSACTION | typeof CONST.REPORT.ACTIONS.TYPE.UNREPORTED_TRANSACTION,
	transactionThreadReportID: string | undefined,
	originalReportID: string,
	): ReportAction {
	const isFromPersonalSpace = originalReportID === CONST.REPORT.UNREPORTED_REPORT_ID;
	const reportName = allReports?.[`${ONYXKEYS.COLLECTION.REPORT}${originalReportID}`]?.reportName ?? '';
	const url = isFromPersonalSpace ? getReportURLForCurrentContext(findSelfDMReportID()) : getReportURLForCurrentContext(originalReportID);
	const [actionText, messageHtml] = isFromPersonalSpace
	? ['moved this expense from your personal space', `moved this expense from <a href='${url}' target='_blank' rel='noreferrer noopener'>your personal space</a>`]
	: [`moved this expense from ${reportName}`, `moved this expense from <a href='${url}' target='_blank' rel='noreferrer noopener'>${reportName}</a>`];

What changes do you think we should make in order to solve the problem?

Do not render MOVED_TRANSACTION actions that originate from the personal space by updating the visibility guard in src/libs/ReportActionsUtils.ts.

Updated visibility check:

if (isMovedTransactionAction(reportAction)) {
    const movedTransactionOriginalMessage = getOriginalMessage(reportAction);
    const toReportID = movedTransactionOriginalMessage?.toReportID;
    const fromReportID = movedTransactionOriginalMessage?.fromReportID;

    if (fromReportID === CONST.REPORT.UNREPORTED_REPORT_ID) { // This is the new check
        return false;
    }

    const toReport = allReports?.[`${ONYXKEYS.COLLECTION.REPORT}${toReportID}`];
    const fromReport = fromReportID === CONST.REPORT.UNREPORTED_REPORT_ID ? true : !!allReports?.[`${ONYXKEYS.COLLECTION.REPORT}${fromReportID}`];
    return fromReport || !!toReport;
}

[samranahm]

@jamesdeanexpensify Can you confirm if we will use default moved this expense from Expense Report 2019-11-02 message after removing the above mentioned message.

[jamesdeanexpensify]

@samranahm We will not, thanks!

[melvin-bot]

@aimane-chnaif Eep! 4 days overdue now. Issues have feelings too...