[Due for payment 2025-12-31] Expense - Review duplicates RHP loads infinitely after deleting expense

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.85-1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: Exploratory #77119
Email or phone of affected tester (no customers): oisjoidjonsjdosjs@gmail.com
Issue reported by: Applause Internal Team
Bug source: Pull Request QA execution
Device used: Mac 26.1 / Chrome
App Component: Money Requests

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Create two expenses with the same amount.
4. Open the expense report.
5. Click Review duplicates.
6. Click on the first expense preview.
7. Click More > Delete.
8. Delete the expense.

Expected Result:

Review duplicates RHP will close.

Actual Result:

Review duplicates RHP loads infinitely after deleting expense.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @sonialiap

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @yuwenmemon (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[nyomanjyotisa]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expense - Review duplicates RHP loads infinitely after deleting expense

What is the root cause of that problem?

When a transaction is deleted from the Review duplicates RHP, the page doesn't detect that there are no longer enough transactions to review duplicates (fewer than 2 transactions remain)

transactionsSelector filters out deleted transactions, but the we doesn't check if there are still enough valid transactions to justify staying on the review duplicates page

App/src/pages/TransactionDuplicate/Review.tsx

Lines 53 to 59 in 68d90e4

	const transactionsSelector = useCallback(
	(allTransactions: OnyxCollection<Transaction>) =>
	transactionIDs
	.map((id) => allTransactions?.[`${ONYXKEYS.COLLECTION.TRANSACTION}${id}`])
	.filter((transaction) => !!transaction)
	.sort((a, b) => new Date(a?.created ?? '').getTime() - new Date(b?.created ?? '').getTime()),
	[transactionIDs],

When a transaction is deleted, the transactions array updates but the RHP stays open, causing an infinite loading state because there's nothing left to review

What changes do you think we should make in order to solve the problem?

We can add a useEffect that monitors the transactions array and navigates back when there are fewer than 2 valid transactions remaining

    useEffect(() => {
        // If there are fewer than 2 transactions, there are no duplicates to review, so navigate back
        if (isLoadingPage || !transactions) {
            return;
        }

        if (transactions.length < 2) {
            Navigation.goBack(route.params.backTo);
        }
    }, [transactions, isLoadingPage, route.params.backTo]);

App/src/pages/TransactionDuplicate/Review.tsx

Line 114 in 68d90e4

What alternative solutions did you explore? (Optional)

None

[yuwenmemon]

Still seeing this on the revert of #77119