[READY FOR PAYMENT][$500] Implement closing the modal with resetting the browser history

[WojtekBoman]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.2.85-7
Reproducible in staging?: Yes
Reproducible in production?: Yes
Issue reported by: @WojtekBoman

Action Performed:

1. Launch the app
2. Go to workspace chat.
3. Create two expenses with the same amount.
4. Open the expense report.
5. Click Review duplicates.
6. Click on the first expense preview.
7. Click More > Delete.
8. Delete the expense.
9. Click on the browser forward button.

Expected Result:

It's not possible to open closed pages using the browser forward button.

Actual Result:

It's possible to open closed pages using the browser forward button.

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Screen.Recording.2025-12-23.at.08.15.17.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022003522877557734290
• Upwork Job ID: 2003522877557734290
• Last Price Increase: 2026-03-12

Issue Owner

Current Issue Owner: @sakluger

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[abbasifaizan70]

🚨 Edited by proposal-police: This proposal was edited at 2025-12-29 23:43:01 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

When reviewing duplicate expenses and deleting one of them, the browser's forward button still allows navigating to the deleted expense page.

What is the root cause of that problem?

The issue is in how navigation is handled after deleting an expense from the Review Duplicates flow. When the user deletes an expense, the app calls onBackButtonPress() which internally uses Navigation.goBack(backTo). This navigates back to the Review Duplicates page but does not clear the browser's forward history.

The Problem Flow:

1. User is on Review Duplicates page (entry A in browser history)
2. User clicks on an expense preview → navigation pushes new entry (entry B) - history: [A, B]
3. User deletes the expense → onBackButtonPress() is called
4. Navigation.goBack(backTo) navigates back to A
5. Browser's forward history still contains entry B (the deleted expense page)
6. Clicking forward button navigates to the deleted expense page

Root Cause Location:

In App/src/components/MoneyRequestHeader.tsx, the delete confirmation handler calls onBackButtonPress() without any special handling for the duplicate review flow:

// Lines 538-569 - Current implementation
onConfirm={() => {
    setIsDeleteModalVisible(false);
    // ... deletion logic ...
    onBackButtonPress(); // <-- Uses goBack which doesn't clear forward history
}}

The onBackButtonPress function (defined in ReportScreen.tsx) uses Navigation.goBack(backTo):

// Lines 391-394 in ReportScreen.tsx
if (prioritizeBackTo && backTo) {
    Navigation.goBack(backTo as Route);  // <-- Doesn't clear forward history
    return;
}

Why goBack doesn't work:

Navigation.goBack(route) internally uses goUp() which either:

• Pops back to the route if found in current state, OR
• Replaces the current route

In either case, the browser's forward history stack is not cleared. The browser's history API maintains its own forward/back stack independent of React Navigation's state.

What changes do you think we should make in order to solve the problem?

When deleting an expense from the Review Duplicates flow, use Navigation.navigate(backTo, {forceReplace: true}) instead of onBackButtonPress(). The forceReplace option tells the navigation to use history.replaceState() instead of history.pushState(), which clears the browser's forward history.

File: App/src/components/MoneyRequestHeader.tsx

Change:

onConfirm={() => {
    setIsDeleteModalVisible(false);
    if (!parentReportAction || !transaction) {
        throw new Error('Data missing');
    }
    if (isTrackExpenseAction(parentReportAction)) {
        deleteTrackExpense({
            chatReportID: report?.parentReportID,
            chatReport: parentReport,
            transactionID: transaction.transactionID,
            reportAction: parentReportAction,
            iouReport,
            chatIOUReport,
            transactions: duplicateTransactions,
            violations: duplicateTransactionViolations,
            isSingleTransactionView: true,
            isChatReportArchived: isParentReportArchived,
            isChatIOUReportArchived,
        });
    } else {
        deleteTransactions([transaction.transactionID], duplicateTransactions, duplicateTransactionViolations, currentSearchHash, true);
        removeTransaction(transaction.transactionID);
    }
+   // When coming from the Review Duplicates flow, use navigate with forceReplace
+   // to clear the browser's forward history. This prevents navigating back to the
+   // deleted expense page using the browser forward button.
+   if (isFromReviewDuplicates && route.params.backTo) {
+       Navigation.navigate(route.params.backTo, {forceReplace: true});
+       return;
+   }
    onBackButtonPress();
}}

Demo

Screen.Recording.2025-12-30.at.4.41.48.AM.mov

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~022003522877557734290

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Krishna2323 (External)

[melvin-bot]

@Krishna2323 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[Krishna2323]

Reviewing...