[$250] Reports - Deleting one split from "Top Spenders" section, makes both splits disappear.

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.96-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #78410
Email or phone of affected tester (no customers): ibellicotest+2250@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Motorola MotoG60 / Android 12 (Hybrid app) - Windows 11 / Chrome
App Component: Search

Action Performed:

Prerequisite: Account has at least one workspace.

1. Open the Expensify app.
2. Open any workspace chat.
3. Create two manual expenses with date from last month.
4. Open the report of the just created expenses.
5. Select one of the expenses.
6. Tap on dropdown menu and select "Split"
7. Save splits amount.
8. Navigate to "Reports" > "Top Spenders"
9. Expand the results displayed.
10. Open one of the splits.
11. Tap on "More" and delete the split.
12. Note that when you land on "Top Spenders" again, both splits disappear.
13. Reduce and expand the results again.
14. Note that kept split reappears after this last action.

Expected Result:

When one split of an expense is deleted while on "Top Spenders" section, the remaining split should still be visible.

Actual Result:

When deleting an split while on "Top Spenders" section, the remaining split also disappears. Split only reappears after reducing and expanding the results again.
Issue also reproduces on "Unapproved Cash" section. (Reproducible on Prod too on that section)

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022018757837493958383
• Upwork Job ID: 2018757837493958383
• Last Price Increase: 2026-03-09

Issue Owner

Current Issue Owner: @marufsharifi

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[MobileMage]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When viewing split transactions in grouped search views like "Top Spenders" or "Unapproved Cash", deleting one split causes both splits to disappear from the UI. The remaining split only reappears after collapsing and expanding the group again.

What is the root cause of that problem?

The issue is in how TransactionGroupListItem retrieves transaction data for grouped views. For non-expense-report groupings (like "Top Spenders" which groups by member), transactions come from snapshot data rather than live Onyx:

https://github.com/Expensify/App/blob/main/src/components/SelectionListWithSections/Search/TransactionGroupListItem.tsx#L96-L133

const [transactionsSnapshot] = useOnyx(`${ONYXKEYS.COLLECTION.SNAPSHOT}${groupItem.transactionsQueryJSON?.hash}`);

const transactions = useMemo(() => {
    if (isExpenseReportType) {
        return groupItem.transactions;
    }
    if (!transactionsSnapshot?.data) {
        return [];
    }
    // ... getSections from transactionsSnapshot
}, [...]);

When a split is deleted, updateSplitTransactions updates the remaining splits in ONYXKEYS.COLLECTION.TRANSACTION, but the grouped snapshot data (keyed by query hash) doesn't receive a proper optimistic update for the sibling splits. The snapshot becomes stale, causing the component to either return an empty array or filter out all related splits.

The collapse/expand workaround works because searchTransactions() re-fetches fresh data from the server, but this is inefficient and shouldn't be required.

What changes do you think we should make in order to solve the problem?

The fix should ensure the component uses real-time transaction data from Onyx as a fallback when snapshot data is incomplete. In TransactionGroupListItem.tsx, cross-reference with ONYXKEYS.COLLECTION.TRANSACTION to ensure splits that exist in Onyx (and aren't pending deletion) remain visible even if the snapshot is stale:

+    const [allTransactions] = originalUseOnyx(ONYXKEYS.COLLECTION.TRANSACTION, {canBeMissing: true});

     const transactions = useMemo(() => {
         // ...
         const [sectionData] = getSections({...}) as [TransactionListItemType[], number];
-        return sectionData.map((transactionItem) => ({
+        return sectionData.filter((transactionItem) => {
+            const liveTransaction = allTransactions?.[`${ONYXKEYS.COLLECTION.TRANSACTION}${transactionItem.transactionID}`];
+            return liveTransaction && liveTransaction.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE;
+        }).map((transactionItem) => ({
             ...transactionItem,
             isSelected: selectedTransactionIDsSet.has(transactionItem.transactionID),
         }));
-    }, [...]);
+    }, [..., allTransactions]);

This approach uses live Onyx data as the source of truth for transaction existence, avoiding reliance on potentially stale snapshot data and eliminating the need for any refetch.

What alternative solutions did you explore? (Optional)

N/A

[trjExpensify]

Doesn't seem related to the new Top spenders suggested search specifically, but seemingly any group-by suggested search view. CC: @luacmartins @JS00001 for vis.

[luacmartins]

This proposal seems correct, but we are already solving that in a more general way here #78877

[trjExpensify]

Got it, so sounds like we shouldn't move forward with a conflicting proposal then?

[luacmartins]

Yea, let's hold on this

[trjExpensify]

Done!