[HOLD for payment 2023-02-03] [$250] Audit forms and fix inconsistencies with focus, tab and shift + tab behavior 2/4

[dylanexpensify]

We should audit all our forms and fix any inconsistencies with focus, tab, shift + tab and enter behavior. The expected behavior is as follows:

1. Tab navigates to the next input.
2. Shift + tab navigates to the previous input.
3. Enter submits the form.
4. Space toggles checkboxes/dropdowns.

Note: We should make sure that tabbing cycles through the form in an order that makes sense, usually top to bottom.

Here's a list of forms to be audited:

• RequestorStep.js (INTERNAL)
• ValidationStep.js (INTERNAL)
• Workspace - Invite new members
• Workspace - General settings
• Set password

Upwork job link: https://www.upwork.com/jobs/~0197285630ce0fa6fa https://www.upwork.com/jobs/~01a2053d2c6b3432b4

[MelvinBot]

Triggered auto assignment to @nickmurray47 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[MelvinBot]

Triggered auto assignment to @michaelhaxhiu (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[dylanexpensify]

Note: decision to split this main issue up into smaller issues came from this convo

[MelvinBot]

@michaelhaxhiu, @nickmurray47 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[michaelhaxhiu]

Note: decision to split this main issue up into smaller issues came from this convo

Does this job need to be posted to upwork in a particular fashion basically? Would it be 1 job for everything or 5 jobs (linked to 1 GH issue)?

[nickmurray47]

@michaelhaxhiu I personally think it should be 1 job since I assume the fix will be the same for all forms. I can see the argument for splitting it up into multiple jobs but I think whichever contributor suggests the best fix should just do all of the forms in one go.

[michaelhaxhiu]

cool thanks nick. @dylanexpensify said the same in a DM.