-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Closed
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.Something is broken. Auto assigns a BugZero manager.DailyKSv2KSv2
Description
Coming from here
Right now, after a user signs out, some pending network requests still trigger reauthentication. This results in a lot of auth errors in Sentry that will always fail, since the credentials have already been cleared.
By checking credentials earlier and skipping the reauth flow entirely in this case, we can:
- Avoid unnecessary API calls
- Reduce Sentry noise (around ~2 errors per sign-out)
- Slightly speed up the transition to the sign-in screen
- Slightly reduce backend load by avoiding failed API calls
Example Sentry issue:
https://expensify.sentry.io/issues/7122416301/?environment=production&query=authentica[…]3A%5Breauthenticate%2CAuthenticate%5D&referrer=issue-stream
Issue Owner
Current Issue Owner: @JmillsExpensifyReactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.Something is broken. Auto assigns a BugZero manager.DailyKSv2KSv2
Type
Projects
Status
Done