[Due for payment 2026-01-21] Expense - Wrong converted amount on merge confirm page

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.0-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #78622
Email or phone of affected tester (no customers): jsdoisjdnodjosjdsid@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.1 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

• Set workspace default currency to USD.

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Create an expense with amount AUD 100.00.
4. Create another expense with amount EUR 500.00.
5. Open the expense report.
6. Open both expenses and remember the converted amount.
   AUD 100.00 → $67.08.
   EUR 500.00 → $583.37
7. Select the first expense (AUD 100.00) via checkbox.
8. Click dropdown button > Merge.
9. Select the other expense (EUR 500.00) > Continue.
10. Select amount EUR 500.00.
11. Click Next.

Expected Result:

On confirm page, the converted amount will be $583.37.

Actual Result:

On confirm page, the converted amount is $67.08, which is not equivalent to EUR 500.00.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Bug7047816_1768297085905.10.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @lydiabarclay

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #78622

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[melvin-bot]

Triggered auto assignment to @lydiabarclay (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[OSBotify]

🔍 Investigation Summary

Classification: Frontend bug
Causing PR: #78979 - "[Part 1] Remove Onyx.connect() for the key: ONYXKEYS.COLLECTION.REPORT in src/libs/actions/IOU.ts" by @parasharrajat (High confidence)
Related Issues: None

Recommendation: REVERT

The bug is caused by PR #78979 which refactored how transaction reports are passed to money request update functions. While the PR correctly updated the parameter signatures throughout the codebase, it inadvertently introduced a bug in the merge transaction flow.

📋 Detailed Analysis

Evidence

1. Reproducible only on staging: The issue is reported as reproducible on staging but not in production, indicating it was introduced in the current deploy cycle
2. PR [Part 1] Remove Onyx.connect() for the key: ONYXKEYS.COLLECTION.REPORT in src/libs/actions/IOU.ts #78979 modified the merge confirmation page: This PR changed src/pages/TransactionMerge/ConfirmationPage.tsx and how it passes data to merge transactions
3. The bug affects converted amounts in merge flow: When merging expenses with different currencies, the wrong converted amount is displayed on the confirmation page

Root Cause

The bug occurs in the merge transaction confirmation flow:

1. User selects EUR 500.00 expense (which converts to $583.37)
2. The merge transaction data is built using buildMergedTransactionData() in src/libs/MergeTransactionUtils.ts
3. This function copies fields from the selected transactions but does NOT update the convertedAmount field when the currency changes
4. The merged transaction inherits convertedAmount from the target transaction (AUD 100 → $67.08) even though the amount/currency was changed to EUR 500
5. MoneyRequestView displays this stale convertedAmount value ($67.08) on line 470

Specific issue: In buildMergedTransactionData() (lines 332-362 of MergeTransactionUtils.ts), when building the merged transaction object, the function sets:

• amount: mergeTransaction.amount (EUR 500)
• modifiedCurrency: mergeTransaction.currency (EUR)

But it does NOT set convertedAmount, so it inherits the old value from targetTransaction.convertedAmount (AUD $67.08).

The bug was introduced because PR #78979 refactored the transaction update flow but did not account for the fact that convertedAmount needs to be recalculated when merging transactions with different currencies. The buildMergedTransactionData function should either:

1. Calculate and set the correct convertedAmount based on the selected currency, or
2. Explicitly set it to undefined so the display logic can handle it appropriately

PR #78622 (which added converted amount display) is NOT the cause - it simply displays the data. The bug is in PR #78979 which fails to provide the correct data during the merge flow.