[Payment due] [$250] Trip - Tapping Book trip directs to hmm not here page

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: V9.3.4-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-3028/folder/13177079/41237920/1131712749
Email or phone of affected tester (no customers): dreamnitethedragon+yydyd373@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Redminote 10S Android 13
App Component: User Settings

Action Performed:

1. Launch app
2. Login with new gmail account
3. Go to reports - from "type" dropdown select "trip" and apply
4. Tap Book a trip
5. Note user directed to hmm not here page
6. Tap app top back arrow
7. Note user directed to hmm not here page
   8.Tap app top back arrow
8. Note user directed to Workspaces section

Expected Result:

Tapping Book a trip musnt direct to hmm not here page.

Actual Result:

Tapping Book a trip directs to hmm not here page.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

1.mp4

Issue Owner

Current Issue Owner: @garrettmknight

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022025862519951345500
• Upwork Job ID: 2025862519951345500
• Last Price Increase: 2026-02-23

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[MobileMage]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When a new user (with a gmail account, no paid workspaces) taps "Book a trip" from the empty trip search results, they are redirected to a "hmm not here" (NotFoundPage) instead of seeing the appropriate travel error page.

What is the root cause of that problem?

When the user clicks "Book a trip", the BookTravelButton component at src/components/BookTravelButton.tsx:99-103 checks if there are any private email domains for the admin. For a gmail user, this returns an empty array (gmail.com is a public domain), so navigation goes to ROUTES.TRAVEL_PUBLIC_DOMAIN_ERROR.

The PublicDomainErrorPage at src/pages/Travel/PublicDomainErrorPage.tsx:26-30 wraps its content with AccessOrNotFoundWrapper using:

• policyID={activePolicyID} - fetched from NVP_ACTIVE_POLICY_ID
• featureName={CONST.POLICY.MORE_FEATURES.IS_TRAVEL_ENABLED}

For a new user without workspaces, activePolicyID is undefined. The AccessOrNotFoundWrapper then calls isPolicyAccessible(undefined, login) at src/libs/PolicyUtils.ts:1480-1488, which returns false because the policy is empty. This sets isPolicyNotAccessible = true, causing shouldShowNotFoundPage to be true, which renders the "not found" page instead of the actual error content.

What changes do you think we should make in order to solve the problem?

Remove the AccessOrNotFoundWrapper from PublicDomainErrorPage.tsx. This page is an error information page that should be accessible to all users regardless of whether they have a valid workspace - it's explaining why they can't use travel (public email domain), which doesn't require policy access verification.

The fix in src/pages/Travel/PublicDomainErrorPage.tsx is to replace AccessOrNotFoundWrapper with just ScreenWrapper, similar to how other travel error/info pages handle this case. The content inside remains the same.

What alternative solutions did you explore? (Optional)

Move the groupPaidPolicies.length < 1 check before the adminDomains.length === 0 check. However, this changes the user flow and the public domain error is still a valid page that should work when accessed.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~022013247823016365248

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @bernhardoj (External)

[paulnjs]

🚨 Edited by proposal-police: This proposal was edited at 2026-01-21 04:00:58 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Tapping Book a trip directs to hmm not here page.

What is the root cause of that problem?

If we login with the account that doesn’t have any workspace, the nvp_expensify_activePolicyID will be the personal policy (the default one). When users press Book a trip button, we’ll navigate to the personal policy that’s not found page

App/src/components/BookTravelButton.tsx

Lines 105 to 108 in 6fa8428

	if (groupPaidPolicies.length < 1) {
	Navigation.navigate(ROUTES.TRAVEL_UPGRADE.getRoute(Navigation.getActiveRoute()));
	return;
	}

What changes do you think we should make in order to solve the problem?

In EmptySearchView, we should return undefined for activePolicy if it’s the personal policy

Here’s the sample code (we can change it in the PR phase)

   const [activePolicyEntry] = useOnyx(`${ONYXKEYS.COLLECTION.POLICY}${activePolicyID}`, {canBeMissing: true});
    // Only use the active policy if it's a valid paid group policy (not personal) and not pending deletion
    const activePolicy = isPaidGroupPolicy(activePolicyEntry) && !isPendingDeletePolicy(activePolicyEntry) ? activePolicyEntry : undefined;

Or we can find the defaultPolicy (the active policy that’s not personal one), pass it to EmptySearchViewContent

Then hide BookTravelButton if activePolicyID is empty

{defaultPolicy?.id && <BookTravelButton
                        text={translate('search.searchResults.emptyTripResults.buttonText')}
                        activePolicyID={defaultPolicy?.id}
                    />}

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[huult]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Tapping Book trip directs to hmm not here page

What is the root cause of that problem?

This issue happened because we recently added AccessOrNotFoundWrapper to PublicDomainErrorPage. (https://github.com/Expensify/App/pull/76611/changes)

App/src/components/BookTravelButton.tsx

Line 101 in 7406d2e

Navigation.navigate(ROUTES.TRAVEL_PUBLIC_DOMAIN_ERROR.getRoute(Navigation.getActiveRoute()));

App/src/pages/Travel/PublicDomainErrorPage.tsx

Line 27 in 7a5baaa

<AccessOrNotFoundWrapper

As a result, the navigation flow becomes:
PublicDomainErrorPage → openWorkspace → [openWorkspaceMoreFeature](

App/src/pages/workspace/AccessOrNotFoundWrapper.tsx

Line 193 in 820cf20

Navigation.isNavigationReady().then(() => Navigation.goBack(ROUTES.WORKSPACE_MORE_FEATURES.getRoute(policyID)));

).

Since this flow relies on activePolicy, and there is no active workspace in this case, both openWorkspace and openWorkspaceMoreFeature fail to find a valid workspace. This causes the app to navigate back twice, returning the user to the workspace list.

App/src/pages/Travel/PublicDomainErrorPage.tsx

Line 24 in 7a5baaa

const [activePolicyID] = useOnyx(ONYXKEYS.NVP_ACTIVE_POLICY_ID, {canBeMissing: true});

What changes do you think we should make in order to solve the problem?

I think we should check whether the user has no workspace on PublicDomainErrorPage. If so, we should redirect them to TRAVEL_UPGRADE. After the upgrade flow, we can either redirect them back to PublicDomainErrorPage or handle the next step accordingly. We can discuss the exact behavior in the PR.

App/src/pages/Travel/PublicDomainErrorPage.tsx

Line 25 in 7a5baaa

add:

    const [policies] = useOnyx(ONYXKEYS.COLLECTION.POLICY, {canBeMissing: false});
    const {login: currentUserLogin} = useCurrentUserPersonalDetails();
    const activePolicies = getActivePolicies(policies, currentUserLogin);
    const groupPaidPolicies = activePolicies.filter((activePolicy) => activePolicy.type !== CONST.POLICY.TYPE.PERSONAL && isPaidGroupPolicy(activePolicy));

    useEffect(() => {
      if (groupPaidPolicies.length < 1) {
          Navigation.navigate(ROUTES.TRAVEL_UPGRADE.getRoute(Navigation.getActiveRoute()));
          return;
      }
    }, [])

or

App/src/components/BookTravelButton.tsx

Line 99 in 7406d2e

const adminDomains = getAdminsPrivateEmailDomains(policy);

add:

         if (groupPaidPolicies.length < 1 && adminDomains.length === 0) {
            Navigation.navigate(ROUTES.TRAVEL_UPGRADE.getRoute(Navigation.getActiveRoute()));
            return;
      }

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[bernhardoj]

@paulnjs proposal is on the same direction of what I'm thinking, but instead of disabling it, I think we should hide the "Book a trip" button the same way we hide the "Book travel" from the FAB.

But let's hear from @Expensify/design first