[Due for payment 2026-03-16] [$250] Search - Expense search shows incorrect amount from recent searches

[vincdargento]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: V9.3.4-3
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-1235/41237508/945415127?q=filter&issue_type=jira
Email or phone of affected tester (no customers): Dreamnitethedragon+xhs@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Redminote 10s android 13
App Component: User Settings

Action Performed:

1. Launch app
2. Tap search
3. Enter amount:6 and tap enter
4. Note user directs to reports page showing search query with amount 6 correctly
5. Tap inbox - search
6. Tap from Recent searches type:expense amount:6 and tap enter
7. Now note user directs to reports page showing search query with amount 600 incorrectly

Expected Result:

When selecting Recent search: type:expense amount:6, the user should be redirected to the Reports page showing the search query with amount 6.

Actual Result:

When selecting Recent search: type:expense amount:6, the user is redirected to the Reports page showing the search query with amount 600.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022013778471388922258
• Upwork Job ID: 2013778471388922258
• Last Price Increase: 2026-01-28

Issue Owner

Current Issue Owner: @mallenexpensify

[melvin-bot]

Triggered auto assignment to @lydiabarclay (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[yatin-italy]

Proposal

Restate the problem this issue is trying to solve.
When a user selects a recent search with amount:6, it shows as amount:600 on the Reports page. The amount value is wrong after the search is replayed.

What is the root cause of that problem?

• In SearchRouter.submitSearch, recent and saved searches go through getQueryWithUpdatedValues.
• Amount conversion is not skipped.
• The amount was already converted before, so it gets multiplied by 100 again.

What changes do you think we should make in order to solve the problem?

• Amount filters must be converted to backend cents only one time.

Add a flag to control this behavior.
When submitting recent or saved searches, skip amount conversion.
When submitting free-text searches, keep the conversion.

Concrete changes:

• Add a shouldSkipAmountConversion flag to submitSearch.
• Pass this flag from onListItemPress.
• Forward the flag to getQueryWithUpdatedValues.

File: src/components/Search/SearchRouter/SearchRouter.tsx
Functions: submitSearch, onListItemPress
Scope: one file, two call sites

// submitSearch now accepts skip flag and forwards it
const submitSearch = useCallback(
    (queryString: SearchQueryString, shouldSkipAmountConversion = false) => {
        const queryWithSubstitutions = getQueryWithSubstitutions(queryString, autocompleteSubstitutions);
        const updatedQuery = getQueryWithUpdatedValues(queryWithSubstitutions, shouldSkipAmountConversion);
        if (!updatedQuery) {
            return;
        }

        setShouldResetSearchQuery(false);
        backHistory(() => {
            onRouterClose();
            setSearchContext(true);
            Navigation.navigate(ROUTES.SEARCH_ROOT.getRoute({query: updatedQuery}));
        });

        setTextInputValue('');
        setAutocompleteQueryValue('');
    },
    [autocompleteSubstitutions, onRouterClose, setTextInputValue, setShouldResetSearchQuery],
);

// When selecting stored (non-findItem) items, skip double conversion
} else {
    submitSearch(item.searchQuery, item.keyForList !== 'findItem');
    Log.info('[CMD_K_DEBUG] Search submitted', {
        actionId,
        duration: Date.now() - startTime,
        searchQuery: item.searchQuery,
        timestamp: Date.now(),
    });
}

What alternative solutions did you explore? (Optional)
N/A

[vildanL]

Proposal

Restate the problem this issue is trying to solve.

Selecting a recent or saved search containing an amount filter (for example amount:6) results in an incorrect query (amount:600) on the Reports page.

This happens because the search query is normalized again during replay, even though the query was already normalized when it was originally created.

What is the root cause of that problem?

getQueryWithUpdatedValues assumes all incoming queries are raw user input and blindly normalizes numeric filters such as amount.

However, recent and saved searches are not raw input:

They are already user-friendly

They may already contain backend-ready values

Re-normalizing them causes double conversion

The current architecture does not distinguish between:

Queries authored by the user in the input

Queries replayed from persisted search history

Proposed solution

Instead of adding a submission-level flag, make query normalization aware of the query origin.

Introduce the concept of a “pre-normalized query”, and ensure normalization logic only applies to raw user-authored input.

Design
1. Introduce a lightweight query source enum
type SearchQuerySource = 'userInput' | 'storedQuery';

2. Update submitSearch to accept query source

const submitSearch = useCallback(
    (queryString: SearchQueryString, source: SearchQuerySource = 'userInput') => {
        const queryWithSubstitutions = getQueryWithSubstitutions(queryString, autocompleteSubstitutions);

        const updatedQuery =
            source === 'storedQuery'
                ? queryWithSubstitutions
                : getQueryWithUpdatedValues(queryWithSubstitutions);

        if (!updatedQuery) {
            return;
        }

        setShouldResetSearchQuery(false);

        backHistory(() => {
            onRouterClose();
            setSearchContext(true);
            Navigation.navigate(ROUTES.SEARCH_ROOT.getRoute({query: updatedQuery}));
        });

        setTextInputValue('');
        setAutocompleteQueryValue('');
    },
    [autocompleteSubstitutions, onRouterClose, setTextInputValue, setShouldResetSearchQuery],
);

3. Pass the correct source from onListItemPress

} else {
    const source =
        item.keyForList === 'findItem'
            ? 'userInput'
            : 'storedQuery';

    submitSearch(item.searchQuery, source);

    Log.info('[CMD_K_DEBUG] Search submitted', {
        actionId,
        duration: Date.now() - startTime,
        searchQuery: item.searchQuery,
        source,
        timestamp: Date.now(),
    });
}

[melvin-bot]

📣 @vildanL! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[vildanL]

Contributor details
Your Expensify account email: vildan.loncarevic@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01a60adc2ba0e93cc1

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~022013778471388922258