[$250] Add BA - Business Information step is skipped when connecting non-US BA

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.7-3
Reproducible in staging?: Yes
Reproducible in production?: Unable to validate in Prod - Provide reasoning.
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/folder/13176691/test-cases/41236748
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Bug source: Regression TC Execution
Device used: MacBook Air 15.7.3 Chrome
App Component: Other

Action Performed:

1. Sign in to ND
2. Create a workspace, selecting AUD as a primary currency
3. Proceed through steps 1-2, entering random info, that does not trigger an error
4. On the confirmation screen at the end of step 2 click "Confirm"

Expected Result:

User is navigated to step 3 "What's the business name" page

Actual Result:

Step 3 "Business information" is skipped, user is navigated to the step 4 (sometimes even step 5)

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Bug7056597_1769190701949.Steps_skipped_AUD_BA.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022014772193439070623
• Upwork Job ID: 2014772193439070623
• Last Price Increase: 2026-01-30

Issue Owner

Current Issue Owner: @brianlee-expensify

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~022014772193439070623

[melvin-bot]

Triggered auto assignment to @brianlee-expensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (External)

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When creating a workspace with AUD currency (non-USD), after completing step 2 (Bank Info) and clicking "Confirm", step 3 (Business Information) is skipped and the user is navigated directly to step 4 or 5.

What is the root cause of that problem?

The issue is caused by a race condition with asynchronous Onyx state updates across multiple steps.

In BankInfo.tsx (step 2), when the API succeeds:

App/src/pages/ReimbursementAccount/NonUSD/BankInfo/BankInfo.tsx

Lines 64 to 73 in c9e36d3

	useEffect(() => {
	if (reimbursementAccount?.isLoading === true || !!reimbursementAccount?.errors) {
	return;
	}
	if (reimbursementAccount?.isSuccess === true) {
	onSubmit();
	clearReimbursementAccountBankCreation();
	}
	}, [corpayFields?.bankCurrency, country, currency, onSubmit, reimbursementAccount?.errors, reimbursementAccount?.isLoading, reimbursementAccount?.isSuccess]);

The clearReimbursementAccountBankCreation() function uses Onyx.merge() which is asynchronous:

App/src/libs/actions/BankAccounts.ts

Lines 981 to 983 in c9e36d3

	function clearReimbursementAccountBankCreation() {
	Onyx.merge(ONYXKEYS.REIMBURSEMENT_ACCOUNT, {isCreateCorpayBankAccount: null, isSuccess: null, isLoading: null});
	}

When BusinessInfo.tsx (step 3) mounts, it also has a similar useEffect:

App/src/pages/ReimbursementAccount/NonUSD/BusinessInfo/BusinessInfo.tsx

Lines 112 to 126 in c9e36d3

	useEffect(() => {
	// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
	if (reimbursementAccount?.errors || reimbursementAccount?.isSavingCorpayOnboardingCompanyFields || !reimbursementAccount?.isSuccess) {
	return;
	}
	if (reimbursementAccount?.isSuccess) {
	onSubmit();
	clearReimbursementAccountSaveCorpayOnboardingCompanyDetails();
	}
	return () => {
	clearReimbursementAccountSaveCorpayOnboardingCompanyDetails();
	};
	}, [reimbursementAccount?.errors, reimbursementAccount?.isSavingCorpayOnboardingCompanyFields, reimbursementAccount?.isSuccess, onSubmit]);

The race condition:

1. BankInfo (step 2) succeeds, isSuccess becomes true
2. BankInfo calls onSubmit() to move to BusinessInfo (step 3)
3. BankInfo calls clearReimbursementAccountBankCreation() to reset isSuccess to null (async)
4. BusinessInfo mounts before the Onyx merge completes
5. BusinessInfo sees isSuccess === true (from step 2's success)
6. BusinessInfo immediately calls onSubmit(), skipping to step 4

The same cascade can occur for subsequent steps, causing step 4 and 5 to also be skipped.

What changes do you think we should make in order to solve the problem?

Add a step-specific flag check to ensure we only proceed when this step's API was called, not a previous step's. Each step already has a unique loading flag (e.g., isSavingCorpayOnboardingCompanyFields for BusinessInfo). We should track when this flag transitions from true to false with isSuccess === true.

In BusinessInfo.tsx:

+const prevIsSaving = usePrevious(reimbursementAccount?.isSavingCorpayOnboardingCompanyFields);

 useEffect(() => {
-    if (reimbursementAccount?.errors || reimbursementAccount?.isSavingCorpayOnboardingCompanyFields || !reimbursementAccount?.isSuccess) {
+    // Only proceed if THIS step's API call completed successfully (not a previous step's)
+    if (
+        reimbursementAccount?.errors ||
+        reimbursementAccount?.isSavingCorpayOnboardingCompanyFields ||
+        !reimbursementAccount?.isSuccess ||
+        !prevIsSaving  // Ensure we were actually saving from this step
+    ) {
         return;
     }

     if (reimbursementAccount?.isSuccess) {
         onSubmit();
         clearReimbursementAccountSaveCorpayOnboardingCompanyDetails();
     }
-}, [reimbursementAccount?.errors, reimbursementAccount?.isSavingCorpayOnboardingCompanyFields, reimbursementAccount?.isSuccess, onSubmit]);
+}, [reimbursementAccount?.errors, reimbursementAccount?.isSavingCorpayOnboardingCompanyFields, reimbursementAccount?.isSuccess, onSubmit, prevIsSaving]);

What alternative solutions did you explore? (Optional)

Or we can add the Navigation.setNavigationActionToMicrotaskQueue to wrap onSubmit();

        if (reimbursementAccount?.isSuccess) {
            clearReimbursementAccountBankCreation();
            Navigation.setNavigationActionToMicrotaskQueue(()=>{
                onSubmit();
            })
        }

[DylanDylann]

I can't reproduce

Screen.Recording.2026-01-26.at.14.15.51.mov

@daledah can you reproduce this bug on now?

[daledah]

@DylanDylann i can reproduce it with a new AUD workspace

bug.mov

[DylanDylann]

Thanks @daledah, I can reproduce it now after installing the new node module