Room - App crashed after tap on room name and unable log in app again after that.

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to staging.new.expensify.com
2. Log in with exensifail account
3. Tap on FAB menu
4. Tap New Room
5. Put any room name and select Workspace
6. Tab Continue
7. Tap on Room name on top of the app

Expected Result:

After tap on room name, setting page is open

Actual Result:

App crashed and unable log in after tap on sign out

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.1.41.4

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): applausetester+0707abb@applause.expensifail.com

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5482140_Screen_Recording_20220307-210459_Chrome.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause (Exploratory)

Slack conversation:

Issue were found when execute the PR: #8011

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @Julesssss (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[francoisl]

@TomatoToaster this was found while testing #8011, do you have any idea?

[francoisl]

Hmm @kbecciv to clarify, the PR #8011 you were testing should have been version v1.1.41-5. Any chance you can try again please? I can't reproduce on version 1.1.41-5.

[kbecciv]

@francoisl I able to reproduce it with build 1.1.41-5

Screen_Recording_20220308-175541_New.Expensify.mp4

[francoisl]

Ah ok thanks for confirming.
I can reproduce on dev if I check out the tag 1.1.41-5 specifically, but not on main - going to investigate.
cc @TomatoToaster if you're still around.

[francoisl]

Ok so what I see is that OptionsListUtils.getAvatarSources() doesn't exist on 1.1.41-5, that's what's causing the crash. Seems to have to do with the CP PR for 8011, #8013 👀

[Julesssss]

Thanks for investigating @francoisl, I can confirm what you're seeing. I see that the function was renamed here (explained here), so I'm going to submit a PR that simply reverts the name

[Julesssss]

It looks like we cherry-picked a fix that depends on a PR that wasn't yet on staging (and wasn't also cherry-picked).

I'm hesitant to cherry-pick such a large and potentially breaking PR to staging. The alternative is to cherry-pick a 'fix' that reverts the original cherry-picked fix. It's starting to get confusing 😄 -- I'm going to ask in Slack to get a second opinion here