[$250] Workspace - Unable to open Expense policy RHP as it auto closes

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.8-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://github.com/Expensify/Expensify/issues/479400
Email or phone of affected tester (no customers): applausetester+d22d2@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.1 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

• Log in with Expensifail account.

1. Go to staging.new.expensify.com
2. Go to workspace settings > Overview.
3. Click Expense policy.

Expected Result:

Expense policy RHP will not auto close.

Actual Result:

Expense policy RHP auto closes.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022015818218082395144
• Upwork Job ID: 2015818218082395144
• Last Price Increase: 2026-01-26

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @twisterdotcom

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When users with the Custom Rules beta enabled click on "Expense policy" in Workspace Settings > Overview, the RHP (Right Hand Panel) auto-closes immediately instead of staying open.

What is the root cause of that problem?

There is a mismatch between the condition to show the "Expense policy" option and the condition to access the RulesCustomPage:

1. In WorkspaceOverviewPage.tsx, the "Expense policy" section is conditionally rendered based on the beta flag isBetaEnabled(CONST.BETAS.CUSTOM_RULES):

App/src/pages/workspace/WorkspaceOverviewPage.tsx

Lines 689 to 711 in d2334c9

	{isBetaEnabled(CONST.BETAS.CUSTOM_RULES) ? (
	<Section
	isCentralPane
	title={translate('workspace.editor.policy')}
	titleStyles={[styles.textHeadline, styles.cardSectionTitle, styles.accountSettingsSectionTitle, styles.mb0]}
	subtitle={translate('workspace.rules.customRules.cardSubtitle')}
	subtitleStyles={[styles.mb6]}
	subtitleTextStyles={[styles.textNormal, styles.colorMuted, styles.mr5]}
	containerStyles={shouldUseNarrowLayout ? styles.p5 : styles.p8}
	>
	<OfflineWithFeedback pendingAction={policy?.pendingFields?.customRules}>
	<MenuItemWithTopDescription
	title={policy?.customRules ?? ''}
	description={translate('workspace.editor.policy')}
	shouldShowRightIcon={!readOnly}
	interactive={!readOnly}
	wrapperStyle={styles.sectionMenuItemTopDescription}
	onPress={() => Navigation.navigate(ROUTES.RULES_CUSTOM.getRoute(route.params.policyID))}
	shouldRenderAsHTML
	/>
	</OfflineWithFeedback>
	</Section>
	) : null}

2. However, RulesCustomPage.tsx uses AccessOrNotFoundWrapper with featureName={CONST.POLICY.MORE_FEATURES.ARE_RULES_ENABLED}, which checks if the workspace feature areRulesEnabled is enabled:

App/src/pages/workspace/rules/RulesCustomPage.tsx

Lines 43 to 47 in d2334c9

	<AccessOrNotFoundWrapper
	policyID={policyID}
	accessVariants={[CONST.POLICY.ACCESS_VARIANTS.ADMIN, CONST.POLICY.ACCESS_VARIANTS.PAID]}
	featureName={CONST.POLICY.MORE_FEATURES.ARE_RULES_ENABLED}
	>

3. When isFeatureEnabled is false (workspace doesn't have Rules enabled), AccessOrNotFoundWrapper automatically navigates back:

App/src/pages/workspace/AccessOrNotFoundWrapper.tsx

Lines 187 to 198 in d2334c9

	useEffect(() => {
	if (!isFocused || isFeatureEnabled || (pendingField && !isOffline && !isFeatureEnabled) || shouldShowNotFoundPage) {
	return;
	}
	// When a workspace feature linked to the current page is disabled we will navigate to the More Features page.
	Navigation.setNavigationActionToMicrotaskQueue(() => {
	Navigation.goBack(ROUTES.WORKSPACE_MORE_FEATURES.getRoute(policyID));
	});
	// We don't need to run the effect on policyID change as we only use it to get the route to navigate to.
	// eslint-disable-next-line react-hooks/exhaustive-deps
	}, [pendingField, isOffline, isFeatureEnabled, shouldShowNotFoundPage, isFocused]);

Since these are two different feature flags (beta flag vs workspace feature), users who have the beta enabled but haven't enabled the Rules feature on their workspace will see the option but cannot access the page.

What changes do you think we should make in order to solve the problem?

Remove the featureName prop from RulesCustomPage.tsx since the "Custom Rules" (Expense Policy) feature is a separate beta feature and should not depend on the workspace areRulesEnabled setting.

 <AccessOrNotFoundWrapper
     policyID={policyID}
     accessVariants={[CONST.POLICY.ACCESS_VARIANTS.ADMIN, CONST.POLICY.ACCESS_VARIANTS.PAID]}
-    featureName={CONST.POLICY.MORE_FEATURES.ARE_RULES_ENABLED}
 >

This ensures that users with the Custom Rules beta can access the Expense Policy page regardless of whether the Rules feature is enabled on the workspace.

What alternative solutions did you explore? (Optional)

Alternatively, we could add a check in WorkspaceOverviewPage.tsx to only show the "Expense policy" option when both the beta flag is enabled AND policy.areRulesEnabled is true.

-{isBetaEnabled(CONST.BETAS.CUSTOM_RULES) ? (
+{isBetaEnabled(CONST.BETAS.CUSTOM_RULES) && policy?.areRulesEnabled ? (
     <Section
         isCentralPane
         title={translate('workspace.editor.policy')}
         ...
     >
         ...
     </Section>
 ) : null}

[paulnjs]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• The Expense Policy RHP (Right Hand Pane) auto-closes unexpectedly.

What is the root cause of that problem?

• An incorrect featureName is passed in

  App/src/pages/workspace/rules/RulesCustomPage.tsx

  Line 46 in 87e6d66

  featureName={CONST.POLICY.MORE_FEATURES.ARE_RULES_ENABLED}

  . The constant CONST.POLICY.MORE_FEATURES.ARE_RULES_ENABLED does not align with the actual feature flag for custom rules.

What changes do you think we should make in order to solve the problem?

• Remove the line at

  App/src/pages/workspace/rules/RulesCustomPage.tsx

  Line 46 in 87e6d66

  featureName={CONST.POLICY.MORE_FEATURES.ARE_RULES_ENABLED}

• Instead, consider passing shouldBeBlocked={!isBetaEnabled(CONST.BETAS.CUSTOM_RULES)}.

• However, this change alone does not fully resolve the issue. For example, if a user accesses /workspaces/{policyID}/overview/policy via a deep link, they still cannot open the Custom Rules page. This is due to incorrect screen mapping in this place.

• To fix this, move the mapping from

  App/src/libs/Navigation/linkingConfig/RELATIONS/WORKSPACE_TO_RHP.ts

  Line 280 in 87e6d66

  SCREENS.WORKSPACE.RULES_CUSTOM,

  to

  App/src/libs/Navigation/linkingConfig/RELATIONS/WORKSPACE_TO_RHP.ts

  Line 8 in 87e6d66

  [SCREENS.WORKSPACE.PROFILE]: [

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~022015818218082395144

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @QichenZhu (External)

[melvin-bot]

@QichenZhu Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[QichenZhu]

@daledah, thanks for the proposal. It resolves the main issue.

Regarding the deeplink issue the other proposal mentioned,

if a user accesses /workspaces/{policyID}/overview/policy via a deep link, they still cannot open the Custom Rules page.

I think it should be fixed according to the checklist item:

If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.

🎀👀🎀 C+ reviewed