Expense-Split by date for 30 days shows receipt briefly and disappears

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: V9.3.9-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #78429
Email or phone of affected tester (no customers): dreamnitethedragon+yydyd373@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Redminote 10S Android 13
App Component: Money Requests

Action Performed:

1. Launch app
2. Open workspace chat
3. Create an expense with receipt (camera image)
4. Open the expense
5. Tap more - split - date
6. Select ( 30 days period) as from and to dates
7. Tap save
8. Note expense list shows receipt briefly and disappears
9. Open a expense and note no receipt is shown
10. Navigate back to expense report page and note now receipt is shown

Expected Result:

Split by date for 30 days shows receipt must not shown briefly and disappears.Receipt must by shown without opening the expense.

Actual Result:

Split by date for 30 days shows receipt briefly and disappears. It reappears after opening the expense.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Bug7058911_1769477192160.Screenrecorder-2026-01-27-06-39-28-64.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @bernhardoj

[melvin-bot]

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @bernhardoj (External)

[annaweber830]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When an expense with a receipt is split by date across a large date range (e.g. 30 days), the receipt thumbnail briefly appears and then disappears from the expense list, and the split expenses can appear to have no receipt until the user opens an expense.

What is the root cause of that problem?

During the “split by date” save flow we create new split transactions in src/libs/actions/IOU/Split.ts via updateSplitTransactions(), but we do not pass the original transaction’s receipt (or its filename) into transactionParams, so the newly-created split transactions can be written to Onyx without receipt metadata.

App/src/libs/actions/IOU/Split.ts

Lines 1091 to 1122 in 87e6d66

	const requestMoneyInformation = {
	participantParams: {
	participant: participants.at(0) ?? ({} as Participant),
	payeeEmail: currentUserPersonalDetails?.login ?? '',
	payeeAccountID: currentUserPersonalDetails?.accountID ?? CONST.DEFAULT_NUMBER_ID,
	},
	policyParams: {
	policy,
	policyCategories,
	policyTags,
	},
	transactionParams: {
	amount: Math.abs(originalTransaction?.amount ?? 0),
	modifiedAmount: splitExpense.amount ?? 0,
	currency: originalTransactionDetails?.currency ?? CONST.CURRENCY.USD,
	created: splitExpense.created,
	merchant: splitExpense.merchant ?? '',
	comment: splitExpense.description,
	category: splitExpense.category,
	tag: splitExpense.tags?.[0],
	originalTransactionID,
	attendees: originalTransactionDetails?.attendees,
	source: CONST.IOU.TYPE.SPLIT,
	linkedTrackedExpenseReportAction: currentReportAction,
	pendingAction: splitTransaction ? null : CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD,
	pendingFields: splitTransaction ? splitTransaction.pendingFields : undefined,
	reimbursable: originalTransactionDetails?.reimbursable,
	taxCode: originalTransactionDetails?.taxCode,
	taxAmount: calculateIOUAmount(splitExpenses.length - 1, originalTransactionDetails?.taxAmount ?? 0, originalTransactionDetails?.currency ?? CONST.CURRENCY.USD, false),
	billable: originalTransactionDetails?.billable,
	},
	parentChatReport: getReportOrDraftReport(getReportOrDraftReport(expenseReport?.chatReportID)?.parentReportID),

This matters because the split transactions are created through getMoneyRequestInformation() (in src/libs/actions/IOU/index.ts), which calls buildOptimisticTransaction(); that helper only sets the receipt field when the provided receipt includes a source. If receipt is omitted, the optimistic transaction’s receipt becomes undefined, so the split transaction has no receipt state to render.

App/src/libs/TransactionUtils/index.ts

Lines 500 to 513 in 87e6d66

	return {
	...(!isEmptyObject(pendingFields) ? {pendingFields} : {}),
	transactionID,
	amount,
	currency,
	reportID,
	comment: commentJSON,
	merchant: merchant || (isManualTransaction ? CONST.TRANSACTION.DEFAULT_MERCHANT : CONST.TRANSACTION.PARTIAL_TRANSACTION_MERCHANT),
	created: created || DateUtils.getDBTime(),
	pendingAction,
	receipt: receipt?.source
	? {source: receipt.source, filename: receipt?.name ?? filename, state: receipt.state ?? CONST.IOU.RECEIPT_STATE.SCAN_READY, isTestDriveReceipt: receipt.isTestDriveReceipt}
	: undefined,
	hasEReceipt: existingTransaction?.hasEReceipt,

The receipt UI reads the linked transaction from the report action and decides whether to show a receipt based on the transaction’s receipt data. When the newly created split transaction lacks receipt, the receipt view/thumbnail will not render it.

App/src/components/ReportActionItem/MoneyRequestReceiptView.tsx

Lines 113 to 127 in 87e6d66

	const linkedTransactionID = useMemo(() => {
	if (!parentReportAction) {
	return undefined;
	}
	const originalMessage = parentReportAction && isMoneyRequestAction(parentReportAction) ? getOriginalMessage(parentReportAction) : undefined;
	return originalMessage?.IOUTransactionID;
	}, [parentReportAction]);
	const [transaction] = useOnyx(`${ONYXKEYS.COLLECTION.TRANSACTION}${getNonEmptyStringOnyxID(linkedTransactionID)}`, {canBeMissing: true});
	const [policy] = useOnyx(`${ONYXKEYS.COLLECTION.POLICY}${moneyRequestReport?.policyID}`, {canBeMissing: true});
	const transactionViolations = useTransactionViolations(transaction?.transactionID);
	const isDistanceRequest = isDistanceRequestTransactionUtils(transaction);
	const hasReceipt = hasReceiptTransactionUtils(updatedTransaction ?? transaction);
	const isTransactionScanning = isScanning(updatedTransaction ?? transaction);

Once the split is saved, the UI is no longer rendering the original transaction as the primary entry, so the user can see the original receipt briefly and then lose it when the split transactions replace it (because they don’t have receipt data yet), until navigating into an expense triggers state updates that rehydrate the receipt.

What changes do you think we should make in order to solve the problem?

Ensure we explicitly carry the original transaction’s receipt info onto each newly created split transaction during updateSplitTransactions() by passing receipt and filename into transactionParams for getMoneyRequestInformation().

App/src/libs/actions/IOU/Split.ts

Lines 1091 to 1122 in 87e6d66

	const requestMoneyInformation = {
	participantParams: {
	participant: participants.at(0) ?? ({} as Participant),
	payeeEmail: currentUserPersonalDetails?.login ?? '',
	payeeAccountID: currentUserPersonalDetails?.accountID ?? CONST.DEFAULT_NUMBER_ID,
	},
	policyParams: {
	policy,
	policyCategories,
	policyTags,
	},
	transactionParams: {
	amount: Math.abs(originalTransaction?.amount ?? 0),
	modifiedAmount: splitExpense.amount ?? 0,
	currency: originalTransactionDetails?.currency ?? CONST.CURRENCY.USD,
	created: splitExpense.created,
	merchant: splitExpense.merchant ?? '',
	comment: splitExpense.description,
	category: splitExpense.category,
	tag: splitExpense.tags?.[0],
	originalTransactionID,
	attendees: originalTransactionDetails?.attendees,
	source: CONST.IOU.TYPE.SPLIT,
	linkedTrackedExpenseReportAction: currentReportAction,
	pendingAction: splitTransaction ? null : CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD,
	pendingFields: splitTransaction ? splitTransaction.pendingFields : undefined,
	reimbursable: originalTransactionDetails?.reimbursable,
	taxCode: originalTransactionDetails?.taxCode,
	taxAmount: calculateIOUAmount(splitExpenses.length - 1, originalTransactionDetails?.taxAmount ?? 0, originalTransactionDetails?.currency ?? CONST.CURRENCY.USD, false),
	billable: originalTransactionDetails?.billable,
	},
	parentChatReport: getReportOrDraftReport(getReportOrDraftReport(expenseReport?.chatReportID)?.parentReportID),

transactionParams: {
    amount: Math.abs(originalTransaction?.amount ?? 0),
    modifiedAmount: splitExpense.amount ?? 0,
    currency: originalTransactionDetails?.currency ?? CONST.CURRENCY.USD,
    created: splitExpense.created,
    merchant: splitExpense.merchant ?? '',
    comment: splitExpense.description,
    category: splitExpense.category,
    tag: splitExpense.tags?.[0],
    originalTransactionID,
    attendees: originalTransactionDetails?.attendees,
    source: CONST.IOU.TYPE.SPLIT,
    linkedTrackedExpenseReportAction: currentReportAction,
    pendingAction: splitTransaction ? null : CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD,
    pendingFields: splitTransaction ? splitTransaction.pendingFields : undefined,
    reimbursable: originalTransactionDetails?.reimbursable,
    taxCode: originalTransactionDetails?.taxCode,
    taxAmount: calculateIOUAmount(splitExpenses.length - 1, originalTransactionDetails?.taxAmount ?? 0, originalTransactionDetails?.currency ?? CONST.CURRENCY.USD, false),
    billable: originalTransactionDetails?.billable,
    receipt: originalTransaction?.receipt,
    filename: originalTransaction?.receipt?.filename,
},

This keeps the receipt present on the split transactions immediately after saving, so the receipt thumbnail and Money Request receipt view remain consistent without requiring a navigation “refresh”.

What alternative solutions did you explore? (Optional)

[bernhardoj]

I can't reproduce this anymore. Might be a temporary BE issue. Can we ask QA to retest?

@RachCHopkins

[melvin-bot]

@bernhardoj 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[bernhardoj]

@RachCHopkins bump