[Due for Payment 2026-03-17] [$250] Thread - Thread header doesn´t match details page when creating thread with system message

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.16.0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #81086
Email or phone of affected tester (no customers): ibellicotest+2250@gmail.com
Issue reported by: Applause Internal Team
Bug source: Pull Request QA execution
Device used: Motorola MotoG60 / Android 12 (Hybrid app) - Windows 11 / Chrome
App Component: Other

Action Performed:

Prerequisite: Account has at least one workspace.

1. Open the Expensify app.
2. Open any workspace chat.
3. Create a manual expense.
4. Open the just created expense.
5. Hold and unhold the expense.
6. Long tap on the "Held this expense" message and select "Reply in thread"
7. Note that thread header shows "Held this expense"
8. Tap on header to navigate to details page.
9. Note that details page header shows "Held this money request" message,

Expected Result:

Thread header and details page header should be the same when creating a thread with a system-generated message.

Actual Result:

Thread header and details page header shows different message when creating a thread with a system-generated message of a held expense.
Thread header shows a "Held this expense" message while details page header shows a "Held this money request" message.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Bug7073633_1770732375231.Thr_1.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @nkuoch

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022021249041301512388
• Upwork Job ID: 2021249041301512388
• Last Price Increase: 2026-02-10

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ZhenjaHorbach (External)

[melvin-bot]

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~022021249041301512388

[annaweber830]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When a thread is created from the HOLD/UNHOLD system message on an expense, the thread screen header and the details page header show different text. The thread header uses the newer expense wording ("held this expense"), while the details page header falls back to older money-request wording.

What is the root cause of that problem?

App/src/libs/ReportNameUtils.ts

Lines 372 to 391 in aa5d2da

	function computeReportNameBasedOnReportAction(
	translate: LocalizedTranslate,
	parentReportAction: ReportAction | undefined,
	report: Report | undefined,
	reportPolicy: Policy | undefined,
	parentReport: Report | undefined,
	): string | undefined {
	if (!parentReportAction) {
	return undefined;
	}
	if (
	isActionOfType(parentReportAction, CONST.REPORT.ACTIONS.TYPE.SUBMITTED) ||
	isActionOfType(parentReportAction, CONST.REPORT.ACTIONS.TYPE.SUBMITTED_AND_CLOSED) ||
	isMarkAsClosedAction(parentReportAction)
	) {
	const harvesting = !isMarkAsClosedAction(parentReportAction) ? (getOriginalMessage(parentReportAction)?.harvesting ?? false) : false;
	if (harvesting) {
	return translate('iou.automaticallySubmitted');
	}
	return translate('iou.submitted', {memo: getOriginalMessage(parentReportAction)?.message});

The report-title computation for thread/details screens (computeReportNameBasedOnReportAction) handles many system actions but does not handle HOLD or UNHOLD. Because those actions are not mapped, name generation falls through to computeChatThreadReportName, which uses raw report-action text (getReportActionText) instead of the standardized expense-specific translation, causing the mismatch.

App/src/libs/ReportNameUtils.ts

Lines 673 to 675 in aa5d2da

	const isAttachment = isReportActionAttachment(!isEmptyObject(parentReportAction) ? parentReportAction : undefined);
	const reportActionMessage = getReportActionText(parentReportAction).replaceAll(/(\n+|\r\n|\n|\r)/gm, ' ');
	if (isAttachment && reportActionMessage) {

function computeReportNameBasedOnReportAction(
    translate: LocalizedTranslate,
    parentReportAction: ReportAction | undefined,
    report: Report | undefined,
    reportPolicy: Policy | undefined,
    parentReport: Report | undefined,
): string | undefined {
    if (!parentReportAction) {
        return undefined;
    }
    if (
        isActionOfType(parentReportAction, CONST.REPORT.ACTIONS.TYPE.SUBMITTED) ||
        isActionOfType(parentReportAction, CONST.REPORT.ACTIONS.TYPE.SUBMITTED_AND_CLOSED) ||
        isMarkAsClosedAction(parentReportAction)
    ) {
        // ...
    }

    // ... no HOLD/UNHOLD handling ...
}

const reportActionMessage = getReportActionText(parentReportAction).replaceAll(/(\n+|\r\n|\n|\r)/gm, ' ');

What changes do you think we should make in order to solve the problem?

Add explicit HOLD/UNHOLD handling in computeReportNameBasedOnReportAction so details-page/thread title generation uses the same translation keys as the thread UI path.

App/src/libs/ReportNameUtils.ts

Lines 401 to 409 in aa5d2da

	if (parentReportAction?.actionName === CONST.REPORT.ACTIONS.TYPE.REJECTED) {
	return translate('iou.rejectedThisReport');
	}
	if (parentReportAction?.actionName === CONST.REPORT.ACTIONS.TYPE.RETRACTED) {
	return translate('iou.retracted');
	}
	if (parentReportAction?.actionName === CONST.REPORT.ACTIONS.TYPE.REOPENED) {
	return translate('iou.reopened');
	}

Current code:

if (parentReportAction?.actionName === CONST.REPORT.ACTIONS.TYPE.REJECTED) {
    return translate('iou.rejectedThisReport');
}
if (parentReportAction?.actionName === CONST.REPORT.ACTIONS.TYPE.RETRACTED) {
    return translate('iou.retracted');
}
if (parentReportAction?.actionName === CONST.REPORT.ACTIONS.TYPE.REOPENED) {
    return translate('iou.reopened');
}

Updated code:

if (parentReportAction?.actionName === CONST.REPORT.ACTIONS.TYPE.REJECTED) {
    return translate('iou.rejectedThisReport');
}
if (parentReportAction?.actionName === CONST.REPORT.ACTIONS.TYPE.RETRACTED) {
    return translate('iou.retracted');
}
if (parentReportAction?.actionName === CONST.REPORT.ACTIONS.TYPE.REOPENED) {
    return translate('iou.reopened');
}
if (parentReportAction?.actionName === CONST.REPORT.ACTIONS.TYPE.HOLD) {
    return translate('iou.heldExpense');
}
if (parentReportAction?.actionName === CONST.REPORT.ACTIONS.TYPE.UNHOLD) {
    return translate('iou.unheldExpense');
}

This keeps title generation consistent anywhere report names are derived from parent actions and avoids leaking backend/legacy wording into the details page.

What alternative solutions did you explore? (Optional)

An alternative is normalizing HOLD/UNHOLD text in computeChatThreadReportName right before returning reportActionMessage, but that only fixes one fallback path. Adding the mapping in computeReportNameBasedOnReportAction is cleaner and aligns with how other action-specific titles are already centralized.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Actual Result:
Thread header and details page header shows different message when creating a thread with a system-generated message of a held expense.
Thread header shows a "Held this expense" message while details page header shows a "Held this money request" message.

What is the root cause of that problem?

The root cause is that ReportDetailsPage.tsx and HeaderView.tsx use different functions to get the report name for thread reports:

1. HeaderView.tsx (thread header) uses getReportName() from ReportUtils.ts which dynamically computes the thread name. For HOLD actions, it calls translate('iou.heldExpense') via getReportActionMessage():

   • App/src/libs/ReportUtils.ts

     Lines 5637 to 5638 in 013badf

     	if (reportAction.actionName === CONST.REPORT.ACTIONS.TYPE.HOLD) {
     	return translate('iou.heldExpense');

   • App/src/pages/inbox/HeaderView.tsx

     Line 155 in 013badf

     const title = getReportName(reportHeaderData, policy, parentReportAction, personalDetails, invoiceReceiverPolicy, undefined, undefined, isReportHeaderDataArchived);

2. ReportDetailsPage.tsx (details page) uses getReportName() from ReportNameUtils.ts which simply returns the stored report.reportName field directly without dynamic translation:

   • App/src/libs/ReportNameUtils.ts

     Lines 835 to 841 in 013badf

     	function getReportName(report?: Report, reportAttributesDerivedValue?: ReportAttributesDerivedValue['reports']): string {
     	if (!report || !report.reportID) {
     	return '';
     	}
     	return reportAttributesDerivedValue?.[report.reportID]?.reportName ?? report.reportName ?? '';
     	}

   • App/src/pages/ReportDetailsPage.tsx

     Line 55 in 013badf

     import {getReportName as getReportNameFromReportNameUtils} from '@libs/ReportNameUtils';

   • App/src/pages/ReportDetailsPage.tsx

     Line 357 in 013badf

     const rawReportName = getReportNameFromReportNameUtils(reportForHeader, reportAttributes);

When a thread is created from a HOLD action, the report.reportName is set from the action's message text. If this stored value differs from the dynamically translated value, the two pages show different messages.

What changes do you think we should make in order to solve the problem?

We should update ReportDetailsPage.tsx to use the same dynamic report name computation as HeaderView.tsx for consistency.

In src/pages/ReportDetailsPage.tsx:

- import {getReportName as getReportNameFromReportNameUtils} from '@libs/ReportNameUtils';
+ import {getReportName as getReportNameFromReportUtils} from '@libs/ReportUtils';

And update the usage:

- const rawReportName = getReportNameFromReportNameUtils(reportForHeader, reportAttributes);
+ const rawReportName = getReportNameFromReportUtils(reportForHeader, policy, parentReportAction, personalDetails);

This ensures both HeaderView.tsx and ReportDetailsPage.tsx use the same dynamic computation for the report name, producing consistent results for threads created from system-generated messages like HOLD actions.

What alternative solutions did you explore? (Optional)

N/A

[samranahm]

🚨 Edited by proposal-police: This proposal was edited at 2026-02-10 16:49:08 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Thread - Thread header doesn´t match details page when creating thread with system message

What is the root cause of that problem?

The report details page title comes from ReportNameUtils’ derived report name computeReportNameBasedOnReportAction, which did not handle HOLD/UNHOLD. The thread header (headerView) uses ReportUtils’ getReportActionMessage, which does. So these two page used different logic and showed different text.### What changes do you think we should make in order to solve the problem?

Since the getReportName form ReportUtils is depreciated, We should add

if (parentReportAction?.actionName === CONST.REPORT.ACTIONS.TYPE.HOLD) {
    return translate('iou.heldExpense');
}
if (parentReportAction?.actionName === CONST.REPORT.ACTIONS.TYPE.UNHOLD) {
    return translate('iou.unheldExpense');
}

in computeReportNameBasedOnReportAction to keep using getReportNameFromReportNameUtils

here

App/src/libs/ReportNameUtils.ts

Lines 372 to 381 in 431fce2

	function computeReportNameBasedOnReportAction(
	translate: LocalizedTranslate,
	parentReportAction: ReportAction | undefined,
	report: Report | undefined,
	reportPolicy: Policy | undefined,
	parentReport: Report | undefined,
	): string | undefined {
	if (!parentReportAction) {
	return undefined;
	}

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.