Merchant field is displayed instead of Distance & Rate field after splitting distance with user

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.17-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #81014
Email or phone of affected tester (no customers): sjoidnjsidjnosnjisjio@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.2 / Chrome
App Component: Money Requests

Action Performed:

1. Go to staging.new.expensify.com
2. Go to 1:1 DM with any user.
3. Click + > Split expense > Distance.
4. Split a distance expense with the user.
5. Open the distance expense.

Expected Result:

Distance and Rate field will be displayed.

Actual Result:

Merchant field is displayed instead of Distance & Rate field after splitting distance with user.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @twisterdotcom

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #81014

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[OSBotify]

🔍 Investigation Summary

Classification: Frontend bug
Causing PR: #81014 - "fix: Map is missing green line when splitting distance expense, confirm page is empty" by @nkdengineer (High confidence)
Related Issues: #80714

Recommendation: REVERT

PR #81014 fixed one issue (missing green line on map for split distance expenses) but introduced a regression in the display logic. The PR modified useFetchRoute to fetch routes for split distance expenses but did not update the corresponding display logic in MoneyRequestView.tsx.

Labels: No label changes needed - keeping DeployBlockerCash as this is a frontend bug in the App repository.

📋 Detailed Analysis

Evidence

PR #81014 modified /home/runner/_work/App/App/src/hooks/useFetchRoute.ts to add:

const isMapDistanceRequest = isMapDistanceRequestTransactionUtils(transaction) || isDistanceTypeRequest(transaction);

This change correctly identifies split distance expenses and fetches their routes. However, the display logic in /home/runner/_work/App/App/src/components/ReportActionItem/MoneyRequestView.tsx at line 892 was not updated accordingly.

Verification

The MoneyRequestView component decides whether to show distance fields (Distance & Rate) or merchant field based on this condition at line 892:

isManualDistanceRequest || isGPSDistanceRequest || isOdometerDistanceRequest || (isMapDistanceRequest && transaction?.comment?.waypoints)

For split distance expenses:

1. isMapDistanceRequest(transaction) returns true (because it has hasDistanceCustomUnit)
2. BUT transaction?.comment?.waypoints is undefined/empty initially for split expenses
3. Therefore (isMapDistanceRequest && transaction?.comment?.waypoints) evaluates to false
4. All other conditions (isManualDistanceRequest, isGPSDistanceRequest, isOdometerDistanceRequest) also return false
5. So the component falls through to displaying the merchant field instead of distance fields

Root Cause

The PR fixed the route fetching logic by using isDistanceTypeRequest(transaction) which returns true for any transaction with hasDistanceCustomUnit, but the display logic still requires transaction?.comment?.waypoints to be present for map distance requests. This creates an inconsistency where:

• Route fetching works correctly (fetches route for split distance expenses)
• Display logic fails (shows merchant field instead of distance/rate fields)

The fix should either:

1. Update MoneyRequestView.tsx line 892 to use similar logic as useFetchRoute (add || isDistanceTypeRequest(transaction))
2. Or update the condition to check for isDistanceRequest more broadly without requiring waypoints