Expense - Remaining split amounts show 0.00 after deleting one of the splits

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.17-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #79099
Email or phone of affected tester (no customers): osidjosdnjodsjosdj@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.2 / Chrome
App Component: Money Requests

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Create a manual expense.
4. Click More > Split.
5. Click Add split.
6. Click Make splits even.
7. Click Save.
8. Select one of the splits via checkbox.
9. Click dropdown button > Delete.
10. Delete the split.

Expected Result:

The remaining split amounts will not show 0.00.

Actual Result:

The remaining split amounts show 0.00 after deleting one of the splits.

The same issue also happens when user adds a new spilt to existing splits.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

1.mp4

View all open jobs on GitHub

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #79099

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[melvin-bot]

Triggered auto assignment to @lydiabarclay (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[OSBotify]

🔍 Investigation Summary

Classification: Frontend bug
Causing PR: #79099 - "Handle the Distance and Rate fields for splits" by @ZhenjaHorbach (High confidence)
Related Issues: None

Recommendation: REVERT

The PR #79099 added distance and rate field handling for split expenses, but introduced a critical bug where deleting a split causes the remaining split amounts to show $0.00. The logic to recalculate split amounts after deletion was not implemented.

Labels: Keeping DeployBlockerCash (App deploy is blocked). This is a frontend bug that requires an App PR fix.

📋 Detailed Analysis

Evidence

PR #79099 was identified by melvin-bot as the causing PR, and my investigation confirms this. The PR introduced complex logic for handling distance transactions in split expenses, including:

• Calculating split amounts based on distance and rate
• Updating merchants for distance splits
• Handling customUnit data for each split

Verification

The bug occurs in the split expense deletion flow:

File: /home/runner/_work/App/App/src/pages/iou/SplitExpenseEditPage.tsx
Line 338: When the "Delete" button is pressed, only removeSplitExpenseField() is called:

removeSplitExpenseField(draftTransactionWithSplitExpenses, splitExpenseTransactionID);

File: /home/runner/_work/App/App/src/libs/actions/IOU/Split.ts
Lines 2213-2229: The removeSplitExpenseField function only filters out the deleted split:

function removeSplitExpenseField(draftTransaction, splitExpenseTransactionID) {
    const splitExpenses = draftTransaction.comment?.splitExpenses?.filter(
        (item) => item.transactionID !== splitExpenseTransactionID
    );
    
    Onyx.merge(`${ONYXKEYS.COLLECTION.SPLIT_TRANSACTION_DRAFT}${originalTransactionID}`, {
        comment: {
            splitExpenses,
            splitsStartDate: null,
            splitsEndDate: null,
        },
    });
}

Root Cause

The removeSplitExpenseField function does not call evenlyDistributeSplitExpenseAmounts() after removing a split. This is the function responsible for:

1. Recalculating split amounts based on the total
2. For distance transactions, recalculating the distance (quantity) for each split based on amount and rate
3. Updating the merchant text for distance splits

Comparison with working flows:

• Adding a split: Calls addSplitExpenseField() which properly sets customUnit and merchant for distance transactions
• Make splits even: Calls evenlyDistributeSplitExpenseAmounts(draftTransaction, transaction, currentPolicy) with all required parameters
• Deleting a split: Only calls removeSplitExpenseField() which just removes the item from the array

When the split is removed but amounts are not redistributed, the distance splits end up with:

• Zero or incorrect amounts
• Zero distance (customUnit.quantity = 0)
• Empty or "$0.00" merchant text

This explains why the remaining splits show "$0.00" after deletion.