Skip to content

[Due for payment 2026-03-04] Migrate UserSelectPopup.tsx from useOptionsList to useFilteredOptions #82182

@mountiny

Description

@mountiny

Problem

UserSelectPopup.tsx currently uses the useOptionsList hook from OptionListContextProvider, which causes unnecessary background recalculations on every personal details or reports change.

This is part of a larger effort to remove OptionListContextProvider entirely. See parent issue #82193 for full context.

Solution

Replace useOptionsList with useFilteredOptions following the pattern established in PR #74071 (NewChatPage migration).

Current usage:

  • Properties used: options only
  • Called with: no arguments
  • File: src/components/Search/FilterDropdowns/UserSelectPopup.tsx

How options are used:

  • options.reports and options.personalDetails are passed to getValidOptions() to build the user filter list
  • Output drives filterAndOrderOptions and list rendering
  • No loading/initialization checks are used (assumes options are always ready)

Migration steps:

  1. Replace import {useOptionsList} from '@components/OptionListContextProvider' with import useFilteredOptions from '@hooks/useFilteredOptions'
  2. Replace useOptionsList() call with useFilteredOptions({ enabled: true })
  3. Since only options is used, handle the null case (when isLoading is true) -- either show a loading state or default to empty arrays
  4. Update getValidOptions() call to use the new options shape

Complexity: Simple

Reference PR: #74071

Tests

  • Verify the User Select popup in search filter dropdowns works correctly
  • Verify user filtering and selection works
  • Verify no errors appear in the JS console
  • Test on all platforms (iOS, Android, Web, Desktop)

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionTaskWeeklyKSv2

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions