The error message doesn't disappear after checking the required checkboxes in Terms and fees page - reported by @adeel0202

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Navigate to Terms and fees page (Enter /settings/payments/enable-payments in the URL directly for testing purposes)
2. Click on Enable Payments button without checking both required checkboxes
3. When the error is displayed, check both the required checkboxes
4. Observe that the error message is still there

Expected Result:

The error message should disappear when the user checks both checkboxes

Actual Result:

The error message doesn't disappear after checking the checkboxes

Workaround:

unknown

Platform:

Where is this issue occurring?

• Web

Version Number: 1.1.40-2
Reproducible in staging?: Y
Reproducible in production?: need repro
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

checkbox.error.doesnt.go.mov

Expensify/Expensify Issue URL:
Issue reported by: @adeel0202
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1646672720972879

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @johncschuster (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[adeel0202]

Proposal (If considered external)

We can add a new method to set the error state to false if both checkboxes are checked. (maybe we can write a better name for the method)

checkError() {
        if (this.state.hasAcceptedDisclosure
            && this.state.hasAcceptedPrivacyPolicyAndWalletAgreement) {
            this.setState({error: false});
        }
    }

We can then call this method after the state has been changed in toggleDisclosure and togglePrivacyPolicy methods, like this

toggleDisclosure() {
        this.setState(prevState => ({hasAcceptedDisclosure: !prevState.hasAcceptedDisclosure}), () => this.checkError());
    }

and

togglePrivacyPolicy() {
        this.setState(prevState => ({
            hasAcceptedPrivacyPolicyAndWalletAgreement: !prevState.hasAcceptedPrivacyPolicyAndWalletAgreement,
        }), () => this.checkError());
    }

[melvin-bot]

Triggered auto assignment to @stitesExpensify (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[melvin-bot]

Triggered auto assignment to @MitchExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[stitesExpensify]

It is external, and your proposal looks good to me @adeel0202! Once @MitchExpensify has created the upwork job go ahead and apply to it :)

[MitchExpensify]

Upwork Job cc @adeel0202