Rules - Deleted personal rules are still applied to newly created expenses

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.3.22-1
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #82438
Email or phone of affected tester (no customers): applausetester+usggsga@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: Pull Request QA execution
Device used: iPhone 13 / iOS 18.7.1, Samsung Galaxy A52 / Android 14, Windows 11 / Chrome
App Component: Workspace Settings

Action Performed:

Preconditions:

1. Add a custom category "Software" in a workspace
2. enable rule in more feature of the workspace

Steps:

1. Create workspace rule for "Amazon" → Category: "Office Supplies"
2. Create personal rule for "Amazon" → Category: "Software"
3. Create workspace rule for "Amazon" → Category: "Travel" (newer, should lose)
4. Create an expense to the workspace with merchant: "Amazon"
5. Verify personal rule wins → Category: "Software"
6. Delete personal rule
7. Create another expense to the workspace with merchant: "Amazon"

Expected Result:

after step 7, oldest workspace rule wins → Category: "Office Supplies"

Actual Result:

after step 7, the deleted personal rules are still applied to newly created expenses → Category: "Software"

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

1.mp4

View all open jobs on GitHub

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #82438

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[melvin-bot]

Triggered auto assignment to @heyjennahay (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.