-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Open
Labels
InternalRequires API changes or must be handled by Expensify staffRequires API changes or must be handled by Expensify staffReviewingHas a PR in reviewHas a PR in reviewWeeklyKSv2KSv2
Description
Description
Current State:
- 6 routes across Security, Wallet, and Subscription settings
- These routes use
backToparameter for return navigation
Implementation:
- Replace
getRoute(..., backTo)withcreateDynamicRoute() - Add source screens to
entryScreensarray - Remove
backToparameter from route definitions - Test forward/back navigation
Scope
Routes (6):
| Route Constant | Path |
|---|---|
SETTINGS_MERGE_ACCOUNTS_RESULT |
settings/security/merge-accounts/:login/result/:result |
SETTINGS_DELEGATE_ROLE |
settings/security/delegate/:login/role/:role |
SETTINGS_ADD_BANK_ACCOUNT |
settings/wallet/add-bank-account |
SETTINGS_ADD_BANK_ACCOUNT_VERIFY_ACCOUNT |
settings/wallet/add-bank-account/verify-account |
SETTINGS_SUBSCRIPTION |
settings/subscription |
SETTINGS_SUBSCRIPTION_DOWNGRADE_BLOCKED |
settings/subscription/downgrade-blocked |
Usages
SETTINGS_MERGE_ACCOUNTS_RESULT:
src/pages/settings/Security/SecuritySettingsPage.tsx:158src/pages/settings/Security/MergeAccounts/AccountValidatePage.tsx:117,126,139src/pages/settings/Security/MergeAccounts/AccountDetailsPage.tsx:106,122
SETTINGS_DELEGATE_ROLE:
src/pages/settings/Security/SecuritySettingsPage.tsx:233src/pages/settings/Security/AddDelegate/ConfirmDelegatePage.tsx:53,75src/pages/settings/Security/AddDelegate/AddDelegatePage.tsx:47
SETTINGS_ADD_BANK_ACCOUNT:
src/libs/actions/BankAccounts.ts:126src/pages/workspace/invoices/WorkspaceInvoicesVerifyAccountPage.tsx:14
SETTINGS_ADD_BANK_ACCOUNT_VERIFY_ACCOUNT:
- Search for usages in bank account flow
SETTINGS_SUBSCRIPTION:
src/pages/workspace/upgrade/GenericFeaturesView.tsx:32src/pages/workspace/WorkspaceOverviewPlanTypePage.tsx:121src/pages/settings/Subscription/FreeTrial.tsx:54src/pages/settings/Subscription/CardSection/BillingBanner/EarlyDiscountBanner.tsx:90src/pages/RestrictedAction/Workspace/WorkspaceOwnerRestrictedAction/index.native.tsx:26src/pages/workspace/upgrade/UpgradeIntro.tsx:75src/pages/workspace/upgrade/UpgradeConfirmation.tsx:31
SETTINGS_SUBSCRIPTION_DOWNGRADE_BLOCKED:
src/pages/settings/Subscription/SubscriptionPlan/SubscriptionPlanCardActionButton.tsx:70
Files to modify:
src/ROUTES.ts- Update route definitionssrc/libs/Navigation/types.ts- RemovebackTofrom params- Components listed above
Issue Owner
Current Issue Owner: @huultReactions are currently unavailable
Metadata
Metadata
Assignees
Labels
InternalRequires API changes or must be handled by Expensify staffRequires API changes or must be handled by Expensify staffReviewingHas a PR in reviewHas a PR in reviewWeeklyKSv2KSv2