Skip to content

[BT-152] Migrate Settings - Security/Wallet/Subscription #83363

@mjasikowski

Description

@mjasikowski

Description

Current State:

  • 6 routes across Security, Wallet, and Subscription settings
  • These routes use backTo parameter for return navigation

Implementation:

  • Replace getRoute(..., backTo) with createDynamicRoute()
  • Add source screens to entryScreens array
  • Remove backTo parameter from route definitions
  • Test forward/back navigation

Scope

Routes (6):

Route Constant Path
SETTINGS_MERGE_ACCOUNTS_RESULT settings/security/merge-accounts/:login/result/:result
SETTINGS_DELEGATE_ROLE settings/security/delegate/:login/role/:role
SETTINGS_ADD_BANK_ACCOUNT settings/wallet/add-bank-account
SETTINGS_ADD_BANK_ACCOUNT_VERIFY_ACCOUNT settings/wallet/add-bank-account/verify-account
SETTINGS_SUBSCRIPTION settings/subscription
SETTINGS_SUBSCRIPTION_DOWNGRADE_BLOCKED settings/subscription/downgrade-blocked

Usages

SETTINGS_MERGE_ACCOUNTS_RESULT:

  • src/pages/settings/Security/SecuritySettingsPage.tsx:158
  • src/pages/settings/Security/MergeAccounts/AccountValidatePage.tsx:117,126,139
  • src/pages/settings/Security/MergeAccounts/AccountDetailsPage.tsx:106,122

SETTINGS_DELEGATE_ROLE:

  • src/pages/settings/Security/SecuritySettingsPage.tsx:233
  • src/pages/settings/Security/AddDelegate/ConfirmDelegatePage.tsx:53,75
  • src/pages/settings/Security/AddDelegate/AddDelegatePage.tsx:47

SETTINGS_ADD_BANK_ACCOUNT:

  • src/libs/actions/BankAccounts.ts:126
  • src/pages/workspace/invoices/WorkspaceInvoicesVerifyAccountPage.tsx:14

SETTINGS_ADD_BANK_ACCOUNT_VERIFY_ACCOUNT:

  • Search for usages in bank account flow

SETTINGS_SUBSCRIPTION:

  • src/pages/workspace/upgrade/GenericFeaturesView.tsx:32
  • src/pages/workspace/WorkspaceOverviewPlanTypePage.tsx:121
  • src/pages/settings/Subscription/FreeTrial.tsx:54
  • src/pages/settings/Subscription/CardSection/BillingBanner/EarlyDiscountBanner.tsx:90
  • src/pages/RestrictedAction/Workspace/WorkspaceOwnerRestrictedAction/index.native.tsx:26
  • src/pages/workspace/upgrade/UpgradeIntro.tsx:75
  • src/pages/workspace/upgrade/UpgradeConfirmation.tsx:31

SETTINGS_SUBSCRIPTION_DOWNGRADE_BLOCKED:

  • src/pages/settings/Subscription/SubscriptionPlan/SubscriptionPlanCardActionButton.tsx:70

Files to modify:

  • src/ROUTES.ts - Update route definitions
  • src/libs/Navigation/types.ts - Remove backTo from params
  • Components listed above
Issue OwnerCurrent Issue Owner: @huult

Metadata

Metadata

Labels

InternalRequires API changes or must be handled by Expensify staffReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions