-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Open
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionAuto-added when associated PR is deployed to productionInternalRequires API changes or must be handled by Expensify staffRequires API changes or must be handled by Expensify staffWeeklyKSv2KSv2
Description
Description
Current State:
- 5 report settings routes use
backToparameter - These handle report name, notifications, and visibility settings
Implementation:
- Replace
getRoute(..., backTo)withcreateDynamicRoute() - Add source screens to
entryScreensarray - Remove
backToparameter from route definitions - Test forward/back navigation
Scope
Routes (5):
| Route Constant | Path |
|---|---|
REPORT_SETTINGS_NAME |
r/:reportID/settings/name |
REPORT_SETTINGS_NOTIFICATION_PREFERENCES |
r/:reportID/settings/notification-preferences |
REPORT_SETTINGS_WRITE_CAPABILITY |
r/:reportID/settings/who-can-post |
REPORT_SETTINGS_VISIBILITY |
r/:reportID/settings/visibility |
REPORT_CHANGE_APPROVER |
r/:reportID/change-approver |
Usages
REPORT_SETTINGS_NAME:
src/pages/ReportDetailsPage.tsx:792
REPORT_SETTINGS_NOTIFICATION_PREFERENCES:
- Search for usages in report notification settings
REPORT_SETTINGS_WRITE_CAPABILITY:
- Search for usages in report write settings
REPORT_SETTINGS_VISIBILITY:
src/pages/settings/Report/ReportSettingsPage.tsx:106
REPORT_CHANGE_APPROVER:
src/pages/ReportAddApproverPage.tsx:131src/components/MoneyReportHeader.tsx:1344
Files to modify:
src/ROUTES.ts- Update route definitionssrc/libs/Navigation/types.ts- RemovebackTofrom params- Components listed above
Issue Owner
Current Issue Owner: @huultReactions are currently unavailable
Metadata
Metadata
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionAuto-added when associated PR is deployed to productionInternalRequires API changes or must be handled by Expensify staffRequires API changes or must be handled by Expensify staffWeeklyKSv2KSv2