Expenses - Second level tag is shown when the first level tag is not selected

[vincdargento]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.34-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #82948
Email or phone of affected tester (no customers): sjodijsnodijdnoijsido@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.2 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

• Workspace has dependent tags.

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Create two expenses with tags.
4. Open the report.
5. Bulk select both expenses.
6. Click dropdown button > Edit multiple.

Expected Result:

Second level tag (Region) should only appear when the first level tag (State) is selected.

Actual Result:

Second level tag (Region) appears when the first level tag (State) is not selected.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

View all open jobs on GitHub

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #82948

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[OSBotify]

🔍 Investigation Summary

Classification: Frontend bug
Causing PR: #82948 - "Reapply "Feat: bulk edit multiple"" by @pasyukevich (High confidence)
Related Issues: None

Recommendation: REVERT

This is a clear regression in the newly added bulk edit feature. The PR was just merged and is causing incorrect UI behavior with dependent tags. A revert is the safest path to unblock the deploy while the fix is developed.

Labels: Keeping DeployBlockerCash (App deploy blocker - frontend bug). No label changes needed.

📋 Detailed Analysis

Evidence

PR #82948 implements the bulk edit multiple expenses feature. The issue specifically mentions that the bug occurs when using "Edit multiple" on expenses with dependent tags, which is exactly what this PR added.

The bot automatically assigned the PR author (@pasyukevich) confirming this is the causing PR. The bug is reproducible on staging (9.3.34-0) which includes this PR, and does not exist in production where this feature is not available.

Verification

The affected code is in src/pages/Search/SearchEditMultiple/SearchEditMultiplePage.tsx (added by PR #82948).

Lines 150-151:

const dependentTagSource = draftTransaction?.tag === undefined ? commonDependentTag : draftTransaction?.tag;
const tagsArray = getTagArrayFromName(draftTransaction?.tag ?? );

Line 161:

shouldShow = shouldShowDependentTagList(tagListIndex, dependentTagSource, tagList.tags);

The file was created by this PR as part of the bulk edit feature implementation.

Root Cause

When a user opens "Edit multiple" for expenses with dependent tags:

1. Initially, draftTransaction.tag is undefined (no tags selected in the draft yet)
2. The code falls back to commonDependentTag which contains the common parent tag from the originally selected expenses
3. This dependentTagSource is used to determine if the second level tag should be visible
4. Since dependentTagSource has a value (from the original transactions), shouldShowDependentTagList returns true for the second level tag
5. Result: The second level tag (Region) appears even though the first level tag (State) has not been selected in the current draft

The bug: The code uses the original transactions tags to determine dependent tag visibility, instead of using the current draft transaction state. When editing, only the tags selected in the current draft should determine which dependent tag levels are visible.

Expected behavior: Second level tag should only appear after the first level tag is selected in the edit form.