Scan - Submit button appears when replace invalid scan receipt with other invalid receipt

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.3.34-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #84241
Email or phone of affected tester (no customers): gocemate+b21549011@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Windows 10/Chrome
App Component: Money Requests

Action Performed:

Precondition: The workspace enables the workflow and setting the default approver

1. Go to the workspace chat
2. Submit an invalid scan receipt
3. Wait until the SmartScan fails
4. Verify that the Submit button does not appear when SmartScan fails
5. Click on the receipt
6. Select Replace button and upload invalid receipt

Expected Result:

Submit button should not appear

Actual Result:

Submit button appears and unexpected error is displayed when click Submit

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

1.mp4

View all open jobs on GitHub

[raju-h]

Contributor details
Your Expensify account email: rajuhosseng@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01c9f56cebd089cf23

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[raju-h]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After replacing a receipt on a transaction that had a SmartScan failure, the Submit button becomes enabled immediately instead of waiting for the new receipt to be scanned. The user can submit the report with unscanned/incomplete data.

What is the root cause of that problem?

In src/libs/actions/IOU/index.ts, the replaceReceipt function (line 12376) defaults receipt.state to CONST.IOU.RECEIPT_STATE.OPEN when no state parameter is passed:

state: state ?? CONST.IOU.RECEIPT_STATE.OPEN

The callers in IOURequestStepScan (both index.tsx line 95 and index.native.tsx line 269) don't pass a state argument, so after replacing the receipt the state changes from SCAN_FAILED to OPEN.

This bypasses two guards that block submission in isSubmitAction() (ReportPrimaryActionUtils.ts):

1. hasSmartScanFailedWithMissingFields() checks receipt.state === SCAN_FAILED — now false because state is OPEN
2. isScanning() via isReceiptBeingScanned() checks for SCAN_READY/SCANNING — also false

As a result the Submit button appears even though the replacement receipt hasn't been scanned yet.

What changes do you think we should make in order to solve the problem?

Pass state: CONST.IOU.RECEIPT_STATE.SCAN_READY in the replaceReceipt calls from both IOURequestStepScan files:

• src/pages/iou/request/step/IOURequestStepScan/index.tsx (line 95)
• src/pages/iou/request/step/IOURequestStepScan/index.native.tsx (line 269)

This matches how initial receipt creation sets the state in MoneyRequest.ts (line 206), ensuring isScanning() blocks the Submit button until SmartScan completes or fails again with SCAN_FAILED.

What alternative solutions did you explore? (Optional)

Considered changing the default fallback inside replaceReceipt itself from OPEN to SCAN_READY, but that could affect other callers that intentionally omit the state parameter expecting OPEN behavior. Passing it explicitly from the scan step callers is the narrower, safer fix.

[yifan19860831-hub]

Hi! I'd like to work on this issue. Can I get assigned? 🙏

[melvin-bot]

📣 @yifan19860831-hub! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>