[Due for payment 2026-03-30] Perfromance: NOOP migrateOnyx scripts which are no longer required

[Julesssss]

Problem

The Onyx migration framework runs two migration scripts on every app startup that read from Onyx storage even when no migration is needed:

• RenameEmojiSkinTone: Reads PREFERRED_EMOJI_SKIN_TONE to check its type
• ConvertPolicyChatReportIDsToString: Reads the entire policy collection (waitForCollectionCallback: true) to check if any policy has numeric chatReportIDAdmins or chatReportIDAnnounce

These migrations are no longer needed — the backend now sends correct data for all users, and sufficient time has passed for existing client data to have been migrated. However, the read-then-check pattern still costs ~934ms at P90 on ManualAppStartup, primarily from loading the full policy collection.

Original discussion.

Solution

NOOP these functions to ovoid unnecessary policy iteration.

[wildan-m]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The ConvertPolicyChatReportIDsToString migration runs on every app startup and reads the entire policy collection via Onyx.connectWithoutView with waitForCollectionCallback: true, adding ~934ms at P90 to ManualAppStartup. This migration is no longer needed since the backend now sends chatReportIDAdmins and chatReportIDAnnounce as strings for all users.

Note: the RenameEmojiSkinTone migration mentioned in the issue has already been removed from the codebase.

What is the root cause of that problem?

The migration function in ConvertPolicyChatReportIDsToString.ts connects to the entire ONYXKEYS.COLLECTION.POLICY with waitForCollectionCallback: true, which forces loading all policies from storage before the migration can even determine there is nothing to migrate:

App/src/libs/migrations/ConvertPolicyChatReportIDsToString.ts

Lines 24 to 93 in 68a869e

	export default function () {
	return new Promise<void>((resolve) => {
	const connection = Onyx.connectWithoutView({
	key: ONYXKEYS.COLLECTION.POLICY,
	waitForCollectionCallback: true,
	callback: (policies: OnyxCollection<OldPolicy>) => {
	Onyx.disconnect(connection);
	if (!policies || isEmptyObject(policies)) {
	Log.info('[Migrate Onyx] Skipped migration ConvertPolicyChatReportIDsToString because there are no policies');
	return resolve();
	}
	// Find policies that have number type chatReportIDAdmins or chatReportIDAnnounce
	const policiesToMigrate = Object.entries(policies).filter(([, policy]) => {
	if (!policy) {
	return false;
	}
	const hasNumberAdminsReportID = typeof policy.chatReportIDAdmins === 'number';
	const hasNumberAnnounceReportID = typeof policy.chatReportIDAnnounce === 'number';
	return hasNumberAdminsReportID || hasNumberAnnounceReportID;
	});
	if (policiesToMigrate.length === 0) {
	Log.info('[Migrate Onyx] Skipped migration ConvertPolicyChatReportIDsToString because no policies have number type chatReportIDs');
	return resolve();
	}
	Log.info(`[Migrate Onyx] Running ConvertPolicyChatReportIDsToString migration for ${policiesToMigrate.length} policies`);
	const dataToSave = policiesToMigrate.reduce(
	(acc, [policyKey, policy]) => {
	if (!policy) {
	return acc;
	}
	const update: PolicyUpdate = {};
	if (typeof policy.chatReportIDAdmins === 'number') {
	update.chatReportIDAdmins = String(policy.chatReportIDAdmins);
	Log.info(
	`[Migrate Onyx] ConvertPolicyChatReportIDsToString: Converting chatReportIDAdmins from ${policy.chatReportIDAdmins} to "${update.chatReportIDAdmins}" for policy ${policyKey}`,
	);
	}
	if (typeof policy.chatReportIDAnnounce === 'number') {
	update.chatReportIDAnnounce = String(policy.chatReportIDAnnounce);
	Log.info(
	`[Migrate Onyx] ConvertPolicyChatReportIDsToString: Converting chatReportIDAnnounce from ${policy.chatReportIDAnnounce} to "${update.chatReportIDAnnounce}" for policy ${policyKey}`,
	);
	}
	acc[policyKey as PolicyKey] = update;
	return acc;
	},
	{} as Record<PolicyKey, PolicyUpdate>,
	);
	// eslint-disable-next-line rulesdir/prefer-actions-set-data
	Onyx.mergeCollection(ONYXKEYS.COLLECTION.POLICY, dataToSave).then(() => {
	Log.info(`[Migrate Onyx] Ran migration ConvertPolicyChatReportIDsToString and converted ${Object.keys(dataToSave).length} policies`);
	resolve();
	});
	},
	});
	});
	}

This is called on every startup from migrateOnyx.ts:

App/src/libs/migrateOnyx.ts

Line 18 in 68a869e

const migrationPromises = [ConvertPolicyChatReportIDsToString];

What changes do you think we should make in order to solve the problem?

Replace the body of ConvertPolicyChatReportIDsToString with an immediate Promise.resolve(), making it a no-op. The function signature and export are preserved so migrateOnyx.ts continues to work without changes — the migration array and reduce chain in migrateOnyx.ts will simply resolve instantly for this entry.

https://github.com/Expensify/App/compare/main...wildan-m:App:wildan/84787-noop-onyx-migrations?expand=1