Expense-Unexpected error in 1:1 chat when using pay expense.

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: V9.3.37-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-8761/folder/13177049/41237817/1247680445
Email or phone of affected tester (no customers): dreamnitethedragon+njgc@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Redminote 10S Android 13
App Component: Money Requests

Action Performed:

1. Launch app
2. Open 1:1 chat
3. Tap plus icon - pay
4. Enter an amount and tap next
5. Tap mark as paid
6. Open expense after few seconds

Expected Result:

Unexpected error must not be shown in 1:1 chat when using pay expense.

Actual Result:

Unexpected error in 1:1 chat when using pay expense.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Bug7101659_1773359353758.Screenrecorder-2026-03-13-05-10-00-730.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @blimpich (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[OSBotify]

🔍 Investigation Summary

Classification: Frontend bug
Causing PR: #83638 - "feat: Allow admins to pay with any business bank account they have access to" by @samranahm (High confidence)
Related Issues: #82853 (original feature request)

Recommendation: REVERT

PR #83638 introduced changes to allow admins to pay expense reports with any business bank account they have access to. However, the changes appear to have broken the "Mark as paid" functionality in 1:1 chats (IOU reports), causing unexpected errors when users attempt to pay expenses in peer-to-peer scenarios.

The PR is in the staging deploy checklist (#85146) and is reproducible only on staging, not production, which confirms it was introduced in this release cycle.

Labels: Keeping DeployBlockerCash (App deploy blocked - frontend bug requiring App PR revert). Removing DeployBlocker (not a backend issue).

📋 Detailed Analysis

Evidence

• Issue occurs when using "Mark as paid" in 1:1 chat on Android App (staging only)
• PR feat: Allow admins to pay with any business bank account they have access to #83638 merged on 2026-03-12 at 09:32:28Z and is listed in StagingDeployCash Deploy Checklist: New Expensify 2026-03-12 #85146
• PR modifies payment flow in SettlementButton, PaymentUtils, and IOU action handlers
• The PR adds methodID parameter handling for business bank account selection
• Issue is specific to 1:1 chats (IOU reports), not workspace expense reports

Verification

• PR feat: Allow admins to pay with any business bank account they have access to #83638 modifies the following key files related to payment:
  • src/components/SettlementButton/index.tsx - Payment button and option handling
  • src/libs/PaymentUtils.ts - Added getBusinessBankAccountOptions() function
  • src/libs/actions/IOU/index.ts - Modified payMoneyRequest() to accept methodID parameter
  • src/components/MoneyReportHeader.tsx - Payment flow in expense reports

Root Cause

PR #83638 was designed to enable admins to pay workspace expense reports with any business bank account. However, the changes to the payment flow affected 1:1 chat (IOU) payments.

Looking at src/components/SettlementButton/index.tsx line 478, for non-invoice reports, the code calls:

onPress({paymentType: iouPaymentType, payAsBusiness: false});

This doesn't properly handle the new business bank account selection flow with methodID parameter. The issue manifests when:

1. User opens a 1:1 chat
2. Creates an expense payment request
3. Attempts to "Mark as paid"
4. System encounters an error because the payment handling was modified to expect additional parameters for business bank account scenarios

The PR had known issues during review (see comments from @ikevin127 noting 3 blocker bugs including "The deposit and withdrawal accounts are the same" error), suggesting incomplete handling of edge cases.