[Due for payment 2026-03-24] Onboarding - Test Drive modal appears when selecting "Manage my team's..." option

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.3.37-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #83750
Email or phone of affected tester (no customers): n/a
Issue reported by: Applause Internal Team
Bug source: Pull Request QA execution
Device used: Mac 15.4.1 Safari/Chrome
App Component: Other

Action Performed:

1. Go to https://staging.new.expensify.com
   2.Login with new email address.
   3.Select "Manage my team's expenses" while onboarding

Expected Result:

The TestDrive modal does not appear after onboarding.
User lands on the Home page and the Concierge RHP should not be opened.

Actual Result:

The TestDrive modal appear after onboarding when selecting "Manage my team's expenses" option .
User lands on the Workspace Overview page and the Concierge RHP is opened.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Bug7101669_1773360133712.Recording__1784.mp4

View all open jobs on GitHub

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #83750

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[mitarachim]

Issue partially reproduce In Production.
TestDrive modal appear and User lands on the Home page and the Concierge RHP is opened.

Recording.1787.mp4

[OSBotify]

🔍 Investigation Summary

Classification: Frontend bug
Causing PR: #83750 - "Remove TestDrive from sign-up flow" by @abbasifaizan70 (High confidence)
Related Issues: None

Recommendation: ROLL FORWARD

PR #83750 incompletely removed the TestDrive modal flow. While it removed the TestDriveModalGuard and updated most onboarding pages, it missed the RHPVariantTest component that still navigates to the TestDrive modal for users in the RHP (Right Hand Panel) experiment.

A quick fix is needed to update /src/components/SidePanel/RHPVariantTest/index.ts line 51 to navigate to ROUTES.TEST_DRIVE_DEMO_ROOT instead of ROUTES.TEST_DRIVE_MODAL_ROOT.route. Rolling forward is preferable to reverting because:

1. The PR made extensive changes across many files
2. A simple one-line fix can resolve the issue
3. Reverting would bring back the entire TestDrive modal infrastructure that was intentionally removed

Labels: No label changes made (both DeployBlockerCash and DeployBlocker remain as this is a frontend bug reproducible only on staging)

📋 Detailed Analysis

Evidence

PR #83750 removed the TestDrive modal from the onboarding flow by:

• Deleting TestDriveModalGuard.ts (the navigation guard)
• Removing testDriveModalDismissed flag setting from onboarding completion
• Updating all onboarding pages to remove the shouldSkipTestDriveModal parameter
• Changing Tour.ts to always navigate to TEST_DRIVE_DEMO_ROOT

However, the PR did NOT update the RHPVariantTest component, which was introduced in PR #79122 (merged 2026-01-13). This component handles a special navigation flow for micro companies in an A/B test.

Verification

Affected file: /src/components/SidePanel/RHPVariantTest/index.ts

• Line 51 still calls: Navigation.navigate(ROUTES.TEST_DRIVE_MODAL_ROOT.route);
• This code executes when shouldOpenRHPVariant() returns true (line 56 of navigateAfterOnboarding.ts)
• The condition is true for micro companies with RHP variant enabled

The RHPVariantTest file was NOT modified by PR #83750, as confirmed by checking the PR file list.

Root Cause

When users select "Manage my team's expenses" during onboarding:

1. They are classified as micro company users (MANAGE_TEAM choice)
2. If they are in the RHP experiment, shouldOpenRHPVariant() returns true
3. handleRHPVariantNavigation() is called (line 57 of navigateAfterOnboarding.ts)
4. This function navigates to workspace overview, opens the side panel, AND navigates to the TestDrive modal (line 51)
5. Since the TestDriveModalGuard was removed, the modal appears unexpectedly

Proposed Fix

Update line 51 in /src/components/SidePanel/RHPVariantTest/index.ts:

// Change from:
Navigation.navigate(ROUTES.TEST_DRIVE_MODAL_ROOT.route);

// To:
Navigation.navigate(ROUTES.TEST_DRIVE_DEMO_ROOT);

Or alternatively, remove the entire navigation call on line 50-52 if opening the side panel is sufficient for the RHP variant.