When filtering in Domain page, blank space is shown if no users are found

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.3.37-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to validate in Prod - Provide reasoning.
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #81837
Email or phone of affected tester (no customers): applausetester+en@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: Pull Request QA execution
Device used: Macbook Pro 2023 / Sequoia 15.2
App Component: Workspace Settings

Action Performed:

Precondition :

• Have domain account with members in employee status only

1. Open staging.new.expensify.com
2. Sign in applausetester+en@applause.expensifail.com or any account with domain access
3. Go to a domain with members in employee status only
4. Filter for members only with select All members > manager (There should be no results)

Expected Result:

User expects there to be a message saying that there are no members as manager

Actual Result:

Blank white page is shown instead

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Bug7101671_1773360434812.Blank_page_is_shown.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @ZhenjaHorbach

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #81837

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[MelvinBot]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When filtering domain members by security group on the Domain Members page, if no members match the selected group, a blank white page is shown instead of a "no results found" message.

What is the root cause of that problem?

Three compounding issues prevent any empty-state feedback when the group filter produces zero results:

1. shouldShowListEmptyContent={false} is explicitly set in BaseDomainMembersPage.tsx (line 256). This tells BaseSelectionList (line 548) to skip its empty-content rendering when data.length === 0, so it renders an empty FlashList with zero items instead.

2. No listEmptyContent prop is passed. Even if shouldShowListEmptyContent were true, renderListEmptyContent() in BaseSelectionList (line 387) would return undefined because no content element was provided.

3. The SearchBar's empty-state message only triggers on text search, not on group filter results. SearchBar (line 48) requires inputValue.length !== 0 to show "No results found matching...". When the user only selects a group from the dropdown without typing, inputValue is empty, so the message is suppressed.

Additionally, the column headers ("Members", "Group") are hidden when filteredData is empty (line 188-193), contributing to the completely blank appearance.

Data flow: User selects a group → useDomainGroupFilter (line 62-70) creates a preFilter → useSearchResults (line 29) applies preFilter first (data.filter(preFilter)) → result is [] → SelectionListWithModal receives empty data with shouldShowListEmptyContent={false} → blank page.

What changes do you think we should make in order to solve the problem?

In BaseDomainMembersPage.tsx:

1. Change shouldShowListEmptyContent={false} to shouldShowListEmptyContent={true} (or conditionally true when a group filter is active).
2. Pass a listEmptyContent prop with an appropriate "No results found" message element, similar to how other pages in the codebase handle empty filtered lists.

This leverages the existing empty-state mechanism in BaseSelectionList which already supports this pattern through the listEmptyContent and shouldShowListEmptyContent props.

What alternative solutions did you explore? (Optional)

• Extending SearchBar's empty state: Modifying SearchBar to show "No results" even when inputValue is empty (when a preFilter is active). This was rejected because it would change SearchBar's behavior globally and the listEmptyContent prop on SelectionList is the more standard pattern used across the codebase.
• Adding a separate empty-state component in BaseDomainMembersPage outside the SelectionListWithModal. This was rejected as unnecessary since BaseSelectionList already has built-in empty-state support that just needs to be enabled.

---

Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.