[HOLD for payment 2022-05-20][$250] New room - Not able to create a new room, error message appears

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Log in to any expensifail account
2. Click on the green plus button in the bottom.
3. Choose new room
4. Enter room's name
5. Choose workspace
6. Click create room

Expected Result:

New room must be created when I click create room

Actual Result:

New room is not created and I see error message

Workaround:

unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.1.52-0

Reproducible in staging?: y

Reproducible in production?: y

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos:

https://user-images.githubusercontent.com/43996225/162206860-40cf5b13-0f65-476c-b274-047d6fe1060a.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause @thesahindia

Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1648760293684219

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @francoisl (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[francoisl]

Reproducible in production.
The API returns a 200 response for the CreatePolicyRoom call, so it's most likely a front-end issue interpreting the response.

[melvin-bot]

Triggered auto assignment to @jliexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[thesahindia]

I think that the backend must be sending the data in the form of an array earlier which was working just fine -

App/src/libs/actions/Report.js

Line 1526 in 0596be5

.then(([{reportID}]) => {

But now, you can see the logged response below (we're getting an object with key : report_SOME-ID)

I think we it should be fixed at the backend, but if for some reason we can't then I propose this fix -
We can make a variable for reportID and we just need to set the value after line 1523 (or we can just extract the key from the Object & use it)

App/src/libs/actions/Report.js

Lines 1518 to 1525 in 0596be5

	return API.CreatePolicyRoom({policyID, reportName, visibility})
	.then((response) => {
	if (response.jsonCode !== 200) {
	Growl.error(response.message);
	return;
	}
	return fetchChatReportsByIDs([response.reportID]);
	})

 Onyx.set(ONYXKEYS.IS_LOADING_CREATE_POLICY_ROOM, true);
+    let reportID;
    return API.CreatePolicyRoom({policyID, reportName, visibility})
        .then((response) => {
            if (response.jsonCode !== 200) {
                Growl.error(response.message);
                return;
            }
+            reportID = response.reportID;
            return fetchChatReportsByIDs([response.reportID]);
        })
        .then(() => {
            if (!reportID) {
                Log.error('Unable to grab policy room after creation', reportID);
                return;
            }

[jliexpensify]

Posted!

Internal - https://www.upwork.com/ab/applicants/1513707338062458880/job-details
External - https://www.upwork.com/jobs/~0149d3c7692c4cf31b

Invited @thesahindia as the bug reporter