Track - Please remove duplicate waypoints does not appear when move waypoint via keyboard

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.3.39-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #85124
Email or phone of affected tester (no customers): gocemate+b21549011@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Windows 10/Chrome
App Component: Other

Action Performed:

1, Navigate to the workspace chat and click on "+" icon and press Enter
2. Tab to "Track distance" and press Enter
3. Select a "Start" address and a "Stop" address and another "Stop" same as one of the waypoints
4. Tab to the "Start" waypoint verify focus lands on the sortable wrapper (single focus point, not two)
5. Press Space and Arrow Down to drag the waypoint to the other same as this one waypoint

Expected Result:

There should be a message "Please remove duplicate waypoints"

Actual Result:

There is no a message "Please remove duplicate waypoints". User can create track distance map with same two waypoint one ofter another

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Video.mp4

View all open jobs on GitHub

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #85124

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[OSBotify]

Investigation Summary

Classification: Frontend bug
Causing PR: #85124 - "fix: Keyboard Navigation: Track Distance: Map start/stop points cannot be reordered by using a keyboard" by @TaduJR (High confidence)
Related Issues: None

Recommendation: REVERT

PR #85124 enabled keyboard navigation for reordering distance waypoints, but the duplicate waypoint validation does not properly trigger when waypoints are reordered via keyboard drag-and-drop. Reverting this PR will restore the previous behavior where keyboard navigation was not available, preventing users from encountering this validation issue.

Labels: Keeping DeployBlockerCash (App deploy is blocked by a Frontend bug). This issue is reproducible on staging and involves an App PR that introduced the regression.

Detailed Analysis

Evidence

PR #85124 was merged on 2026-03-16 and is included in the current staging deploy (v9.3.39-0). The issue was reported on 2026-03-17 and is reproducible on staging but not in production (because the feature does not exist in prod). The melvin-bot comment confirms PR #85124 was assigned to this deploy blocker.

What Changed in PR #85124

The PR modified keyboard navigation for draggable waypoint lists:

1. src/components/DraggableList/SortableItem.tsx: Removed tabIndex={-1} override to allow keyboard focus on sortable wrappers, enabling Space key to activate drag mode and Arrow keys to reorder items
2. src/components/DraggableList/index.tsx: Replaced hardcoded keyboard shortcut strings with CONST references

These changes successfully enabled keyboard-based waypoint reordering but did not account for duplicate waypoint validation during the drag operation.

Verification

The affected files are:

• /home/runner/_work/App/App/src/components/DraggableList/SortableItem.tsx
• /home/runner/_work/App/App/src/components/DraggableList/index.tsx

PR #85124 modified both of these files to enable keyboard drag-and-drop functionality.

Root Cause

The duplicate waypoint validation logic exists in /home/runner/_work/App/App/src/pages/iou/request/step/IOURequestStepDistanceMap.tsx (lines 157-160) and /home/runner/_work/App/App/src/libs/TransactionUtils/index.ts (getValidWaypoints function, lines 1782-1836). The validation correctly detects adjacent duplicate waypoints by comparing addresses and coordinates.

However, when waypoints are reordered via the newly-enabled keyboard drag-and-drop:

1. The updateWaypoints callback is triggered with the new waypoint order
2. Optimistic state is set with the reordered waypoints
3. The validation should detect duplicates and set duplicateWaypointsError to true
4. The error message should display and prevent submission

The expected flow is not working correctly, allowing users to create distance requests with duplicate adjacent waypoints when using keyboard navigation. The exact timing or state update issue requires further debugging, but the regression is directly tied to PR #85124 enabling keyboard drag-and-drop.

[MelvinBot]

I ran out of time before I could finish helping you. This usually means the task was too complex or I got stuck exploring. Please try again with a more specific request or post in the #melvinbot-ai.

Run details: https://github.com/Expensify/Expensify/actions/runs/23197508743

[francoisl]

@TaduJR any idea about this one?

Given that it's only happening with the keyboard reordering and the warning still happens when manually reordering, I think we can demote.