[$250] “We’d hate to see you go!” reason field is not mandatory when closing an account

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.39-3
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from BrowserStack:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @trjExpensify
Slack conversation (hyperlinked to channel name): #Convert

Action Performed:

1. Navigate to Account → Security
2. Click Close account
3. Leave the “We’d hate to see you go!” field empty
4. Proceed with closing the account

Expected Result:

Attempting to close the account without entering a reason should show a validation message and block the action until a value is provided.

Actual Result:

The account can be closed without entering anything in the “We’d hate to see you go!” field.
No validation error is shown and no feedback is collected.

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Recording.2550.mp4

Recording.2551.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @Krishna2323

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022034233471726459235
• Upwork Job ID: 2034233471726459235
• Last Price Increase: 2026-03-18

[MelvinBot]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When a user navigates to Account > Security > Close Account, they can proceed with closing their account without entering anything in the "We'd hate to see you go!" reason field. No validation error is shown, and no feedback is collected.

What is the root cause of that problem?

The validate function in CloseAccountPage.tsx:64 only lists 'phoneOrEmail' as a required field when calling getFieldRequiredErrors:

const errors = getFieldRequiredErrors(values, ['phoneOrEmail'], translate);

The 'reasonForLeaving' field is completely absent from this required fields array, so the form considers it valid even when empty. The existing getFieldRequiredErrors utility and isRequiredFulfilled check in ValidationUtils.ts already handle empty string validation correctly — they just aren't being invoked for this field.

What changes do you think we should make in order to solve the problem?

Add 'reasonForLeaving' to the required fields array in the validate function of CloseAccountPage.tsx:

Change the getFieldRequiredErrors call to include both fields: ['phoneOrEmail', 'reasonForLeaving'].

This will cause the existing validation infrastructure to display the standard "This field is required" error when the reason field is left empty, blocking form submission until a value is provided.

What alternative solutions did you explore? (Optional)

We could add a separate validation check specifically for the reason field within the validate function, but that would be redundant since getFieldRequiredErrors already handles required field validation correctly. The simplest and most consistent fix is to add the field name to the existing required fields array.

---

Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.

[samranahm]

🚨 Edited by proposal-police: This proposal was edited at 2026-03-18 11:42:17 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

“We’d hate to see you go!” reason field is not mandatory when closing an account

What is the root cause of that problem?

Here

App/src/pages/settings/Security/CloseAccountPage.tsx

Lines 61 to 68 in 39c4d70

	const userEmailOrPhone = session?.email ? formatPhoneNumber(session.email) : null;
	const validate = (values: FormOnyxValues<typeof ONYXKEYS.FORMS.CLOSE_ACCOUNT_FORM>): FormInputErrors<typeof ONYXKEYS.FORMS.CLOSE_ACCOUNT_FORM> => {
	const errors = getFieldRequiredErrors(values, ['phoneOrEmail'], translate);
	if (values.phoneOrEmail && userEmailOrPhone) {
	let isValid = false;

We are only checking the phoneOrEmail field

What changes do you think we should make in order to solve the problem?

We should also include reasonForLeaving here

    const errors = getFieldRequiredErrors(values, ['reasonForLeaving', 'phoneOrEmail'], translate);

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Krishna2323 (External)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~022034233471726459235

[MobileMage]

🚫 Duplicated proposal withdrawn by 🤖 ProposalPolice.

[github-actions]

⚠️ @MobileMage Your proposal is a duplicate of an already existing proposal and has been automatically withdrawn to prevent spam. Please review the existing proposals before submitting a new one.

[chengyixu]

Proposal

Please re-state the problem that we are trying to solve in this issue.
When closing an account, the "reason for leaving" field is not mandatory. Users can close their account without providing any feedback, even though the UI has a "We'd hate to see you go!" section with a reason field.

What is the root cause of that problem?
In src/pages/settings/Security/CloseAccountPage.tsx (line 64), the validate function only checks phoneOrEmail as a required field:

const errors = getFieldRequiredErrors(values, ['phoneOrEmail'], translate);

The reasonForLeaving field is not included in the required fields array, so the form submits without it.

What changes do you think we should make in order to solve the problem?
Add 'reasonForLeaving' to the required fields array in the validate function:

const errors = getFieldRequiredErrors(values, ['reasonForLeaving', 'phoneOrEmail'], translate);

This is a one-line change. The existing getFieldRequiredErrors utility already handles required field validation — we just need to include reasonForLeaving in the list.

What alternative solutions did you explore? (Optional)
N/A — the fix is straightforward. The getFieldRequiredErrors function is the standard way to enforce required fields in Expensify forms. No new components or utilities are needed.

[melvin-bot]

📣 @chengyixu! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>