Reports - Delete option is not available for track expenses when created via "Home"

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.40-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #85427
Email or phone of affected tester (no customers): ibellicotest+2250@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Windows 11 / Chrome
App Component: Money Requests

Action Performed:

Prerequisite: Account has at least one workspace.

1. Open the staging.new.expensify.com website.
2. Navigate to "Home"
3. Click on "Expense" on the top of the page.
4. Create a manual expense and submit it to Workspace chat.
5. If infinite loading is displayed after last action, return to "Home" and reopen "Reports" > "Expenses"
6. Select the just created expense and click on dropdown menu.
7. Note that "Delete" option is available.
8. Delete the expense.
9. Return to "Home"
10. Click on "Expense" again.
11. Create a new manual expense and submit it to Self DM.
12. Once navigated to "Reports" open the expense.
13. Click on "More"
14. Note that "Delete" option is available.
15. Return to "Reports", select the expense once again and click on dropdown menu.
16. Note that "Delete" option is still not available.

Expected Result:

"Delete" option should be available when a track expense is selected on "Expenses" section on "Reports"

Actual Result:

"Delete" option is not available on "Expenses" section for track expenses created via quick actions on "Home" section.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Video.mp4

View all open jobs on GitHub

[wildan-m]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When a user creates a track expense via Home and submits it to Self DM, the "Delete" option does not appear in the bulk actions dropdown on the Reports > Expenses page, even though it appears in the individual expense's "More" menu.

What is the root cause of that problem?

In canDeleteMoneyRequestReport, ownership is determined by finding a matching IOU report action and comparing its actorAccountID to the current user:

App/src/libs/ReportUtils.ts

Lines 3109 to 3121 in 8b9009d

	const isOwner = transactionID ? getIOUActionForTransactionID(reportActions, transactionID)?.actorAccountID === currentUserAccountID : false;
	const isReportOpenOrProcessing = isOpenReport(report) || isProcessingReport(report);
	const isSingleTransaction = reportTransactions.length === 1;
	if (reportTransactions.length > 0 && reportTransactions.every((t) => isDemoTransaction(t))) {
	return true;
	}
	const isUnreported = isSelfDM(report) || transaction?.reportID === CONST.REPORT.UNREPORTED_REPORT_ID;
	const canCardTransactionBeDeleted = canDeleteCardTransactionByLiabilityType(transaction);
	if (isUnreported) {
	return isOwner && canCardTransactionBeDeleted;
	}

When the individual "More" menu calls this function, it passes report actions loaded from local Onyx data (via usePaginatedReportActions), so the ownership check succeeds.

However, when the search bulk actions dropdown calls shouldShowDeleteOption in SearchUIUtils.ts, it passes report actions from the search API response data. The search results do not include report_actions entries for self-DM reports, so the reportActions array is empty, getIOUActionForTransactionID returns undefined, and isOwner evaluates to false. Since the isUnreported branch returns isOwner && canCardTransactionBeDeleted, the function returns false and the Delete option is hidden.

What changes do you think we should make in order to solve the problem?

For self-DM reports, the current user is always the owner of their tracked expenses. We should use report.ownerAccountID as a fallback ownership check when report actions are unavailable, similar to how invoice reports already determine ownership using report?.ownerAccountID === currentUserAccountID:

App/src/libs/ReportUtils.ts

Lines 3124 to 3126 in 8b9009d

	return report?.ownerAccountID === currentUserAccountID && isReportOpenOrProcessing;
	}

The fix adds a isSelfDMOwner check that uses isSelfDM(report) && report?.ownerAccountID === currentUserAccountID, and uses it as a fallback alongside the existing isOwner check with an OR condition.

https://github.com/Expensify/App/compare/main...wildan-m:App:wildan/85697-fix-delete-track-expense?expand=1