Home - 'Add Payment Card' section shown when Invoices BA is set as default payment method

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.3.40-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #84404
Email or phone of affected tester (no customers): testexpensify9+qbd@gmail.com
Issue reported by: Applause Internal Team
Bug source: Pull Request QA execution
Device used: Windows 11, Chrome
App Component: Workspace Settings

Action Performed:

Preconditions:

• Free trial has ended.
• The user has no payment cards added.
• User has set BA as default payment method in Invoices feature within the WS. (click the three-dot button next to the bank account in the WS > Invoices, then click 'set as default payment method')

1. Go to https://staging.new.expensify.com/home

Expected Result:

When Invoices BA is set as the default payment method, the 'Add Payment Card' section should not be displayed.

Actual Result:

Even when Invoices BA is set as the default payment method, the 'Add Payment Card' section is still shown.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Video.mp4

View all open jobs on GitHub

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #84404

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[OSBotify]

🔍 Investigation Summary

Classification: Frontend bug
Causing PR: #84404 - "[Home - For You] Tighten payment card required cases" by @grgia (High confidence)
Related Issues: None

Recommendation: REVERT

PR #84404 introduced a new function shouldShowTrialEndedUI that checks whether to show the "Add Payment Card" section. However, the implementation has a logic gap: it checks if the subscription type is "invoicing" (privateSubscription.type === CONST.SUBSCRIPTION.TYPE.INVOICING), but does not check if the user has set a Bank Account as the default payment method in the workspace's Invoices feature settings.

These are two different concepts:

• Subscription type = invoicing: User is billed via invoicing (checked in the PR)
• Workspace Invoices BA as default: User has configured a Bank Account as default payment method for the workspace's invoice feature (NOT checked in the PR)

The bug report specifically mentions setting BA as default in "WS > Invoices" settings, which is a workspace configuration, not a subscription billing type.

Labels: This is a Frontend bug. Keeping DeployBlockerCash label. The DeployBlocker label is not present on this issue.

📋 Detailed Analysis

Evidence

• The issue was reported during QA of PR [Home - For You] Tighten payment card required cases #84404
• Melvin-bot automatically linked this PR as the cause
• The PR modified the logic for showing the "Add Payment Card" section
• The reproduction steps specifically mention setting BA as default in workspace Invoices settings

Verification

The PR modified these key files:

• src/libs/SubscriptionUtils.ts - Added shouldShowTrialEndedUI function
• src/pages/home/TimeSensitiveSection/hooks/useTimeSensitiveOffers.ts - Changed logic to use new function
• src/pages/settings/Subscription/CardSection/CardSection.tsx - Updated billing banner logic

The shouldShowTrialEndedUI function checks:

if (isSubscriptionTypeOfInvoicing(privateSubscriptionType)) {
    return false;
}

However, this only checks the subscription billing type, not whether the user has configured invoice payment in workspace settings.

Root Cause

The PR attempted to hide the "Add Payment Card" section for users with invoice payment, but only implemented the check for subscription type being "invoicing" billing. It did not account for users who have configured a Bank Account as the default payment method in their workspace's Invoices feature, which is a different configuration that should also hide the card prompt.

The QA steps in PR #84404 included a test case for "payment is via invoice feature" but the implementation only covered subscription-level invoicing, not workspace-level invoice configuration.

[MelvinBot]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When a user's free trial has ended and they have no payment card, but they have set a Bank Account (BA) as the default payment method in the workspace's Invoices feature, the "Add Payment Card" section is still shown on the home page. It should not be displayed when the user has a valid payment method configured.

What is the root cause of that problem?

PR #84404 introduced the shouldShowTrialEndedUI function in src/libs/SubscriptionUtils.ts (lines 598-618) which determines when to show the "Add Payment Card" widget. This function checks two payment-related conditions:

1. isSubscriptionTypeOfInvoicing(privateSubscriptionType) — returns false because the user's NVP_PRIVATE_SUBSCRIPTION.type is not invoicing2018. The invoicing2018 subscription type is a separate enterprise billing arrangement (Invoicify) set by the backend — it is not the same as having a BA configured in the workspace Invoices feature.

2. doesUserHavePaymentCardAdded(userBillingFundID) — returns false because NVP_BILLING_FUND_ID is only set when a payment card is added, not when a bank account is configured.

Setting a BA as default in workspace Invoices calls setInvoicingTransferBankAccount() (src/libs/actions/PaymentMethods.ts:559-597), which only updates policy.invoice.bankAccount.transferBankAccountID — a policy-level setting for receiving invoice payments. It does not modify NVP_BILLING_FUND_ID or NVP_PRIVATE_SUBSCRIPTION.type.

So neither check in shouldShowTrialEndedUI accounts for a user who has a bank account configured as the default payment method in workspace Invoices.

What changes do you think we should make in order to solve the problem?

In shouldShowTrialEndedUI (src/libs/SubscriptionUtils.ts), add a check that returns false if any of the user's owned paid policies has a transferBankAccountID set on policy.invoice.bankAccount. The policies collection is already passed to this function, so the check can iterate over the owned paid policies (using the same getOwnedPaidPolicies call already made on line 605) and check if any has policy?.invoice?.bankAccount?.transferBankAccountID defined. If so, the user has a valid payment method configured and the "Add Payment Card" widget should not be shown.

What alternative solutions did you explore? (Optional)

An alternative would be to check transferBankAccountID at the call site in useTimeSensitiveOffers.ts (line 28) rather than inside shouldShowTrialEndedUI. However, since the same function is also used in CardSection.tsx (line 197) for the subscription page billing banner, adding the check inside shouldShowTrialEndedUI ensures both call sites benefit from the fix.

---

Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.