[$250] Report - "Waiting for you to fix the issue" displays on admin side

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.3.43-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-12779/folder/13176707/41236904/1276031542
Email or phone of affected tester (no customers): lekima20+613703@gmail.com
Issue reported by: Applause Internal Team
Bug source: Regression TC Execution
Device used: Win 11/Chrome
App Component: Money Requests

Action Performed:

Precondition: Admin create a control workspace, invite an employee to workspace

1. Open https://staging.new.expensify.com
2. Employee create 2 scan fail expenses to workspace chat
3. Admin navigate to employee workspace chat
4. Admin click on the expense report and observe the hourglass

Expected Result:

The hourglass should display "Waiting for [submitter] to fix the issues."

Actual Result:

The hourglass displays "Waiting for you to fix the issues."

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Video.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @nyomanjyotisa

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022036492719483447772
• Upwork Job ID: 2036492719483447772
• Last Price Increase: 2026-03-24

[MelvinBot]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When an admin navigates to an employee's expense report that has scan-failed expenses, the hourglass next step displays "Waiting for you to fix the issues" instead of "Waiting for [submitter name] to fix the issues." The word "you" should only appear when the report owner themselves is viewing the report.

What is the root cause of that problem?

The function buildOptimisticFixIssueNextStep() in src/libs/NextStepUtils.ts:325-347 hardcodes the literal text "you" without any user context:

function buildOptimisticFixIssueNextStep() {
    const optimisticNextStep: ReportNextStepDeprecated = {
        message: [
            { text: 'Waiting for ' },
            { text: 'you', type: 'strong' },  // <-- always "you", regardless of viewer
            { text: ' to ' },
            { text: 'fix the issue(s)' },
        ],
    };
    return optimisticNextStep;
}

This is called from getReportNextStep() (line 381) which runs at render time in MoneyReportHeader.tsx (line 650) for every viewer when all transactions have SMARTSCAN_FAILED violations. It overrides whatever correct nextStep data was stored in Onyx, replacing it with the hardcoded "you" message for all users — including admins.

The deprecated format's parseMessage() function only substitutes "you" when the message text matches the current user's email. Since the text is already the literal string "you" (not an email), parseMessage passes it through unchanged for everyone.

What changes do you think we should make in order to solve the problem?

Modify buildOptimisticFixIssueNextStep() to accept the report owner's display name, account ID, and the current user's account ID/email, then use the same pattern as buildNextStepNew (line 534-554) — set the text to ownerDisplayName with clickToCopyText set to the current user's email when the owner IS the current user. This lets parseMessage correctly resolve "you" for the owner and the owner's display name for admins/others.

Update getReportNextStep() (line 381) to pass the report's ownerAccountID, the current user's accountID, email, and the owner display name to buildOptimisticFixIssueNextStep().

What alternative solutions did you explore? (Optional)

An alternative would be to have getReportNextStep() return the new format (with messageKey and actorAccountID) instead of the deprecated format, since buildOptimisticNextStep at line 121-127 already correctly handles this with actorAccountID: ownerAccountID. However, the deprecated format is still the primary rendering path in MoneyReportHeaderStatusBar, so fixing the deprecated builder is simpler and more consistent with existing patterns.

---

Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @nyomanjyotisa (External)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~022036492719483447772

[wildan-m]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When an admin views an employee's expense report that has scan-failed expenses, the hourglass next step displays "Waiting for you to fix the issues" instead of "Waiting for [submitter name] to fix the issues."

What is the root cause of that problem?

buildOptimisticFixIssueNextStep() hardcodes the literal string "you" without any viewer context:

App/src/libs/NextStepUtils.ts

Lines 325 to 347 in e53a325

	function buildOptimisticFixIssueNextStep() {
	const optimisticNextStep: ReportNextStepDeprecated = {
	type: 'neutral',
	icon: CONST.NEXT_STEP.ICONS.HOURGLASS,
	message: [
	{
	text: 'Waiting for ',
	},
	{
	text: `you`,
	type: 'strong',
	},
	{
	text: ' to ',
	},
	{
	text: 'fix the issue(s)',
	},
	],
	};
	return optimisticNextStep;
	}

It is called from getReportNextStep() for every viewer when all transactions have submission-blocking violations:

App/src/libs/NextStepUtils.ts

Line 381 in e53a325

return buildOptimisticFixIssueNextStep();

Since the text is the literal "you" (not an email), parseMessage() passes it through unchanged for everyone — including admins who are not the report owner.

What changes do you think we should make in order to solve the problem?

Pass the report's ownerAccountID and the current user's accountID/email into buildOptimisticFixIssueNextStep(), resolve the owner's display name, and use clickToCopyText so that parseMessage() correctly substitutes "you" only for the report owner. This follows the established pattern from buildNextStepNew():

App/src/libs/NextStepUtils.ts

Lines 534 to 554 in e53a325

	if ((isASAPSubmitBetaEnabled && hasViolations && isInstantSubmitEnabled) || shouldFixViolations) {
	optimisticNextStep = {
	type,
	icon: CONST.NEXT_STEP.ICONS.HOURGLASS,
	message: [
	{
	text: 'Waiting for ',
	},
	{
	text: `${ownerDisplayName}`,
	type: 'strong',
	clickToCopyText: ownerAccountID === currentUserAccountIDParam ? currentUserEmailParam : '',
	},
	{
	text: ' to ',
	},
	{
	text: 'fix the issues',
	},
	],
	};

Compare: https://github.com/Expensify/App/compare/main...wildan-m:App:wildan/86252-fix-issue-next-step-you?expand=1

[gps949]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When an admin views an employee's expense report with scan-failed expenses, the hourglass next step shows "Waiting for you to fix the issues" — as if the admin is the one who needs to act. It should show "Waiting for [submitter name] to fix the issues" for non-owners.

What is the root cause of that problem?

The root cause is in getReportNextStep() (src/libs/NextStepUtils.ts, line ~375-381). When all transactions have submission-blocking violations, it unconditionally overrides the backend-provided currentNextStep (which correctly personalizes "you" vs. display name) with the return value of buildOptimisticFixIssueNextStep().

buildOptimisticFixIssueNextStep() (line ~328) uses the deprecated ReportNextStepDeprecated format and hardcodes the literal string "you" as the actor text. In the deprecated format, parseMessage() (line ~258) resolves "you" only when part.text matches the current user's email or part.clickToCopyText matches — but since the text is the literal word "you" (not an email), the substitution never triggers and every viewer sees "you".

The deeper issue is that this function uses the deprecated message format at all, when the codebase already has the new ReportNextStep format with messageKey + actorAccountID that correctly resolves viewer-aware display names via buildNextStepMessage(). The new format is already used for the same WAITING_TO_FIX_ISSUES message key in buildNextStepNew() (line ~105, ~123) and MoneyReportHeaderStatusBar already supports rendering both formats.

What changes do you think we should make in order to solve the problem?

Convert buildOptimisticFixIssueNextStep() to return the new ReportNextStep format instead of the deprecated format:

function buildOptimisticFixIssueNextStep(ownerAccountID: number): ReportNextStep {
    return {
        messageKey: CONST.NEXT_STEP.MESSAGE_KEY.WAITING_TO_FIX_ISSUES,
        icon: CONST.NEXT_STEP.ICONS.HOURGLASS,
        actorAccountID: ownerAccountID,
    };
}

Then update getReportNextStep() to pass moneyRequestReport?.ownerAccountID to this function. The return type of getReportNextStep already supports the union ReportNextStep | ReportNextStepDeprecated and MoneyReportHeaderStatusBar handles both via isDeprecatedFormatNextStep().

This approach:

1. Fixes the bug — buildNextStepMessage() correctly resolves "you" vs. display name based on actorAccountID === currentUserAccountID
2. Moves toward the new format rather than patching deprecated code — consistent with the migration direction visible in the codebase
3. Is a smaller, simpler change (replacing a message array with 3 fields) with no risk of breaking the email-matching logic in parseMessage()

Implementation ready — can submit PR immediately upon assignment.

Contributor details Timezone: UTC+8, Available hours: flexible

[Islam0953]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When an admin navigates to an employee's expense report containing scan-failed expenses, the hourglass next step banner displays "Waiting for you to fix the issues" instead of "Waiting for [employee name] to fix the issues." The word "you" is always shown regardless of who is viewing the report, which is incorrect for admins -- only the report owner (the employee) should see "you."

What is the root cause of that problem?

The root cause is in src/libs/NextStepUtils.ts, specifically the buildOptimisticFixIssueNextStep() function at lines 325-347. This function hardcodes the literal string "you" with no viewer context:

function buildOptimisticFixIssueNextStep() {
    const optimisticNextStep: ReportNextStepDeprecated = {
        type: 'neutral',
        icon: CONST.NEXT_STEP.ICONS.HOURGLASS,
        message: [
            { text: 'Waiting for ' },
            { text: `you`, type: 'strong' },  // <-- always "you", no viewer awareness
            { text: ' to ' },
            { text: 'fix the issue(s)' },
        ],
    };
    return optimisticNextStep;
}