-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Closed
Labels
EngineeringImprovementItem broken or needs improvement.Item broken or needs improvement.MonthlyKSv2KSv2NewFeatureSomething to build that is a new item.Something to build that is a new item.Not a priority
Description
Problem
We are working on releasing a new help site that's hosted in this repo. It deploys whenever code is merged to main. However, its deploy can be triggered even if the changes merged are completely unrelated to the help site, which causes:
- An unnecessary deploy
- Noise in slack
- Noise in the git history
- Unnecessary bloating of the deploy checklist
Similarly, merging helpsite-related code can trigger deploys of the main NewDot platform, which causes all the same issues, except it's even worse / more noisy.
Why this is important
This wastes engineering and QA time, and may distract others as well.
Solution
Check if a PR only contains changes in the /help directory. If so:
- Don't add the PR to the main NewDot deploy checklist
- Don't trigger a NewDot deploy, and instead only deploy the helpsite
If not (changes include files not in the /help directory, don't deploy the helpsite
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
EngineeringImprovementItem broken or needs improvement.Item broken or needs improvement.MonthlyKSv2KSv2NewFeatureSomething to build that is a new item.Something to build that is a new item.Not a priority