Begin porting the web POC to react native by tgolen · Pull Request #10 · Expensify/App

tgolen · 2020-08-09T04:28:22Z

Lots of stuff in this!

Displays personal details in the header
Displays the list of reports in the sidebar (but the links don't do anything yet).
Switches web to use a hash router which should help with the refreshing
Adds direct binding the store to the state using an HOC

AndrewGable

Web works great and the code is very clean! I left some comments from my testing on iOS. I am totally happy leaving the harder ones as TODOs in the code if we mark them as such and looking at them later.

src/store/actions/PersonalDetailsActions.js

src/page/HomePage/HeaderView.js

src/style/StyleSheet.js

AndrewGable · 2020-08-09T06:20:23Z

src/style/StyleSheet.js

+        padding: 8,
+    },
+    mainContentWrapper: {
+        height: 'calc(100vh - 73px)',


Mobile does not like this line, it chokes on it. Is there anyway to refactor it to not use calc?

Ah phooey. I can keep trying, yeah.

AndrewGable · 2020-08-09T06:23:41Z

src/Expensify.js

-                    <Route path="/" component={HomePage} />
-                </Switch>
-            </Router>
+            <Beforeunload onBeforeunload={ActiveClientManager.removeClient}>


Mobile doesn't play well with this, it seems to use window quite a bit.

Dang, this was supposed to be compatible :(

I am not an expert on this event, but could we use AppState instead? It is supported by RN and RN4W out of the box: https://github.com/necolas/react-native-web#modules

I just tested this and yes it does change to inactive when the tab is changed, then back to active when it comes back. This sounds like possibly we need to handle it using a native/web solution (like Router).

AndrewGable · 2020-08-09T06:28:08Z

src/store/actions/PersonalDetailsActions.js

+            const myPersonalDetails = allPersonaDetails[currentLogin];
+            return Store.multiSet({
+                [STOREKEYS.PERSONAL_DETAILS]: allPersonaDetails,
+                [STOREKEYS.MY_PERSONAL_DETAILS]: myPersonalDetails,


Not sure if you see this on web but iOS complains whenever something is set that is undefined (as this is on boot), not sure if or when we want to set a default value, but it could keep the logs from being too noisy if we added one.

I don't think I've seen those errors, no. What is undefined when that happens. Is it myPersonalDetails or allPersonaDetails (which I just realized has a typo)

It was myPersonalDetails that was undefined

src/page/HomePage/SidebarView.js

src/lib/ActiveClientManager.js

Co-authored-by: Andrew Gable <andrewgable@gmail.com>

…eactNativeChat into tgolen-port-webpoc

Fixes #11

Fixes #13

Fixes #20

Fixes #24 Fixes #21 Fixes #20

Fixes #12

Fixes #17

src/page/HomePage/SidebarLink.js

AndrewGable · 2020-08-09T23:05:29Z

src/page/HomePage/SidebarLink.js

+                    <Text style={textActiveStyle}>{this.props.reportName}</Text>
+                    {this.state.isUnread && (
+                        <Text style={textActiveStyle}>- Unread</Text>
+                    )}


Not exactly clear why, but this needs to be wrapped in a view for iOS to work.

Suggested change

<Text style={textActiveStyle}>{this.props.reportName}</Text>

{this.state.isUnread && (

<Text style={textActiveStyle}>- Unread</Text>

)}

<View>

<Text style={textActiveStyle}>{this.props.reportName}</Text>

{this.state.isUnread && (

<Text style={textActiveStyle}>- Unread</Text>

)}

</View>

AndrewGable · 2020-08-09T23:06:13Z

src/style/StyleSheet.js

+    },
+    sidebarLinkActive: {
+        backgroundColor: '#007bff',
+        borderRadius: '.25rem',


iOS chokes on rem values too 😢

tgolen · 2020-08-09T23:17:05Z

It's worth a shot. I'm curious if that will fire on web when the tab gains/loses focus... which might not really be what we want.

…

On Sun, Aug 9, 2020 at 5:13 PM Andrew Gable ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In src/Expensify.js <#10 (comment)> : > } render() { return ( - <Router> - {/* If there is ever a property for redirecting, we do the redirect here */} - {this.state.redirectTo && <Redirect to={this.state.redirectTo} />} - - <Switch> - <Route path="/signin" component={SignInPage} /> - <Route path="/" component={HomePage} /> - </Switch> - </Router> + <Beforeunload onBeforeunload={ActiveClientManager.removeClient}> I am not an expert on this event, but could we use AppState instead? It is supported by RN and RN4W out of the box: https://github.com/necolas/react-native-web#modules — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#10 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJMAB6W752QPOZVGDS5W4DR74UR7ANCNFSM4PY7Y6VQ> .

change retry dynamics

Merge

OSBotify · 2021-04-19T22:41:56Z

🚀 [Deployed](https://github.com/Expensify/Expensify.cash
/actions/runs/765130740) 🚀 to
staging on Mon Apr 19 2021 at 22:41:56 GMT+0000 (Coordinated Universal Time)

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Help dot

OSBotify · 2023-10-03T16:10:03Z

🚀 Deployed to staging by https://github.com/AndrewGable in version: 1.3.77-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-05T00:16:53Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.77-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

* fix: ubo list hover, incorp state hover * feat: improved return type for getFieldRequiredErrors

…-settings Improve workspace settings on Main Pane

Even with main

cloudflare-workers-and-pages · 2024-03-29T12:41:51Z

Deploying helpdot with Cloudflare Pages

Latest commit:	`4f305ce`
Status:	✅ Deploy successful!
Preview URL:	https://36897b35.helpdot.pages.dev

View logs

…tion-report-view Revert "Add One Transaction Report View"

tgolen added 14 commits August 8, 2020 15:16

Remove all async and clean up pages

bef1ed1

Fix an error with merge

7a8f83b

Add some style to the header

d9cb5b3

Add styles and display a header

f55a6d4

Add the personal details action

07db03a

Add personal details to the header

4496f10

WIP on direct binding

ae9f529

Implement direct binding

b0a1575

Fix unsubscribing

f9a094a

Fix infinite session redirect

0366c4f

Build an HOC for subscribing the state to the store

f153fb5

Add a little more comment

307dfd2

Add initial sidebar and main views and lay them out

e31528b

List reports in the sidebar

a5cbde6

tgolen requested a review from AndrewGable August 9, 2020 04:28

tgolen self-assigned this Aug 9, 2020

AndrewGable reviewed Aug 9, 2020

View reviewed changes

tgolen and others added 13 commits August 9, 2020 08:07

Update src/page/HomePage/HeaderView.js

2490b9c

Co-authored-by: Andrew Gable <andrewgable@gmail.com>

Update src/style/StyleSheet.js

a02d992

Co-authored-by: Andrew Gable <andrewgable@gmail.com>

Fix typo

a3de49e

Merge branch 'tgolen-port-webpoc' of https://github.com/AndrewGable/R…

743db5f

…eactNativeChat into tgolen-port-webpoc

Use Link instead of NavLink

2f8016b

Use a simple subscription ID

67ee483

Fixes #11

Rename subscribeToState to bind

e42283d

Fixes #13

Trigger key changed after storage is set

b2a9b7e

Move the sidebar link into it's own component

8df561f

remove calc() from styles

74d5455

Fixes #20

Show the list of report names as decent links

da8177c

Fixes #24 Fixes #21 Fixes #20

Remvoe subscribe and unsubscribe for now

f2ed6a8

Fixes #12

Only create regex object when binding

04b5751

Fixes #17

tgolen added 4 commits August 9, 2020 15:33

Add some more views for displaying history items

1807767

Display history fragments

22aa79e

Better comment

c8384ab

Fix a semi-broken home page

a813cde

AndrewGable reviewed Aug 9, 2020

View reviewed changes

src/page/HomePage/SidebarLink.js Show resolved Hide resolved

AndrewGable reviewed Aug 9, 2020

View reviewed changes

Apply mobile fixes

798135c

AndrewGable merged commit 9c479ff into master Aug 10, 2020

AndrewGable deleted the tgolen-port-webpoc branch August 10, 2020 00:07

AndrewGable pushed a commit that referenced this pull request Mar 4, 2021

Merge pull request #10 from GauzStudio/fred-update-semantic-versioning

ce7ff95

change retry dynamics

Julesssss pushed a commit that referenced this pull request Apr 7, 2021

Merge pull request #10 from Expensify/master

28b7fef

Merge

stitesExpensify mentioned this pull request Oct 12, 2021

Test for new deploy checklist #5782

Closed

11 tasks

isagoico mentioned this pull request Jul 5, 2022

Search - Focus moves to the 1st line of results when the search query #9695

Closed

mountiny pushed a commit that referenced this pull request Oct 2, 2023

Merge pull request #10 from rushatgabhane/help-dot

f3ad0bf

Help dot

OSBotify mentioned this pull request Oct 3, 2023

Deploy Checklist: New Expensify 2023-10-03 #28727

Closed

MrMuzyk pushed a commit to MrMuzyk/App that referenced this pull request Jan 25, 2024

Marcin/fix vbba cr bugs (Expensify#10)

9fc619f

* fix: ubo list hover, incorp state hover * feat: improved return type for getFieldRequiredErrors

hayata-suenaga pushed a commit that referenced this pull request Feb 1, 2024

Merge pull request #10 from software-mansion-labs/ideal-nav/workspace…

a725b49

…-settings Improve workspace settings on Main Pane

francoisl pushed a commit that referenced this pull request Feb 13, 2024

Merge pull request #10 from Expensify/main

19e86ea

Even with main

thienlnam pushed a commit that referenced this pull request Apr 16, 2024

Merge pull request #10 from ishpaul777/revert-36934-nikki-one-transac…

904379f

…tion-report-view Revert "Add One Transaction Report View"

jnowakow mentioned this pull request Feb 19, 2025

[Due for payment 2025-02-27] [Due for payment 2025-02-27] Android - Reports - App crashes when switching workspaces on reports section. #57076

Closed

8 tasks

kacper-mikolajczak mentioned this pull request Nov 18, 2025

[AI Reviewer] Enforce Required Comment Format in AI Code Reviewer #75382

Closed

jakubkalinski0 mentioned this pull request Dec 23, 2025

[Odometer] Create NewDot Odometer expense flow #77576

Merged

53 tasks

Julesssss mentioned this pull request Feb 27, 2026

[NoQA] Revert: AI Reviewer reality check instruction #83758

Merged

50 tasks

Conversation

tgolen commented Aug 9, 2020

Uh oh!

AndrewGable left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AndrewGable Aug 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tgolen commented Aug 9, 2020 via email

Uh oh!

OSBotify commented Apr 19, 2021

Uh oh!

OSBotify commented Oct 3, 2023

Uh oh!

OSBotify commented Oct 5, 2023

Uh oh!

cloudflare-workers-and-pages bot commented Mar 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying helpdot with Cloudflare Pages

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

AndrewGable Aug 9, 2020 •

edited

Loading

cloudflare-workers-and-pages bot commented Mar 29, 2024 •

edited

Loading