[HOLD] Revert "Fix anchor renderer for links in report messages & clean up"#10433
Closed
[HOLD] Revert "Fix anchor renderer for links in report messages & clean up"#10433
Conversation
melvin-bot
bot
requested review from
sketchydroide
and removed request for
a team
Contributor
|
I restarted the failed tests, let's see if it helps 🤞 Also we'd want to get that CP'ed to staging, correct? |
Contributor
|
|
Contributor
Author
|
Passing but @roryabraham says this will break stuff so maybe we hold off? |
francoisl
changed the title
Contributor
|
Yeah I'm not 100% clear on the suggested way to go either, let's wait until he's back. |
Contributor
|
Sorry, the main thing that's important is that if we CP a revert, we have to wait until the next release cycle before merging this same change back into main. |
Contributor
Author
|
I think this revert is no longer needed as we chose to deploy the broken code to production because it wasn't blocker-y enough. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #10144
Fixes:
$ #10431