Skip to content

[No QA] Fix propType warning #11070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
srikarparsi merged 1 commit into from
Sep 21, 2022
Merged

[No QA] Fix propType warning #11070

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/components/AnchorForCommentsOnly/BaseAnchorForCommentsOnly.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,13 @@ import * as ContextMenuActions from '../../pages/home/report/ContextMenu/Context
import Tooltip from '../Tooltip';
import canUseTouchScreen from '../../libs/canUseTouchscreen';
import styles from '../../styles/styles';
import withWindowDimensions from '../withWindowDimensions';
import {propTypes, defaultProps} from './anchorForCommentsOnlyPropTypes';
import withWindowDimensions, {windowDimensionsPropTypes} from '../withWindowDimensions';
import {propTypes as anchorForCommentsOnlyPropTypes, defaultProps} from './anchorForCommentsOnlyPropTypes';
Copy link
Copy Markdown
Member Author

@parasharrajat parasharrajat Sep 16, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I use the import like this? Not sure if it is against StyleGuide. using import * as something from 'somthing' creates a warning.

Copy link
Copy Markdown
Contributor

@srikarparsi srikarparsi Sep 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, this should be fine👍🏾

Copy link
Copy Markdown
Member Author

@parasharrajat parasharrajat Sep 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks can we get this merged?

Copy link
Copy Markdown
Contributor

@srikarparsi srikarparsi Sep 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, hadn't tested it yesterday but I just did and it looks good


const propTypes = {
...anchorForCommentsOnlyPropTypes,
...windowDimensionsPropTypes,
};

/*
* This is a default anchor component for regular links.
Expand Down
3 changes: 0 additions & 3 deletions src/components/AnchorForCommentsOnly/anchorForCommentsOnlyPropTypes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import PropTypes from 'prop-types';
import stylePropTypes from '../../styles/stylePropTypes';
import {windowDimensionsPropTypes} from '../withWindowDimensions';

const propTypes = {
/** The URL to open */
Expand All @@ -25,8 +24,6 @@ const propTypes = {

/** Press handler for the link, when not passed, default href is used to create a link like behaviour */
onPress: PropTypes.func,

...windowDimensionsPropTypes,
};

const defaultProps = {
Expand Down