Skip to content

Remove ActivityIndicator from optimistically added comments #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tgolen merged 1 commit into from
Aug 12, 2020
Merged

Remove ActivityIndicator from optimistically added comments #112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/lib/actions/ActionsReport.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import Ion from '../Ion';
import {request, delayedWrite} from '../Network';
import IONKEYS from '../../IONKEYS';
import ExpensiMark from '../ExpensiMark';
import Guid from '../Guid';
import CONFIG from '../../CONFIG';
import * as pusher from '../Pusher/pusher';

Expand Down Expand Up @@ -199,7 +198,6 @@ function fetchHistory(reportID) {
*/
function addHistoryItem(reportID, reportComment) {
const messageParser = new ExpensiMark();
const guid = Guid();
const historyKey = `${IONKEYS.REPORT_HISTORY}_${reportID}`;

return Ion.multiGet([historyKey, IONKEYS.SESSION, IONKEYS.PERSONAL_DETAILS])
Expand All @@ -218,7 +216,6 @@ function addHistoryItem(reportID, reportComment) {
return Ion.set(historyKey, [
...reportHistory,
{
tempGuid: guid,
actionName: 'ADDCOMMENT',
actorEmail: Ion.get(IONKEYS.SESSION, 'email'),
person: [
Expand Down
2 changes: 1 addition & 1 deletion src/page/HomePage/Report/ReportHistoryCompose.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import React from 'react';
import PropTypes from 'prop-types';
import {View, TextInput, Button} from 'react-native';
import {View, TextInput} from 'react-native';
import styles from '../../../style/StyleSheet';

const propTypes = {
Expand Down
3 changes: 1 addition & 2 deletions src/page/HomePage/Report/ReportHistoryItem.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import React from 'react';
import {ActivityIndicator, View} from 'react-native';
import {View} from 'react-native';
import PropTypes from 'prop-types';
import ReportHistoryItemSingle from './ReportHistoryItemSingle';
import ReportHistoryPropsTypes from './ReportHistoryPropsTypes';
Expand All @@ -17,7 +17,6 @@ const ReportHistoryItem = ({displayAsGroup, historyItem}) => (
<View>
{!displayAsGroup && <ReportHistoryItemSingle historyItem={historyItem} />}
{displayAsGroup && <ReportHistoryItemGrouped historyItem={historyItem} />}
{historyItem.tempGuid && <ActivityIndicator type="small" color="#7d8b8f" />}
</View>
);
ReportHistoryItem.propTypes = propTypes;
Expand Down