-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Revert "OptionsSelector - Migrate setNativeProps to state" #11240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "OptionsSelector - Migrate setNativeProps to state" #11240
Conversation
|
|
|
@thienlnam looks like this was merged without passing tests. Please add a note explaining why this was done and remove the |
|
All tests passed |
…ps-optionsSelector (cherry picked from commit 72e6268)
…-11240 🍒 Cherry pick PR #11240 to staging 🍒
|
🚀 Cherry-picked to staging by @thienlnam in version: 1.2.5-1 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
|
🚀 Deployed to production by @luacmartins in version: 1.2.5-2 🚀
|
|
🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 1.3.28-2 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
Reverts #11036
$ #11239
### Fixed Issuessection aboveTestssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*filesSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */displayNamepropertythisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)Avataris modified, I verified thatAvataris working as expected in all cases)