fix "Composer goes to the top on pressing expand" by aimane-chnaif · Pull Request #11608 · Expensify/App

aimane-chnaif · 2022-10-05T15:36:07Z

Details

On pressing expand:

stretch composer to take full height
float text to top inside composer

Fixed Issues

$ #11437
PROPOSAL: #11437 (comment)

Tests

Login with any account
Go to any chat room
Add few lines and press expand button at the left corner
Verify that composer is expanded and takes full height

Verify that no errors appear in the JS console

PR Review Checklist

Contributor (PR Author) Checklist

PR Reviewer Checklist

The Contributor+ will copy/paste it into a new comment and complete it after the author checklist is completed

QA Steps

Login with any account
Go to any chat room
Add few lines and press expand button at the left corner
Verify that composer is expanded and takes full height

Verify that no errors appear in the JS console

Screenshots

Web

web.mov

Mobile Web - Chrome

mchrome.mp4

Mobile Web - Safari

msafari.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mp4

NOTE: On this GH, we don't need to care about keyboard hidden issue on mobile web. It's handled in another GH

rushatgabhane · 2022-10-05T23:09:41Z

src/pages/home/report/ReportFooter.js

                            <OfflineWithFeedback
                                pendingAction={this.props.addWorkspaceRoomPendingAction}
+                                style={this.props.isComposerFullSize && styles.chatItemFullComposeRow}
+                                contentContainerStyle={this.props.isComposerFullSize && styles.flex1}


question: is the comment staying at bottom of composer the expected behavior?

should it move to the top of the container when expanded? cc: @shawnborton

Screen.Recording.2022-10-06.at.4.34.32.AM.mov

Hmm good question - although my current Android app (staging, v1.2.11-2) does what's shown in this video - it has the comment floating at the bottom of the expanded text input, and I think it looks good that way

Hmm, I think this feels a bit strange personally. I would think the text should float to the top.

Aah ok! I think I'm happy either way, so if @shawnborton you think it should float to the top I'm down 👍

Sounds good 👍

rushatgabhane

@Beamanator LGTM! 🎉

PR Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product was added in all src/languages/* files
- I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- Any functional components have the displayName property
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Beamanator · 2022-10-10T15:34:42Z

@aimane-chnaif as per this comment would you please update so the text floats up when the report action compose is expanded?

rushatgabhane · 2022-10-11T18:30:10Z

Thank you for the changes @aimane-chnaif

Can you please update the details section of this PR to mention that text will be at top now

aimane-chnaif · 2022-10-11T18:33:14Z

Can you please update the details section of this PR to mention that text will be at top now

@rushatgabhane updated

rushatgabhane

@Beamanator LGTM! 🎉

PR Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product was added in all src/languages/* files
- I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

rushatgabhane · 2022-10-11T18:43:18Z

@Beamanator the composer loses focus when we click after the end of message.
It feels like we're deviating from the original issue. Should it be fixed in this PR itself?

Screen.Recording.2022-10-12.at.12.08.25.AM.mov

aimane-chnaif · 2022-10-11T18:54:42Z

@Beamanator the composer loses focus when we click after the end of message.
It feels like we're deviating from the original issue. Should it be fixed in this PR itself?

I suggest to fix it in this PR
https://github.com/Expensify/App/blob/main/src/styles/styles.js

    textInputFullCompose: {
-       alignSelf: 'flex-end',
+       alignSelf: 'stretch',
        flex: 1,
        maxHeight: '100%',
    },

This should work

rushatgabhane · 2022-10-11T20:30:50Z

@aimane-chnaif nicee, in that case please go ahead with the changes.
Thank you!

rushatgabhane

@Beamanator tests well!

aimane-chnaif · 2022-10-11T21:28:16Z

@rushatgabhane minor thing. I fixed prop warning, since stylePropTypes doesn't accept boolean value. This update doesn't need test.

Beamanator

Hmm it looks like you're adding a new prop contentContainerStyle to OfflineWithFeedback, but you didn't define it in the propTypes :(

That's what this point in the checklist is for:

All props are defined accurately and each prop has a /** comment above it */

@rushatgabhane looks like you missed this too 😅 Did you both miss this b/c it's under the point - [ ] If a new component is created I verified that:? Could this be clearer in the checklist that we need to define all props in propTypes definition & they all need comments?

One more thing @aimane-chnaif - it looks like all of your videos are showing previous version of the PR (text is floating to the bottom of the screen) while you updated the code so the text will float to the top - can you please update the videos so they're up to date with the latest changes? 🙏

rushatgabhane · 2022-10-17T07:23:19Z

looks like you missed this too

Sorry, I missed it because of my negligence.

Could this be clearer in the checklist that we need to define all props in propTypes definition & they all need comments

Yes, it could be clearer by adding it as a seperate point.
Note that we already have Verify that no errors appear in the JS console and that could also be sufficient??

Beamanator · 2022-10-18T11:50:24Z

Note that we already have Verify that no errors appear in the JS console and that could also be sufficient??

True, but that doesn't cover documenting all proptypes right?

Maybe nothing needs to be added to the checklist yet - would you mind re-reviewing when you have a chance @rushatgabhane ? 👍

rushatgabhane · 2022-10-18T12:59:56Z

@Beamanator while the changes look good, I have a few concerns (maybe) unrelated to the PR.

Problem 1

The TextInput loses focus when composer is expanded.

Problem 2

In the expanded view, I cannot see any recent messages.
A user might wanna see 1 or 2 messages above the expanded composer if they're replying to a message.

Screen.Recording.2022-10-18.at.6.21.56.PM.mov

Beamanator · 2022-10-18T13:27:29Z

Problem 2

In the expanded view, I cannot see any recent messages.
A user might wanna see 1 or 2 messages above the expanded composer if they're replying to a message.

Let's see what @shawnborton thinks about this point - I think for now it's ok to keep consistency with what we currently have, which is that it expands over everything - and this conversation could be brought back to #expensify-open-source as a feature request that requires some thinking

shawnborton · 2022-10-18T14:42:57Z

Yeah I think it's fine if the expand version covers everything - that's kind of the whole point of the feature.

rushatgabhane · 2022-10-18T17:02:58Z

Web

Screen.Recording.2022-10-18.at.9.35.59.PM.mov

Desktop

Screen.Recording.2022-10-18.at.6.21.56.PM.mov

mWeb

Screen.Recording.2022-10-18.at.9.44.04.PM.mov

Screen.Recording.2022-10-18.at.9.43.39.PM.mov

iOS

Screen.Recording.2022-10-18.at.9.48.41.PM.mov

Android

Screen.Recording.2022-10-18.at.10.32.15.PM.mov

rushatgabhane

@Beamanator looks good!

PR Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product was added in all src/languages/* files
- I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

melvin-bot · 2022-10-19T12:16:05Z

@Beamanator looks like this was merged without passing tests. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

Beamanator · 2022-10-19T12:16:45Z

Contributor checklist is filled out, idk why that test was failing 🙃

OSBotify · 2022-10-19T13:39:26Z

🚀 Deployed to staging by @Beamanator in version: 1.2.18-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2022-10-24T23:33:28Z

🚀 Deployed to production by @chiragsalian in version: 1.2.18-10 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix "Composer goes to the top on pressing expand"

f742741

aimane-chnaif requested a review from a team as a code owner October 5, 2022 15:36

melvin-bot bot requested review from Beamanator and rushatgabhane and removed request for a team October 5, 2022 16:06

rushatgabhane reviewed Oct 5, 2022

View reviewed changes

rushatgabhane previously approved these changes Oct 9, 2022

View reviewed changes

float text to top when composer expanded

9a643a8

aimane-chnaif dismissed rushatgabhane’s stale review via 9a643a8 October 10, 2022 15:58

aimane-chnaif requested review from Beamanator and rushatgabhane and removed request for Beamanator and rushatgabhane October 10, 2022 15:59

rushatgabhane previously approved these changes Oct 11, 2022

View reviewed changes

stretch input to full height in composer when expanded

1150a97

aimane-chnaif dismissed rushatgabhane’s stale review via 1150a97 October 11, 2022 20:51

aimane-chnaif requested review from Beamanator and rushatgabhane and removed request for Beamanator and rushatgabhane October 11, 2022 20:51

rushatgabhane previously approved these changes Oct 11, 2022

View reviewed changes

fix invalid prop warning

61e5278

aimane-chnaif dismissed rushatgabhane’s stale review via 61e5278 October 11, 2022 21:26

Beamanator requested changes Oct 12, 2022

View reviewed changes

aimane-chnaif added 2 commits October 12, 2022 19:55

add contentContainerStyle propsTypes in OfflineWithFeedback

2070b13

fix text centered in expanded composer issue in android

bbe4676

aimane-chnaif requested a review from rushatgabhane October 12, 2022 10:55

rushatgabhane approved these changes Oct 18, 2022

View reviewed changes

rushatgabhane mentioned this pull request Oct 18, 2022

Web - Chat - Composed box is not sticked to the bottom when user is using collapse and expend options. #11968

Closed

Beamanator approved these changes Oct 19, 2022

View reviewed changes

Beamanator merged commit 586ecbd into Expensify:main Oct 19, 2022

melvin-bot bot added the Emergency label Oct 19, 2022

Beamanator removed the Emergency label Oct 19, 2022

OSBotify mentioned this pull request Oct 19, 2022

Deploy Checklist: New Expensify 2022-10-19 #11979

Closed

36 tasks

thesahindia mentioned this pull request Oct 20, 2022

Web -Chat -Unable to scroll large text in expanded compose box with large text #11885

Closed

melvin-bot bot mentioned this pull request Oct 24, 2022

[HOLD for payment 2022-10-31] [$250] Chat - Composer goes to the top on pressing expand @thesahindia #11437

Closed

isagoico mentioned this pull request May 9, 2023

[$250] mWeb -Chat - Compose box - Compose box does not increase when user is trying to expand the input field #18528

Closed

6 tasks

hoangzinh mentioned this pull request Sep 28, 2023

[$500] Chat --Tapping expand button and then plus icon, the compose box becomes extra big #28201

Closed

6 tasks

aimane-chnaif deleted the fix-11437 branch January 11, 2026 18:08

Conversation

aimane-chnaif commented Oct 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

PR Review Checklist

Contributor (PR Author) Checklist

PR Reviewer Checklist

QA Steps

Screenshots

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

Uh oh!

rushatgabhane Oct 5, 2022

Choose a reason for hiding this comment

Uh oh!

Beamanator Oct 7, 2022

Choose a reason for hiding this comment

Uh oh!

rushatgabhane Oct 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shawnborton Oct 10, 2022

Choose a reason for hiding this comment

Uh oh!

Beamanator Oct 10, 2022

Choose a reason for hiding this comment

Uh oh!

shawnborton Oct 10, 2022

Choose a reason for hiding this comment

Uh oh!

rushatgabhane left a comment

Choose a reason for hiding this comment

PR Reviewer Checklist

Uh oh!

Beamanator commented Oct 10, 2022

Uh oh!

rushatgabhane commented Oct 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aimane-chnaif commented Oct 11, 2022

Uh oh!

rushatgabhane left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

PR Reviewer Checklist

Uh oh!

rushatgabhane commented Oct 11, 2022

Uh oh!

aimane-chnaif commented Oct 11, 2022

Uh oh!

rushatgabhane commented Oct 11, 2022

Uh oh!

rushatgabhane left a comment

Choose a reason for hiding this comment

Uh oh!

aimane-chnaif commented Oct 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Beamanator left a comment

Choose a reason for hiding this comment

Uh oh!

rushatgabhane commented Oct 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Beamanator commented Oct 18, 2022

Uh oh!

rushatgabhane commented Oct 18, 2022

Problem 1

Problem 2

Uh oh!

Beamanator commented Oct 18, 2022

Uh oh!

shawnborton commented Oct 18, 2022

aimane-chnaif commented Oct 5, 2022 •

edited

Loading

rushatgabhane Oct 9, 2022 •

edited

Loading

rushatgabhane commented Oct 11, 2022 •

edited

Loading

rushatgabhane left a comment •

edited

Loading

aimane-chnaif commented Oct 11, 2022 •

edited

Loading

rushatgabhane commented Oct 17, 2022 •

edited

Loading

rushatgabhane left a comment •

edited

Loading