-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Workspaces list #11784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Workspaces list #11784
Changes from all commits
Commits
Show all changes
55 commits
Select commit
Hold shift + click to select a range
06b816f
Adding workspaces to languages
chiragsalian 65ffc10
a new route and menu item
chiragsalian 77167cf
a new modal screen
chiragsalian 657b6e6
updating modal stack navigator with new workspacesPage
chiragsalian 7e2d1f5
New workspaces page
chiragsalian 1c3078e
correcting the back button
chiragsalian f245ef2
Path rename so all workspace files are in the same place
chiragsalian 08e8c9a
removing unused code and trying some stuff
chiragsalian 163988e
adding avatars to the end of workspace
chiragsalian dce19a0
support for fallbackIcons. unsure why avatar component is not used in…
chiragsalian bd79e90
passing policy avatars
chiragsalian 36315ce
Removing new workspace button from 3 dots and adding it as footer
chiragsalian f473b46
defining AVATAR_SIZE SMALLER
chiragsalian c9e1454
cleaning up MultipleAvatars component to work with both avatar and icon
chiragsalian 58c59b8
shouldStackHorizontally param
chiragsalian bb47b9f
styles
chiragsalian bd10ede
displaying multiple avatars vertically
chiragsalian e2f65f8
using building icon instead of workspace
chiragsalian 08aed4e
update to show both avatar and overlay
chiragsalian afd5b66
overlay opacity and style fixes
chiragsalian dc024c6
style cleanup
chiragsalian 8ddb462
cleanup
chiragsalian de140aa
perfecting the styles
chiragsalian 2a30e05
style corrections to make the avatars work when there are less than 4…
chiragsalian a13652d
Merge branch 'main' into chirag-workspaces-list
chiragsalian 84eb382
adding a positioning style
chiragsalian 89d5a96
correcting avatar styles
chiragsalian 362518b
correct avatar styles with red brick road indicator
chiragsalian d828d75
adding blocking view for when workspaces are empty
chiragsalian b54f3de
workspaces language update
chiragsalian ba261a5
correcting a style
chiragsalian 9fa8fd3
Merge branch 'main' into chirag-workspaces-list
chiragsalian d71b7bc
logic correction
chiragsalian ce16a35
cleanup
chiragsalian ee600aa
Merge branch 'main' into chirag-workspaces-list
chiragsalian 18bfe1b
copy corrections
chiragsalian 541663a
cleanup
chiragsalian ae0d150
added key to fix js console error
chiragsalian 7e29244
updating avatar to match order
chiragsalian 875e498
using span cause view breaks avatar arrangement
chiragsalian 27f3699
bug fix
chiragsalian 74deaf1
count correction
chiragsalian 2b438b0
variable name correction
chiragsalian 9747791
style overhaul to prevent js error and look good
chiragsalian d4e1879
fighting to get the styles right without js error
chiragsalian b8bdb8e
Merge branch 'main' into chirag-workspaces-list
chiragsalian 4ba7415
correcting red brick road dot logic
chiragsalian 3c6d5bc
Merge branch 'main' into chirag-workspaces-list
chiragsalian 9d640dd
updating logic for pending deleted workspaces
chiragsalian 964f9d7
Merge branch 'main' into chirag-workspaces-list
chiragsalian faa8210
logic correction
chiragsalian ff6e5de
adding shouldStackHorizontally prop
chiragsalian 1423fd4
subscribing to beta and adding prop
chiragsalian a2a847f
lint fix
chiragsalian 18a237d
making lint happy
chiragsalian File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,6 +16,7 @@ import menuItemPropTypes from './menuItemPropTypes'; | |
| import SelectCircle from './SelectCircle'; | ||
| import colors from '../styles/colors'; | ||
| import variables from '../styles/variables'; | ||
| import MultipleAvatars from './MultipleAvatars'; | ||
|
|
||
| const propTypes = { | ||
| ...menuItemPropTypes, | ||
|
|
@@ -46,6 +47,8 @@ const defaultProps = { | |
| interactive: true, | ||
| fallbackIcon: Expensicons.FallbackAvatar, | ||
| brickRoadIndicator: '', | ||
| floatRightAvatars: [], | ||
| shouldStackHorizontally: false, | ||
| }; | ||
|
|
||
| const MenuItem = (props) => { | ||
|
|
@@ -150,8 +153,18 @@ const MenuItem = (props) => { | |
| </Text> | ||
| </View> | ||
| )} | ||
| {!_.isEmpty(props.floatRightAvatars) && ( | ||
| <View style={[styles.justifyContentCenter, (props.brickRoadIndicator ? styles.mr4 : styles.mr3)]}> | ||
| <MultipleAvatars | ||
| icons={props.floatRightAvatars} | ||
| size={props.viewMode === CONST.OPTION_MODE.COMPACT ? CONST.AVATAR_SIZE.SMALL : CONST.AVATAR_SIZE.DEFAULT} | ||
| fallbackIcon={Expensicons.Workspace} | ||
| shouldStackHorizontally={props.shouldStackHorizontally} | ||
| /> | ||
| </View> | ||
| )} | ||
| {Boolean(props.brickRoadIndicator) && ( | ||
| <View style={[styles.alignItemsCenter, styles.justifyContentCenter]}> | ||
| <View style={[styles.alignItemsCenter, styles.justifyContentCenter, styles.l4]}> | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We had a small inconsistent padding issue caused by this change. Issue: #18418 |
||
| <Icon | ||
| src={Expensicons.DotIndicator} | ||
| fill={props.brickRoadIndicator === 'error' ? colors.red : colors.green} | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.