[No QA] Remove pip install for wheel#11939
Conversation
|
|
|
None of the PR checklist items apply here so I'm going to ignore them and merge this with the CP staging label to live-test. |
|
@roryabraham looks like this was merged without passing tests. Please add a note explaining why this was done and remove the |
|
Removed Emergency label, explanation above ^ |
…tall (cherry picked from commit b514f83)
…-11939 🍒 Cherry pick PR #11939 to staging 🍒
|
🚀 Cherry-picked to staging by @roryabraham in version: 1.2.17-4 🚀
|
|
🚀 Deployed to production by @sketchydroide in version: 1.2.17-4 🚀
|
|
🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 1.3.28-2 🚀
|
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.28-5 🚀
|
Details
In testing #11934, we found that this line is no longer needed.
Fixed Issues
n/a
Tests
Merge and monitor web deploy.
PR Review Checklist
PR Author Checklist
### Fixed Issuessection aboveTestssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*filesSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)Avataris modified, I verified thatAvataris working as expected in all cases)PR Reviewer Checklist
The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed
### Fixed Issuessection aboveTestssectionQA stepssectiontoggleReportand notonIconClick).src/languages/*filesSTYLE.md) were followedAvatar, I verified the components usingAvatarhave been tested & I retested again)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)Avataris modified, I verified thatAvataris working as expected in all cases)QA Steps
None