Fix saving draft values for Checkboxes by rushatgabhane · Pull Request #12080 · Expensify/App

rushatgabhane · 2022-10-23T16:24:37Z

Details

All details here #11687 (comment)

Fixed Issues

$ #11687
PROPOSAL: #11687 (comment)

Tests

Steps to verify if shouldSaveDraft feature works for checkbox.

Revert commit 8b4559b
Login to E/App
Go to Settings
Go to any workspace -> Connect bank account page
Tick the checkbox "I accept the Expensify Terms of service"
Close the page via clicking ❌ icon on top right
Repeat steps 3 and 4
Verify that the checkbox is ticked.

Verify that no errors appear in the JS console

QA Steps

Login to E/App
Go to Settings
Go to any workspace -> Connect bank account page
Tick the checkbox "I accept the Expensify Terms of service"
Close the page via clicking ❌ icon on top right
Repeat steps 2 and 3
Verify that the checkbox is NOT ticked.

Verify that no errors appear in the JS console

PR Review Checklist

PR Author Checklist

PR Reviewer Checklist

The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed

Screenshots

Web

Screen.Recording.2022-10-23.at.10.25.32.PM.mov

Mobile Web

Screen.Recording.2022-10-23.at.10.28.06.PM.mov

Desktop

Screen.Recording.2022-10-23.at.10.33.49.PM.mov

iOS

Screen.Recording.2022-10-23.at.10.36.47.PM.mov

Android

Screen.Recording.2022-10-23.at.10.42.32.PM.mov

melvin-bot · 2022-10-23T16:24:39Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

rushatgabhane · 2022-10-23T16:26:28Z

no change in docs melvin

rushatgabhane · 2022-10-23T17:47:44Z

idk why PR author checklist is failing 🤷‍♀️

parasharrajat · 2022-10-23T18:24:16Z

src/components/CheckboxWithLabel.js

-
-    /** The ID used to uniquely identify the input in a Form */
-    inputID: PropTypes.string,
-
-    /** Saves a draft of the input value when used in a form */
-    shouldSaveDraft: PropTypes.bool,


Why are we removing these?

@parasharrajat oops, i blindly ran npx eslint --fix.
Reverted the commit.

rushatgabhane · 2022-10-23T18:39:18Z

@MonilBhavsar gh auto removed you as a reviewer when I requested a review from Rajat :/

src/components/CheckboxWithLabel.js

Co-authored-by: Rajat Parashar <parasharrajat@users.noreply.github.com>

parasharrajat

LGTM.

cc: @MonilBhavsar

PR Reviewer Checklist

Screenshots

🔲 iOS / native

screen-2022-10-24_01.56.03.mp4

🔲 iOS / Safari

screen-2022-10-24_01.27.51.mp4

🔲 MacOS / Desktop

screen-2022-10-24_01.24.22.mp4

🔲 MacOS / Chrome

screen-2022-10-24_01.08.44.mp4

🔲 Android / Chrome

screen-2022-10-24_01.10.09.mp4

🔲 Android / native

screen-2022-10-24_01.09.23.mp4

MonilBhavsar

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product was added in all src/languages/* files
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

melvin-bot · 2022-10-27T08:44:28Z

@MonilBhavsar looks like this was merged without the checklist test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

OSBotify · 2022-10-27T08:49:21Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

MonilBhavsar · 2022-10-27T10:04:15Z

Hmm, tests were passing when I merged it

OSBotify · 2022-10-28T03:28:21Z

🚀 Deployed to staging by @MonilBhavsar in version: 1.2.21-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2022-10-31T18:04:35Z

🚀 Deployed to production by @Julesssss in version: 1.2.21-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

rushatgabhane added 5 commits October 23, 2022 21:40

fix: form draft for checkboxWithLabel

2f2c1bb

feat: remove drafts for T&C

8b4559b

remove dead props passed to checkbox

37066cd

fix: propTypes

124ce80

fix: defaultProps

41b545f

rushatgabhane marked this pull request as ready for review October 23, 2022 17:45

rushatgabhane requested a review from a team as a code owner October 23, 2022 17:45

melvin-bot bot requested review from MonilBhavsar and parasharrajat and removed request for a team October 23, 2022 17:45

parasharrajat suggested changes Oct 23, 2022

View reviewed changes

revert remove form props

6c69f15

rushatgabhane requested review from parasharrajat and removed request for MonilBhavsar October 23, 2022 18:38

parasharrajat reviewed Oct 23, 2022

View reviewed changes

src/components/CheckboxWithLabel.js Outdated Show resolved Hide resolved

fix: prop comment

50c66dd

Co-authored-by: Rajat Parashar <parasharrajat@users.noreply.github.com>

parasharrajat approved these changes Oct 23, 2022

View reviewed changes

MonilBhavsar self-requested a review October 27, 2022 06:17

MonilBhavsar approved these changes Oct 27, 2022

View reviewed changes

MonilBhavsar merged commit 654bdf4 into Expensify:main Oct 27, 2022

melvin-bot bot added the Emergency label Oct 27, 2022

MonilBhavsar removed the Emergency label Oct 27, 2022

OSBotify mentioned this pull request Oct 28, 2022

Deploy Checklist: New Expensify 2022-10-28 #12223

Closed

20 tasks

melvin-bot bot mentioned this pull request Oct 31, 2022

[HOLD for payment 2022-11-07] [$250] BUG: Checkbox current state is not saved in draft on Connect bank account page reported by @parasharrajat #11687

Closed

Conversation

rushatgabhane commented Oct 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

QA Steps

PR Review Checklist

PR Author Checklist

PR Reviewer Checklist

Screenshots

Web

Mobile Web

Desktop

iOS

Android

Uh oh!

melvin-bot bot commented Oct 23, 2022

Uh oh!

rushatgabhane commented Oct 23, 2022

Uh oh!

rushatgabhane commented Oct 23, 2022

Uh oh!

parasharrajat Oct 23, 2022

Choose a reason for hiding this comment

Uh oh!

rushatgabhane Oct 23, 2022

Choose a reason for hiding this comment

Uh oh!

rushatgabhane commented Oct 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

parasharrajat left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

PR Reviewer Checklist

Screenshots

🔲 iOS / native

🔲 iOS / Safari

🔲 MacOS / Desktop

🔲 MacOS / Chrome

🔲 Android / Chrome

🔲 Android / native

Uh oh!

MonilBhavsar left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Oct 27, 2022

Uh oh!

OSBotify commented Oct 27, 2022

Uh oh!

MonilBhavsar commented Oct 27, 2022

Uh oh!

OSBotify commented Oct 28, 2022

Uh oh!

OSBotify commented Oct 31, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

rushatgabhane commented Oct 23, 2022 •

edited

Loading

rushatgabhane commented Oct 23, 2022 •

edited

Loading

parasharrajat left a comment •

edited

Loading