Refactor "new action" logic in ReportActionsView to fix new marker #12169

marcaaron · 2022-10-27T00:02:41Z

Details

Fixed Issues

$ #11726

Tests

Same as QA

Verify that no errors appear in the JS console

QA Steps

New message marker set correctly when report is default while signing in

Open two sessions one as User A and one as User B
Make sure User B is navigated to the chat with User A
Sign out User B
Create message as User A on chat with User B and wait 10 seconds
Sign in User B
Verify the chat with User A loads
Verify that new marker is set correctly
Verify that the chat in the LHN is marked as read

New message marker set correctly when navigating to unread chat after signing in

Open two sessions one as User A and one as User B
Make sure User B is navigate to a chat other than the chat with User A
Sign out User B
Create message as User A on chat with User B and wait 10 seconds
Sign in User B
Navigate to chat with User A as User B
Verify that new marker is set correctly
Verify that the chat in the LHN is marked as read

New message marker set correctly when navigating to unread chat after opening app

Open two sessions one as User A and one as User B
Make sure User B is navigate to a chat other than the chat with User A
Close tab (or kill app) with User B (Do not sign out)
Create message as User A on chat with User B and wait 10 seconds
Open a new tab (or app) as User B
Navigate to chat with User A as User B
Verify that new marker is set correctly
Verify that the chat in the LHN is marked as read

New message marker set correctly when navigating to directly to unread chat

Open two sessions one as User A and one as User B
Make sure User B is navigate to the chat with User A and save the URL
Close User B tab (or kill app)
Create message as User A on chat with User B and wait 10 seconds
Open tab (or app) as User B using the URL saved from the second step (on native use a deep link)
See that new marker is set correctly
Verify that the chat in the LHN is marked as read

Verify that no errors appear in the JS console

PR Review Checklist

PR Author Checklist

PR Reviewer Checklist

The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed

Screenshots

QA testing is intense for these flows as there are 4 test cases to look at. I'm only posting videos for 1 scenario, but they should all be tested.

Web

2022-11-01_12-46-08.mp4

Mobile Web - Chrome

2022-11-01_13-49-44.mp4

Mobile Web - Safari

2022-11-01_13-40-23.mp4

Desktop

2022-11-01_12-51-27.mp4

iOS

2022-11-01_13-22-17.mp4

Android

2022-11-01_13-46-41.mp4

…e chat

src/libs/actions/Report.js

src/pages/home/ReportScreen.js

Beamanator · 2022-11-02T17:18:49Z

Sorry didn't get to review today, will prioritize this tomorrow

marcaaron · 2022-11-02T21:12:48Z

Updated

parasharrajat · 2022-11-03T13:48:28Z

Testing...

Beamanator

Looking good & testing well for me, I like the loads of comments since we're doing some funky stuff, but overall it's making sense 👍 Won't merge till @parasharrajat does his review

parasharrajat · 2022-11-04T14:07:10Z

I am facing some issues with Mac so I won't be able to test all platforms until that issue is fixed.

Hoping to get it fixed asap and get back on it.

Thanks

marcaaron · 2022-11-04T16:36:03Z

@Beamanator Can you jump in here and help test on all platforms? We need at least one person to post the checklist.

Beamanator · 2022-11-04T16:40:26Z

Fak I'm no longer at my laptop for about 5 hours, sorry - can test Sunday if that's ok for you

Beamanator · 2022-11-07T13:51:17Z

IOS App w/ Chrome

When logging out / logging in:

Screen.Recording.2022-11-07.at.3.23.36.PM.mov

When closing & opening app (notice the new message shows in iOS LHN, when opening the report it is shown a bit late w/ an animation - is that on purpose?):

Screen.Recording.2022-11-07.at.3.25.31.PM.mov

iOS Safari w/ Android

When logging out / logging in:

Screen.Recording.2022-11-07.at.3.39.42.PM.mov

When closing & opening app (looks like iOS Safari mWeb didn't get the "unread" marker 🤔 :

Screen.Recording.2022-11-07.at.3.41.40.PM.mov

but it worked this way??

Screen.Recording.2022-11-07.at.3.44.54.PM.mov

Android Chrome w/ Desktop

When logging out / logging in:

Screen.Recording.2022-11-07.at.3.47.44.PM.mov

When closing & opening app:

Screen.Recording.2022-11-07.at.3.48.46.PM.mov

Beamanator · 2022-11-07T13:52:33Z

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product was added in all src/languages/* files
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

OSBotify · 2022-11-07T13:58:56Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

marcaaron · 2022-11-07T17:28:39Z

Thanks for testing @Beamanator !

notice the new message shows in iOS LHN, when opening the report it is shown a bit late w/ an animation - is that on purpose?

Expected, yes! It's just a consequence of how we load reports first then load comments second when tapping into the chat. There are some discussions floating around about how to improve this IIRC.

When closing & opening app (looks like iOS Safari mWeb didn't get the "unread" marker

Hmm hard to say, but I think I'd expect that to work. I probably would have rejected this PR for not passing the test steps. But we can see if it happens for QA and if a new issue needs to be created we'll look into it.

OSBotify · 2022-11-08T19:39:03Z

🚀 Deployed to staging by @Beamanator in version: 1.2.25-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2022-11-09T21:14:05Z

🚀 Deployed to production by @yuwenmemon in version: 1.2.25-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

…tActions Reverts elements from #12169

…tActions Reverts elements from #12169 (cherry picked from commit c85be58)

marcaaron · 2022-11-15T23:51:57Z

Heads up @Beamanator @parasharrajat elements of this PR were reverted because they caused a pretty nasty regression related to offline behavior here. I think we can all learn from this PR by making sure to test offline behaviors and include them in the test steps for our future PRs. Thanks.

parasharrajat · 2022-11-15T23:53:51Z

Sadly, I didn't get the chance to test it. But I agree offline testing is a must for this PR.

marcaaron · 2022-11-15T23:57:41Z

offline testing is a must for ~~this PR~~ all PRs ? 😄

parasharrajat · 2022-11-15T23:59:12Z

Correct 😅 . Saw your update.

Refactor "new action" logic in ReportActionsView

4728ab3

marcaaron self-assigned this Oct 27, 2022

marcaaron mentioned this pull request Oct 28, 2022

Make Onyx.update() return a promise Expensify/react-native-onyx#206

Merged

marcaaron added 5 commits October 28, 2022 06:01

Wait for initial reports to load at least once before rendering activ…

4964e56

…e chat

fix conflict

b827be7

clean up test

7b37d36

Add some logs. Fix a new edge.

6fc30b7

Fix conflicts

5b04853

marcaaron changed the title ~~[WIP] Refactor "new action" logic in ReportActionsView to fix new marker~~ Refactor "new action" logic in ReportActionsView to fix new marker Nov 1, 2022

remove Log stuff

8fdb29c

marcaaron marked this pull request as ready for review November 1, 2022 23:55

marcaaron requested a review from a team as a code owner November 1, 2022 23:55

melvin-bot bot requested review from Beamanator and parasharrajat and removed request for a team November 1, 2022 23:55

parasharrajat suggested changes Nov 2, 2022

View reviewed changes

src/libs/actions/Report.js Outdated Show resolved Hide resolved

src/pages/home/ReportScreen.js Outdated Show resolved Hide resolved

Fix typos caught by Rajat

7ca7a6b

marcaaron requested a review from parasharrajat November 2, 2022 19:07

Beamanator approved these changes Nov 3, 2022

View reviewed changes

Beamanator merged commit 449888a into main Nov 7, 2022

Beamanator deleted the marcaaron-newMarkerFix branch November 7, 2022 13:53

OSBotify mentioned this pull request Nov 8, 2022

Deploy Checklist: New Expensify 2022-11-08 #12563

Closed

34 tasks

0xmiroslav mentioned this pull request Nov 9, 2022

fix composer hidden while loading messages #12505

Merged

92 tasks

This was referenced Nov 9, 2022

Pasting in link to report navigates to the LHN on small screen mobile-web devices #12597

Closed

[$1000] No new marker if tab opened via link to the specific chat #12598

Closed

mollfpr mentioned this pull request Nov 11, 2022

[$1000] Skeleton UI is displayed when clicking on any chat reported by @thesahindia #12635

Closed

fedirjh mentioned this pull request Nov 13, 2022

Chat - Content is not loading after network return if the App starts while offline #12574

Closed

mountiny added a commit that referenced this pull request Nov 15, 2022

Merge pull request #12722 from Expensify/marcaaron-revertWaitForRepor…

c85be58

…tActions Reverts elements from #12169

OSBotify pushed a commit that referenced this pull request Nov 15, 2022

Merge pull request #12722 from Expensify/marcaaron-revertWaitForRepor…

497f3d7

…tActions Reverts elements from #12169 (cherry picked from commit c85be58)

fedirjh mentioned this pull request Sep 14, 2023

Create REPORT_METADATA onyx key to separate report loading logic from the report data #26173

Closed

57 tasks

Refactor "new action" logic in ReportActionsView to fix new marker #12169

Refactor "new action" logic in ReportActionsView to fix new marker #12169

Uh oh!

Conversation

marcaaron commented Oct 27, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

QA Steps

PR Review Checklist

PR Author Checklist

PR Reviewer Checklist

Screenshots

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

Uh oh!

Uh oh!

Uh oh!

Beamanator commented Nov 2, 2022

Uh oh!

marcaaron commented Nov 2, 2022

Uh oh!

parasharrajat commented Nov 3, 2022

Uh oh!

Beamanator left a comment

Choose a reason for hiding this comment

Uh oh!

parasharrajat commented Nov 4, 2022

Uh oh!

marcaaron commented Nov 4, 2022

Uh oh!

Beamanator commented Nov 4, 2022

Uh oh!

Beamanator commented Nov 7, 2022

IOS App w/ Chrome

iOS Safari w/ Android

Android Chrome w/ Desktop

Uh oh!

Beamanator commented Nov 7, 2022

Uh oh!

OSBotify commented Nov 7, 2022

Uh oh!

marcaaron commented Nov 7, 2022

Uh oh!

OSBotify commented Nov 8, 2022

Uh oh!

OSBotify commented Nov 9, 2022

Uh oh!

marcaaron commented Nov 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

parasharrajat commented Nov 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

marcaaron commented Nov 15, 2022

Uh oh!

parasharrajat commented Nov 15, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

marcaaron commented Oct 27, 2022 •

edited

Loading

marcaaron commented Nov 15, 2022 •

edited

Loading

parasharrajat commented Nov 15, 2022 •

edited

Loading