[No QA] Core Branding: Add dark theme for internal testing by grgia · Pull Request #12478 · Expensify/App

grgia · 2022-11-04T19:12:33Z

Details

Screen.Recording.2022-11-16.at.2.46.30.PM.mov

This PR will not change the colors. We will use this to update all other branding changes locally before officially switching to the new dark color theme in a separate PR.

To use the new colors in your PR, change the export in themes/default.js from oldTheme to darkTheme.

Completed:

Added dark colors to colors.js and darkTheme to default.js
Removed all direct references to old colors (gray1-gray4, etc)
Cleaned up repetitive success/danger color names in the theme file.
Updated ghost UI colors and splash screen colors to react to theme change.

Fixed Issues

#12440

Tests

Verify that no errors appear in the JS console

Normal Regression Tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

PR Reviewer Checklist

The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed

Screenshots

Web

Chat	Settings	Workspace

Mobile Web - Chrome

LHN	Chat	Settings	Workspace

Mobile Web - Safari

LHN	Chat	Settings	Workspace

Desktop

LHN	Chat	Settings	Workspace

iOS

LHN	Chat	Settings	Workspace

Android

LHN	Chat	Settings	Workspace

src/styles/themes/default.js

Luke9389

Generally looking good. I'm not too too concerned about the naming but I figured I'd ask now even if we change it later.

src/styles/colors.js

src/components/ReportHeaderSkeletonView.js

Luke9389

Just one NAB. LMK if you wanna fix it.

Luke9389 · 2022-11-16T23:13:22Z

src/styles/colors.js

@@ -1,21 +1,42 @@
+/**
+ * DO NOT import colors.js into files.


You could include "use theme.js instead" here

Luke9389 · 2022-11-16T23:22:44Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product was added in all src/languages/* files
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

melvin-bot · 2022-11-17T01:02:11Z

@neil-marcellini Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

shawnborton · 2022-11-17T01:10:54Z

Dope! What's the best way to test this?

OSBotify · 2022-11-17T01:13:40Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

grgia · 2022-11-17T02:49:10Z

If you're able to get your dev environment up and running again, you can change the last line of /themes/default.js from export default oldTheme; to export default darkTheme; and you'll see the new colors!

OSBotify · 2022-11-17T08:24:24Z

🚀 Deployed to staging by @Luke9389 in version: 1.2.29-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

michaelhaxhiu · 2022-11-17T13:37:17Z

Did we have a regression from this PR, whereby font color used for buttons changed?

https://expensify.slack.com/archives/C049HHMV9SM/p1668665477914149

From staging:

New	Old

aldo-expensify · 2022-11-17T20:58:52Z

@michaelhaxhiu seems like. I see it in the payments page too:

michaelhaxhiu · 2022-11-17T21:03:14Z

Cool, seems @grgia is on it already 👍
#12822 (comment)

OSBotify · 2022-11-22T17:04:42Z

🚀 Deployed to production by @AndrewGable in version: 1.2.29-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

alex-mechler · 2022-12-08T21:03:30Z

Commenting for completion of the BZ checklist, this caused a display issue with the date selector on ios because the theme of the component was not updated. #13203

1:1 swap to dark mode colors.

c935d51

grgia changed the title ~~Switch default color theme to dark mode.~~ [WIP] Switch default color theme to dark mode. Nov 4, 2022

grgia added 6 commits November 7, 2022 13:36

Define temp color names in colors.js / use in theme file.

54bd43f

Remove colors import from styles.js, replace with themeColors

4726435

WIP clean up color imports for gray1-gray4 and appBG.

a98a18a

Clean up themeColors references, particularly success/danger colors.

0bc83d7

Use dark theme for Onfido Component

23ee309

Clean up default.js and colors.js files

16c27f2

grgia commented Nov 8, 2022

View reviewed changes

src/styles/themes/default.js Show resolved Hide resolved

Fix incorrect themeColors key in styles.js

37103ea

grgia requested review from Luke9389 and shawnborton November 8, 2022 06:14

Luke9389 reviewed Nov 8, 2022

View reviewed changes

src/styles/colors.js Show resolved Hide resolved

src/styles/colors.js Show resolved Hide resolved

shawnborton reviewed Nov 8, 2022

View reviewed changes

src/styles/colors.js Outdated Show resolved Hide resolved

grgia added 3 commits November 8, 2022 16:37

Update Skeleton UI to dark theme colors

0ad17a5

Add blueLink and bring back branded blue in colors.js

7b87b65

Add warning yellow to themeColors

b9844e6

grgia commented Nov 9, 2022

View reviewed changes

src/components/ReportHeaderSkeletonView.js Show resolved Hide resolved

Switch borderFocus to green, remove extra line

40ce341

shawnborton mentioned this pull request Nov 15, 2022

Update Concierge icon #12425

Merged

95 tasks

grgia added 2 commits November 16, 2022 13:31

Merge branch 'main' into georgia-new-color-theme

d710f07

Make oldTheme / darkTheme accessible from default.js

9c56c21

grgia changed the title ~~[WIP] Switch default color theme to dark mode.~~ [WIP] Core Branding: Add dark theme for internal testing Nov 16, 2022

grgia added 2 commits November 16, 2022 14:33

Fix lint, update splash screen background color

b3f01fe

Adding cardBG key for other core branding PRs

61bcfd8

Luke9389 previously approved these changes Nov 16, 2022

View reviewed changes

grgia changed the title ~~[WIP] Core Branding: Add dark theme for internal testing~~ [No QA] Core Branding: Add dark theme for internal testing Nov 17, 2022

grgia marked this pull request as ready for review November 17, 2022 01:01

grgia requested a review from a team as a code owner November 17, 2022 01:01

melvin-bot bot requested review from neil-marcellini and removed request for a team November 17, 2022 01:02

Specify to use theme/default.js

dcc598c

grgia dismissed Luke9389’s stale review via dcc598c November 17, 2022 01:03

Luke9389 approved these changes Nov 17, 2022

View reviewed changes

grgia self-assigned this Nov 17, 2022

Luke9389 merged commit c1bb678 into main Nov 17, 2022

Luke9389 deleted the georgia-new-color-theme branch November 17, 2022 01:08

OSBotify mentioned this pull request Nov 17, 2022

Deploy Checklist: New Expensify 2022-11-17 #12812

Closed

35 tasks

mountiny mentioned this pull request Nov 17, 2022

Text color appears black for all the buttons in the site - Reported by dhairyasenjaliya #12822

Closed

alex-mechler mentioned this pull request Dec 8, 2022

[HOLD for payment 2022-12-15] [HOLD for payment 2022-12-06] iOS - The dropdown menu text is very hard to see in date selector #13203

Closed

Conversation

grgia commented Nov 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

QA Steps

PR Author Checklist

PR Reviewer Checklist

Screenshots

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

Uh oh!

Uh oh!

Luke9389 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Luke9389 left a comment

Choose a reason for hiding this comment

Uh oh!

Luke9389 Nov 16, 2022

Choose a reason for hiding this comment

Uh oh!

Luke9389 commented Nov 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Nov 17, 2022

Uh oh!

shawnborton commented Nov 17, 2022

Uh oh!

OSBotify commented Nov 17, 2022

Uh oh!

grgia commented Nov 17, 2022

Uh oh!

OSBotify commented Nov 17, 2022

Uh oh!

michaelhaxhiu commented Nov 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aldo-expensify commented Nov 17, 2022

Uh oh!

michaelhaxhiu commented Nov 17, 2022

Uh oh!

OSBotify commented Nov 22, 2022

Uh oh!

alex-mechler commented Dec 8, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

grgia commented Nov 4, 2022 •

edited

Loading

Luke9389 commented Nov 16, 2022 •

edited

Loading

michaelhaxhiu commented Nov 17, 2022 •

edited

Loading