Update expensify-common dependency by cristipaval · Pull Request #12720 · Expensify/App

cristipaval · 2022-11-14T20:00:22Z

Details

This PR addresses 2 issues, that's why there are 2 sets of testing steps.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/238874
$ #12511

Tests and QA Steps

Tests for handling custom subject messages

Run the app
Open any chat and send a custom subject message like following:
# Test how h1 looks
H1 tags now should have text of size 17px and bottom margin o size 8px
Check the style of the custom subject to have text of size 17px and bottom margin of size 8px

Tests for markdown links with trailing spaces

Run npm run clean and npm install to get the latest markdown changes on dev.

Sign in with any account
Go to any chat
Paste in a markdown link with trailing spaces in the title e.x [ test ](https://www.expensify.com/)
Verify that the link message is exactly "test" and is blue and underlined.

Verify that no errors appear in the JS console

PR Author Checklist

PR Reviewer Checklist

The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed

Screenshots

Handling custom subject messages

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

Tests for markdown links with trailing spaces

Web

web.mov

Mobile Web - Chrome

android-chrome.mov

Mobile Web - Safari

ios-safari.mp4

Desktop

desktop.mov

iOS

ios.mp4

Android

android.mov

melvin-bot · 2022-11-14T20:00:51Z

@Santhosh-Sellavel @marcochavezf One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

neil-marcellini · 2022-11-14T23:53:46Z

Hey @cristipaval. I'm working on this issue and we recently made some changes to expensify-common as well. Would you please add my issue to the fixed issues section and test these steps as well?

Sign in with any account
Go to any chat
Paste in a markdown link with trailing spaces in the title e.x [ test ](https://www.expensify.com/)
Verify that the link message is exactly "test" and is blue and underlined.

cristipaval · 2022-11-15T12:12:55Z

Hey @cristipaval. I'm working on this issue and we recently made some changes to expensify-common as well. Would you please add my issue to the fixed issues section and test these steps as well?

Sign in with any account

Go to any chat

Paste in a markdown link with trailing spaces in the title e.x [ test ](https://www.expensify.com/)

Verify that the link message is exactly "test" and is blue and underlined.

Hey @neil-marcellini! Sure, the testing steps and the fixed issues sections are now updated. Feel free to add screenshots for your tests.

neil-marcellini · 2022-11-15T18:09:44Z

@cristipaval Thanks! I added screen recordings for the trailing space tests. Also please merge main to fix the conflicts.

…fy-common # Conflicts: # package-lock.json # package.json

cristipaval · 2022-11-15T20:32:44Z

Ready for review.

Santhosh-Sellavel · 2022-11-17T18:50:39Z

Will get to this tomorrow!

Santhosh-Sellavel · 2022-11-19T09:09:11Z

Ah sorry, I couldn't able to get this sooner!

Santhosh-Sellavel · 2022-11-19T09:09:49Z

Testing now!

Santhosh-Sellavel · 2022-11-19T10:10:52Z

Bug: An extra line was added above.

Only the text below was sent, after sent try edit the text look there is extra line above

# Test how h1 looks
H1 tags now should have text of size 17px and bottom margin o size 8px

Screen.Recording.2022-11-19.at.3.38.45.PM.mov

cc: @cristipaval

Santhosh-Sellavel · 2022-11-19T10:23:44Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product was added in all src/languages/* files
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Desktop & Web

Screen.Recording.2022-11-19.at.3.32.01.PM.mov

iOS & Android

Native_And_IOS.mov

Mobile Web - Chrome

Screen_Recording_20221119_153745_Chrome.mp4

Mobile Web - Safari

iOS.mp4

Santhosh-Sellavel · 2022-11-19T10:38:00Z

@cristipaval

Tests pass. But a doubt are we adding support for using one # only to just support h1, not for ## to support h2?

This happens on staging also, so mostly this should not blocking, but I'll wait for your answer before approving thanks!

cc: @marcochavezf

Santhosh-Sellavel

Tests pass, just need some clarification here other wise looks good!

cristipaval · 2022-11-21T11:26:51Z

@cristipaval

Tests pass. But a doubt are we adding support for using one # only to just support h1, not for ## to support h2?

This happens on staging also, so mostly this should not blocking, but I'll wait for your answer before approving thanks!

cc: @marcochavezf

Hey @Santhosh-Sellavel ! Thanks for reviewing! No, we don't have support for ## yet. We only support # (h1) for now because we use it for sending custom subject messages (which internally have special behaviour but you can't test it. It was tested internally).

Santhosh-Sellavel · 2022-11-21T15:20:17Z

Then We are good here!

Santhosh-Sellavel

Looks good, tests well
Over to you @marcochavezf!

OSBotify · 2022-11-21T19:42:11Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2022-11-22T16:36:14Z

🚀 Deployed to staging by @marcochavezf in version: 1.2.30-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2022-11-22T17:45:59Z

🚀 Deployed to staging by @marcochavezf in version: 1.2.30-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Santhosh-Sellavel · 2022-11-22T23:33:54Z

@cristipaval / @neil-marcellini / @marcochavezf Can you assign a BZ here to track payment for PR review?

neil-marcellini · 2022-11-23T00:09:07Z

The BZ member assigned to the issue will pay you, which is @abekkala.

OSBotify · 2022-11-24T00:04:21Z

🚀 Deployed to production by @luacmartins in version: 1.2.30-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Santhosh-Sellavel · 2022-12-05T16:43:41Z

@abekkala this is due for Payment!

abekkala · 2022-12-05T17:01:31Z

@neil-marcellini

The BZ member assigned to the issue will pay you, which is @abekkala.

Was Santosh's review for GH 12511? I did payouts for that one last week but didn't see him assigned to the issue that I'm assigned to? Can I confirm what his Review payout is for?
I was unaware that he needed a review payout for that issue as he wasn't assigned. So I need some clarification if his review payout is for that issue (12511) or if he is getting paid out via a different issue?

Santhosh-Sellavel · 2022-12-05T17:04:43Z

cc: @cristipaval

@neil-marcellini

The BZ member assigned to the issue will pay you, which is @abekkala.

Was Santosh's review for GH 12511? I did payouts for that one last week but didn't see him assigned to the issue that I'm assigned to? Can I confirm what his Review payout is for? I was unaware that he needed a review payout for that issue as he wasn't assigned. So I need some clarification if his review payout is for that issue (12511) or if he is getting paid out via a different issue?

neil-marcellini · 2022-12-05T17:28:37Z

@abekkala C+ reviewers are automatically assigned to every App PR and they get paid for their review. There's no requirement for them to be assigned to the issue. In this case @Santhosh-Sellavel should be paid for reviewing this PR, and any other PRs that he reviewed in relation to #12511. Of course, he's only paid once per PR.

I had a hard time finding this process in our documentation, so please start a Slack conversation in #bug-zero about adding this to our guidelines.

abekkala · 2022-12-05T17:53:24Z

PR review has been Paid! 🎉

Update expensify-common dependency.

0179d2f

cristipaval requested a review from a team as a code owner November 14, 2022 20:00

cristipaval self-assigned this Nov 14, 2022

melvin-bot bot requested review from Santhosh-Sellavel and marcochavezf and removed request for a team November 14, 2022 20:00

Fix conflicts with main.

ebc28fe

cristipaval force-pushed the cristi_update-expensify-common branch from f75fdc3 to ebc28fe Compare November 15, 2022 20:22

Merge remote-tracking branch 'origin/main' into cristi_update-expensi…

7633cec

…fy-common # Conflicts: # package-lock.json # package.json

rushatgabhane mentioned this pull request Nov 18, 2022

[HOLD for payment 2022-12-02] [$250] Link with trailing spaces doesn't got trimmed reported by @kerupuksambel #12511

Closed

Santhosh-Sellavel reviewed Nov 19, 2022

View reviewed changes

Santhosh-Sellavel approved these changes Nov 21, 2022

View reviewed changes

marcochavezf approved these changes Nov 21, 2022

View reviewed changes

marcochavezf merged commit e1111bc into main Nov 21, 2022

marcochavezf deleted the cristi_update-expensify-common branch November 21, 2022 19:36

OSBotify mentioned this pull request Nov 22, 2022

Deploy Checklist: New Expensify 2022-11-22 #12934

Closed

40 tasks

Conversation

cristipaval commented Nov 14, 2022 • edited by neil-marcellini Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests and QA Steps

Tests for handling custom subject messages

Tests for markdown links with trailing spaces

PR Author Checklist

PR Reviewer Checklist

Screenshots

Handling custom subject messages

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

Tests for markdown links with trailing spaces

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

Uh oh!

melvin-bot bot commented Nov 14, 2022

Uh oh!

neil-marcellini commented Nov 14, 2022

Uh oh!

cristipaval commented Nov 15, 2022

Uh oh!

neil-marcellini commented Nov 15, 2022

Uh oh!

cristipaval commented Nov 15, 2022

Uh oh!

Santhosh-Sellavel commented Nov 17, 2022

Uh oh!

Santhosh-Sellavel commented Nov 19, 2022

Uh oh!

Santhosh-Sellavel commented Nov 19, 2022

Uh oh!

Santhosh-Sellavel commented Nov 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Santhosh-Sellavel commented Nov 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Santhosh-Sellavel commented Nov 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Santhosh-Sellavel left a comment

Choose a reason for hiding this comment

Uh oh!

cristipaval commented Nov 21, 2022

Uh oh!

Santhosh-Sellavel commented Nov 21, 2022

Uh oh!

Santhosh-Sellavel left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Nov 21, 2022

Uh oh!

OSBotify commented Nov 22, 2022

Uh oh!

OSBotify commented Nov 22, 2022

Uh oh!

Santhosh-Sellavel commented Nov 22, 2022

Uh oh!

neil-marcellini commented Nov 23, 2022

Uh oh!

OSBotify commented Nov 24, 2022

Uh oh!

Santhosh-Sellavel commented Dec 5, 2022

Uh oh!

abekkala commented Dec 5, 2022

Uh oh!

Santhosh-Sellavel commented Dec 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

cristipaval commented Nov 14, 2022 •

edited by neil-marcellini

Loading

Santhosh-Sellavel commented Nov 19, 2022 •

edited

Loading

Santhosh-Sellavel commented Nov 19, 2022 •

edited

Loading

Santhosh-Sellavel commented Nov 19, 2022 •

edited

Loading

Santhosh-Sellavel commented Dec 5, 2022 •

edited

Loading