Remove Report_IOUs key from Onyx by Gonals · Pull Request #12780 · Expensify/App

Gonals · 2022-11-16T16:25:31Z

Details

Fixed Issues

$ #10525

Tests

This doesn't add new functionality, so we should just do general flow tests to confirm nothing broke:

Test login in. Chats should load correctly.
Test creating a new chat.
Test creating a money request
Test splitting a money request

Verify that no errors appear in the JS console

Offline tests

There should be no relevant offline behavior changes

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

PR Reviewer Checklist

The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed

Screenshots

No real UI changes

melvin-bot · 2022-11-16T16:26:02Z

@mollfpr @aldo-expensify One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mountiny

Nice work so far

src/libs/ReportUtils.js

src/libs/OptionsListUtils.js

src/libs/SidebarUtils.js

Gonals · 2022-11-18T10:30:44Z

There is one new console error, but it will get fixed after the cleanup

Gonals · 2022-11-18T11:04:54Z

Ready for review! Only HELD by the Web-E counterpart

mollfpr · 2022-11-18T13:12:21Z

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for expected offline behavior are in the Offline steps section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product was added in all src/languages/* files
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

12780.Desktop.mov

iOS

12780.iOS.mov

Android

12780.Android.mov

mollfpr · 2022-11-18T13:17:09Z

The IOUBadge shows 0 after login, where it should be showing the amount after login. The amount will be replaced after I viewed the chat.

Screen.Recording.2022-11-18.at.20.11.38.mov

Screen.Recording.2022-11-18.at.20.17.52.mov

mountiny

The code looks good to me. The web api code is in staging so @mollfpr you can now test if you build the apps with staging API. So you need to build desktop app for web and in native apps probably hardcode the staging url

We need to wait for the PR to be in production before merging though

mountiny · 2022-11-25T11:41:44Z

@Gonals There are some merge conflicts, can you please resolve them?

Gonals · 2022-11-25T11:56:07Z

Conflicts solved!

mountiny

Tested well, putting this back on hold for the PR since we cannot merge this before we hit production on the web API PR.

I have included videos in this comment with the checklist #12780 (comment)

Wont merge yet

mollfpr

LGTM 👍

The checklist and videos #12780 (comment)

mountiny · 2022-11-28T10:47:38Z

@Gonals Once again merge conflicts 🙇

Gonals · 2022-11-28T11:02:21Z

@Gonals Once again merge conflicts 🙇

Solved!

aldo-expensify · 2022-11-28T18:27:58Z

https://github.com/Expensify/Web-Expensify/pull/35594 was deployed to production ~3 hours ago, should we remove the hold or wait a bit?

mountiny · 2022-11-28T18:31:19Z

I think we can remove yeah

Gonals · 2022-11-29T09:30:43Z

OFF HOLD, then! Let's do this 🎉

mountiny

Tested fine for me @mollfpr do you want to give this a test?

mollfpr · 2022-11-29T14:53:16Z

Yup, I guess I can test with DEV env now?

Gonals · 2022-11-29T15:01:55Z

Yup, I guess I can test with DEV env now?

You should be able to test normally now, yep :)

mollfpr · 2022-11-29T15:49:28Z

Reviewed and test well 👍

cc @mountiny @Gonals

Screenshots/Videos

Web

12780.Web.mov

Mobile Web - Chrome

12780.mWeb-Chrome.mov

Mobile Web - Safari

12780.mWeb-Safari.mov

Desktop

12780.Desktop.mov

iOS

12780.iOS.1.mov

12780.iOS.2.mov

Android

12780.Android.1.mov

Gonals · 2022-11-29T15:58:50Z

Awesome! I think we are good to merge, then, @mountiny @aldo-expensify

mountiny · 2022-11-29T16:46:37Z

@aldo-expensify feel free to merge once you get online.

thanks @mollfpr for testing 🙇

OSBotify · 2022-11-29T18:21:13Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2022-11-30T04:10:19Z

🚀 Deployed to staging by @aldo-expensify in version: 1.2.34-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2022-12-01T16:13:45Z

🚀 Deployed to production by @luacmartins in version: 1.2.34-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Gonals added 6 commits November 16, 2022 15:25

Add helper function to detect IOU reports

8267958

replace straight-forward ones

dd4c8ab

distribute chats and IOUs correctly

63e15cc

correctly display chats on sidebar

b2af42c

NOW correctly displaying chats

ee4657e

cleanup of more detailed parts

5930840

Gonals requested a review from a team as a code owner November 16, 2022 16:25

melvin-bot bot requested review from aldo-expensify and mollfpr and removed request for a team November 16, 2022 16:25

Gonals mentioned this pull request Nov 16, 2022

[HOLD for payment 2022-12-08] Explore cleaning up reportIOUS_ collection key #10525

Closed

mountiny reviewed Nov 16, 2022

View reviewed changes

src/libs/ReportUtils.js Outdated Show resolved Hide resolved

aldo-expensify reviewed Nov 16, 2022

View reviewed changes

src/libs/OptionsListUtils.js Show resolved Hide resolved

aldo-expensify reviewed Nov 16, 2022

View reviewed changes

src/libs/SidebarUtils.js Outdated Show resolved Hide resolved

Gonals added 6 commits November 17, 2022 12:05

return null instead of false

52d154a

Move function upwards

9caf179

more cleanup

759026e

Merge branch 'main' into alberto-IOUs

73fe8fd

typo

2e805c0

fix issue when deleting reports

291080a

Gonals changed the title ~~[WIP] Remove Report_IOUs key from Onyx~~ Remove Report_IOUs key from Onyx Nov 18, 2022

Gonals added 2 commits November 18, 2022 11:50

Merge branch 'main' into alberto-IOUs

a65da3a

change helper function

75e73a3

Gonals changed the title ~~Remove Report_IOUs key from Onyx~~ [HOLD] Remove Report_IOUs key from Onyx Nov 18, 2022

mountiny assigned Gonals Nov 21, 2022

mountiny changed the title ~~[HOLD] Remove Report_IOUs key from Onyx~~ Remove Report_IOUs key from Onyx Nov 25, 2022

mountiny reviewed Nov 25, 2022

View reviewed changes

conflicts

d421065

mountiny changed the title ~~Remove Report_IOUs key from Onyx~~ [HOLD] Remove Report_IOUs key from Onyx Nov 25, 2022

mountiny previously approved these changes Nov 25, 2022

View reviewed changes

mollfpr previously approved these changes Nov 27, 2022

View reviewed changes

merge conflicts

6eca538

Gonals dismissed stale reviews from mollfpr and mountiny via 6eca538 November 28, 2022 11:01

mountiny changed the title ~~[HOLD] Remove Report_IOUs key from Onyx~~ Remove Report_IOUs key from Onyx Nov 28, 2022

mountiny approved these changes Nov 29, 2022

View reviewed changes

aldo-expensify merged commit c7d3c86 into main Nov 29, 2022

aldo-expensify deleted the alberto-IOUs branch November 29, 2022 18:16

OSBotify mentioned this pull request Nov 30, 2022

Deploy Checklist: New Expensify 2022-11-30 #13180

Closed

32 tasks

luacmartins mentioned this pull request Nov 30, 2022

Web - Login - The error in the console after login in HT account #13205

Closed

Conversation

Gonals commented Nov 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

PR Reviewer Checklist

Screenshots

Uh oh!

melvin-bot bot commented Nov 16, 2022

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Gonals commented Nov 18, 2022

Uh oh!

Gonals commented Nov 18, 2022

Uh oh!

mollfpr commented Nov 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Screenshots

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

Uh oh!

mollfpr commented Nov 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny commented Nov 25, 2022

Uh oh!

Gonals commented Nov 25, 2022

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

mollfpr left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mountiny commented Nov 28, 2022

Uh oh!

Gonals commented Nov 28, 2022

Uh oh!

aldo-expensify commented Nov 28, 2022

Uh oh!

mountiny commented Nov 28, 2022

Uh oh!

Gonals commented Nov 29, 2022

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

mollfpr commented Nov 29, 2022

Uh oh!

Gonals commented Nov 29, 2022

Uh oh!

mollfpr commented Nov 29, 2022

Screenshots/Videos

Uh oh!

Gonals commented Nov 29, 2022

Uh oh!

mountiny commented Nov 29, 2022

Uh oh!

OSBotify commented Nov 29, 2022

Uh oh!

OSBotify commented Nov 30, 2022

Uh oh!

OSBotify commented Dec 1, 2022

Gonals commented Nov 16, 2022 •

edited

Loading

mollfpr commented Nov 18, 2022 •

edited

Loading

mollfpr commented Nov 18, 2022 •

edited

Loading

mollfpr left a comment •

edited

Loading