Skip to content

keeps highlighted the preferred skinton emoji #12860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
francoisl merged 1 commit into from
Nov 21, 2022
Merged

keeps highlighted the preferred skinton emoji #12860

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/EmojiPicker/EmojiSkinToneList.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ class EmojiSkinToneList extends Component {
onHoverOut={() => this.setState({highlightedIndex: -1})}
key={skinToneEmoji.code}
emoji={skinToneEmoji.code}
isHighlighted={skinToneEmoji.skinTone === this.state.highlightedIndex}
isHighlighted={skinToneEmoji.skinTone === this.state.highlightedIndex || skinToneEmoji.skinTone === selectedEmoji.skinTone}
Copy link
Contributor

@rayane-d rayane-d Dec 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, this caused the following issue: #52918
We need to make sure that state.highlightedIndex is updated when the selectedEmoji.skinTone is changed, otherwise, two emoji skin tones will be highlighted at the same time.
More details can be found in this proposal: #52918 (comment)

/>
))
}
Expand Down