Skip to content

[NO QA] Allow notification debugging for release builds on Android #12964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arosiclair merged 5 commits into from
Nov 28, 2022
Merged

[NO QA] Allow notification debugging for release builds on Android #12964

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
53642d8
enable verbose Airship logs
Julesssss Nov 23, 2022
d385a07
switch to environment specific airship config and update key name
Julesssss Nov 23, 2022
046298a
Merge branch 'main' into jules-debuggableReleaseBuild
Julesssss Nov 25, 2022
ba390f6
additional Airship debug logging
Julesssss Nov 25, 2022
4cd0d67
Merge branch 'main' into jules-debuggableReleaseBuild
Julesssss Nov 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions android/app/src/debug/assets/airshipconfig.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
appKey = uulSSfTDQJ2r0PMpjRrhmQ
appSecret = D4Bhf0HrQEehrPua74Tyiw
inProduction = false
developmentLogLevel = VERBOSE

# Notification Customization
notificationIcon = ic_notification
notificationAccentColor = #2EAAE2
7 changes: 7 additions & 0 deletions android/app/src/e2eRelease/assets/airshipconfig.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
appKey = 55vypj0ARc6cN09MX7ogtQ
appSecret = EsSaqbdLSvmyC6kSBFJCtQ
inProduction = true

# Notification Customization
notificationIcon = ic_notification
notificationAccentColor = #2EAAE2
9 changes: 0 additions & 9 deletions android/app/src/main/assets/airshipconfig.properties
View file
Open in desktop

This file was deleted.

7 changes: 7 additions & 0 deletions android/app/src/release/assets/airshipconfig.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
appKey = 55vypj0ARc6cN09MX7ogtQ
appSecret = EsSaqbdLSvmyC6kSBFJCtQ
inProduction = true

# Notification Customization
notificationIcon = ic_notification
notificationAccentColor = #2EAAE2
8 changes: 4 additions & 4 deletions ios/AirshipConfig.plist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@
<dict>
<key>detectProvisioningMode</key>
<true/>
<key>developmentAppKey</key>
<key>appKey</key>
<string>uulSSfTDQJ2r0PMpjRrhmQ</string>
<key>developmentAppSecret</key>
<key>appSecret</key>
<string>D4Bhf0HrQEehrPua74Tyiw</string>
<key>productionAppKey</key>
<key>appKey</key>
<string>55vypj0ARc6cN09MX7ogtQ</string>
<key>productionAppSecret</key>
<key>appSecret</key>
<string>EsSaqbdLSvmyC6kSBFJCtQ</string>
</dict>
Copy link
Copy Markdown
Contributor

@cristipaval cristipaval Dec 16, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just FYI: This file shouldn't have been changed. It introduced this regression. According to this Slack message from Airship team, it is fine to have appKey, appSecret for Android and developmentAppKey, developmentAppSecret, productionAppKey, productionAppSecret for iOS. Here is a PR to fix this.

Copy link
Copy Markdown
Contributor Author

@Julesssss Julesssss Dec 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhh, that's a bit annoying that they don't align their SDKs. Nice find though and thanks for raising it.

</plist>